Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046842Retail ModulesWeb POSpublic2021-05-26 12:562021-06-03 08:56
Reporterjetxarri 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR20Q3.4Fixed in VersionRR21Q3 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046842: Not possible to print an Invoice created in another store
DescriptionJAVA class
modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/Invoices.java

Is not taking into account that invoice is cross store or not when retrieving the taxes.

It should follow the behaviour of
modules/org.openbravo.retail.posterminal/src/org/openbravo/retail/posterminal/PaidReceipts.java

Where before getting the taxes is disabling filter by organization
if (jsonsent.has("crossStore") && jsonsent.get("crossStore") != JSONObject.NULL) {
            qTaxes.setFilterOnReadableOrganization(false);
          }
Steps To Reproduce-Create a role with access to store A only
-Create one ticket an invoice in store B
-Login with created role in the store A
-Open the ticket generated in store B from store A
-Click on print of the menu
-Select the invoice and press Print Invoice
Proposed Solution
Additional Information
TagsNOR
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-05-26 12:56jetxarriNew Issue
2021-05-26 12:56jetxarriAssigned To => Retail
2021-05-26 12:56jetxarriOBNetwork customer => No
2021-05-26 12:56jetxarriTriggers an Emergency Pack => No
2021-05-26 12:56jetxarriTag Attached: NOR
2021-05-26 13:15rafarodaOBNetwork customerNo => Gold
2021-05-26 13:15rafarodaResolution time => 1622844000
2021-05-26 21:30rqueraltaAssigned ToRetail => rqueralta
2021-05-28 18:36rqueraltaStatusnew => scheduled
2021-06-01 16:29hgbotMerge Request Status => open
2021-06-01 16:29hgbotNote Added: 0128873
2021-06-02 09:44hgbotMerge Request Statusopen => approved
2021-06-02 09:44hgbotResolutionopen => fixed
2021-06-02 09:44hgbotStatusscheduled => closed
2021-06-02 09:44hgbotFixed in Version => RR21Q3
2021-06-02 09:44hgbotNote Added: 0128924
2021-06-02 09:44hgbotNote Added: 0128925
2021-06-02 09:59marvintmNote Added: 0128929
2021-06-02 09:59marvintmStatusclosed => new
2021-06-02 09:59marvintmResolutionfixed => open
2021-06-02 09:59marvintmFixed in VersionRR21Q3 =>
2021-06-03 05:47hgbotNote Added: 0128976
2021-06-03 08:56hgbotNote Added: 0128989
2021-06-03 08:56hgbotNote Added: 0128990
2021-06-03 08:56marvintmStatusnew => scheduled
2021-06-03 08:56marvintmStatusscheduled => resolved
2021-06-03 08:56marvintmFixed in Version => RR21Q3
2021-06-03 08:56marvintmResolutionopen => fixed
2021-06-03 08:56marvintmReview Assigned To => marvintm
2021-06-03 08:56marvintmStatusresolved => closed

Notes
(0128873)
hgbot   
2021-06-01 16:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/446 [^]
(0128924)
hgbot   
2021-06-02 09:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a7d38196f7bfbe99747f2ff21842a4fde313bd03
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-06-02T07:44:41+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a7d38196f7bfbe99747f2ff21842a4fde313bd03 [^]

Fixed BUG-46842: Disabling filter by organization in cross-store flow

---
M src/org/openbravo/retail/posterminal/Invoices.java
---
(0128925)
hgbot   
2021-06-02 09:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/446 [^]
(0128929)
marvintm   
2021-06-02 09:59   
In fact the fix doesn't work correctly after all, even though the code doesn't break anything, the crossStore property is not being sent so it doesn't do anything.
(0128976)
hgbot   
2021-06-03 05:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/452 [^]
(0128989)
hgbot   
2021-06-03 08:56   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c865f9b16ec7dd1f5039035415c05fe87e68238f
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-06-03T06:56:04+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c865f9b16ec7dd1f5039035415c05fe87e68238f [^]

Fix BUG-46842: Checking by cross store definition in organization instead read the crossStore json property

---
M src/org/openbravo/retail/posterminal/Invoices.java
---
(0128990)
hgbot   
2021-06-03 08:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/452 [^]