Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046821POS2POSpublic2021-05-25 10:072021-06-09 13:17
Reporterjcbourgeois 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046821: JIRA 1436 - A right click on a product opens Windows contextual menu
DescriptionWhen right clicking (=appui long with touchscreen) on a product in the ticket, a windows menu is displayed instead of POS menu (with discounts, quantity, delete…).
In case of left or right click, the display of POS menu is required.
Steps To Reproduce1) Add a product on a ticket
2) Right click on the product : a windows menu is diplayed (instead of POS menu with quantity, discounts...)
Proposed SolutionWhen POS is NOT in development right click will not show OS contextual dialog as it is happening in old version of POS. If secondary action is defined appropiate action will be triggered
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0046869TAP closed jarmendariz JIRA 1436 - A right click on a product opens Windows contextual menu 
has duplicate defect 0046923 closed Retail JIRA 1436 - Chrome contextual menu available on right-click/long press 
Attached Filespng 2021-05-25 10_06_54-Openbravo POS2.png (20,994) 2021-05-25 10:07
https://issues.openbravo.com/file_download.php?file_id=15825&type=bug
png

png 2021-05-25 10_06_46-Openbravo POS2.png (27,444) 2021-05-25 10:07
https://issues.openbravo.com/file_download.php?file_id=15826&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-05-25 10:07jcbourgeoisNew Issue
2021-05-25 10:07jcbourgeoisAssigned To => Retail
2021-05-25 10:07jcbourgeoisFile Added: 2021-05-25 10_06_54-Openbravo POS2.png
2021-05-25 10:07jcbourgeoisOBNetwork customer => Gold
2021-05-25 10:07jcbourgeoisTriggers an Emergency Pack => No
2021-05-25 10:07jcbourgeoisFile Added: 2021-05-25 10_06_46-Openbravo POS2.png
2021-05-25 12:17dbazNote Added: 0128612
2021-05-26 12:12guilleaerResolution time => 1623189600
2021-05-26 12:12guilleaerAssigned ToRetail => platform
2021-05-26 12:12guilleaerProposed Solution updated
2021-05-27 13:38guilleaerStatusnew => acknowledged
2021-05-27 13:38guilleaerResolution time1623189600 => 1623362400
2021-05-27 13:38guilleaerStatusacknowledged => scheduled
2021-05-27 13:39guilleaerStatusscheduled => acknowledged
2021-05-28 11:13guilleaerProposed Solution updated
2021-06-01 13:32guilleaerRelationship addedhas duplicate 0046923
2021-06-01 14:54jmelinSummaryJIRA 1942 - A right click on a product opens Windows contextual menu => JIRA 1436 - A right click on a product opens Windows contextual menu
2021-06-03 18:59jarmendarizAssigned Toplatform => jarmendariz
2021-06-04 13:14dmiguelezStatusacknowledged => scheduled
2021-06-08 17:22hgbotMerge Request Status => open
2021-06-08 17:22hgbotNote Added: 0129206
2021-06-09 13:11hgbotMerge Request Statusopen => approved
2021-06-09 13:17hgbotNote Added: 0129261
2021-06-09 13:17hgbotResolutionopen => fixed
2021-06-09 13:17hgbotStatusscheduled => closed
2021-06-09 13:17hgbotNote Added: 0129262

Notes
(0128612)
dbaz   
2021-05-25 12:17   
Left click = short tap = primary action
Right click = long tap = secondary action

In this case there is only defined the "primary action", like many applications behave, including our old WebPOS.

Other applications do different things with the secondary action. Here for example they allow to drag&drop lines: https://youtu.be/sij1mKGdcrw [^]

If for any specific purposes there is a need to have the primary action equals the secondary one, there are two ways of handling it:
* As a customization
* As a Feature Request to add a new backoffice configuration screen that let's the user to select which is going to be the behavior with the primary action and the secondary one.
(0129206)
hgbot   
2021-06-08 17:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/548 [^]
(0129261)
hgbot   
2021-06-09 13:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/548 [^]
(0129262)
hgbot   
2021-06-09 13:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a7c5f672f94d4e9d275628178bb876ad8964521b
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-06-09T12:46:32+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a7c5f672f94d4e9d275628178bb876ad8964521b [^]

Fixed ISSUE-46821: Disabling system context menu on production environment.

In applications running in a 'production' environment, we want to prevent showing the system's
context menu when right-clicking on the screen and showing only our right click actions. In order
to do that, we override the window's oncontextmenu event handler to return false (that is, not
showing the context menu) when the NODE_ENV is set to 'production'. Else, in development or testing mode,
this menu will be shown as usual.

---
M web-jspack/org.openbravo.core2/src/index.jsx
---