Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046820POS2POSpublic2021-05-25 10:032021-06-01 15:29
Reporterjavietxe 
Assigned TojavierRodriguez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046820: Discount printName should be shown when it is defined instead of discount name
DescriptionIn the POS2, the printed name is not being taken into account when showing the list of discounts to apply in the discounts window. It shows always the value in the name column
Steps To ReproduceGo to backoffice-> discounts and promotions.

Write a printed name to a discount different from the name.

Go to the POS2 -> discounts

See that the name of the discount showing is the name.
Proposed Solution
Additional Information
TagsTakeaway
Relationships
depends on backport 0046822TAP closed javierRodriguez Discount printName should be shown when it is defined instead of discount name 
Attached Filespng image_2021_05_24T17_10_40_521Z.png (80,667) 2021-05-25 10:04
https://issues.openbravo.com/file_download.php?file_id=15824&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-05-25 10:03javietxeNew Issue
2021-05-25 10:03javietxeAssigned To => Retail
2021-05-25 10:03javietxeOBNetwork customer => Gold
2021-05-25 10:03javietxeResolution time => 1623103200
2021-05-25 10:03javietxeTriggers an Emergency Pack => No
2021-05-25 10:04javietxeTag Attached: Takeaway
2021-05-25 10:04javietxeFile Added: image_2021_05_24T17_10_40_521Z.png
2021-05-25 10:27guilleaerStatusnew => scheduled
2021-05-25 10:27guilleaerAssigned ToRetail => javierRodriguez
2021-05-30 18:31hgbotMerge Request Status => open
2021-05-30 18:31hgbotNote Added: 0128785
2021-06-01 11:38hgbotMerge Request Statusopen => approved
2021-06-01 15:29hgbotResolutionopen => fixed
2021-06-01 15:29hgbotStatusscheduled => closed
2021-06-01 15:29hgbotNote Added: 0128865
2021-06-01 15:29hgbotNote Added: 0128866
2021-06-01 15:29hgbotNote Added: 0128867

Notes
(0128785)
hgbot   
2021-05-30 18:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/502 [^]
(0128865)
hgbot   
2021-06-01 15:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2a4a8581469d40c3f6dfa8310301572211a966c9
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-06-01T15:28:44+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2a4a8581469d40c3f6dfa8310301572211a966c9 [^]

Fixed ISSUE-46820: Show printName in discount panel

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/AppliedDiscounts.config.json
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/DiscountList.config.json
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanelGrid/AppliedOrderDiscountList.config.json
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanelGrid/OrderDiscountList.config.json
M web-jspack/org.openbravo.pos2/src/core/discount/ManualDiscountCollection/ManualDiscountCollection.js
M web-jspack/org.openbravo.pos2/src/core/discount/ManualDiscountCollection/__test__/__mock__/MockManualDiscount.js
---
(0128866)
hgbot   
2021-06-01 15:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 792a0880634297a346ca3887aea4aaeac2982214
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-06-01T15:28:44+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/792a0880634297a346ca3887aea4aaeac2982214 [^]

Related to ISSUE-46820: Set name attribute instead of identifier in manual discount

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/AppliedDiscounts.config.json
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/DiscountList.config.json
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanelGrid/AppliedOrderDiscountList.config.json
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanelGrid/OrderDiscountList.config.json
M web-jspack/org.openbravo.pos2/src/core/discount/ManualDiscountCollection/ManualDiscountCollection.js
---
(0128867)
hgbot   
2021-06-01 15:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/502 [^]