Openbravo Issue Tracking System - POS2 | |||||
View Issue Details | |||||
ID | Project | Category | View Status | Date Submitted | Last Update |
0046786 | POS2 | POS | public | 2021-05-21 13:19 | 2021-07-29 16:30 |
Reporter | caristu | ||||
Assigned To | hernan-dp | ||||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Platform | OS | 5 | OS Version | ||
Product Version | |||||
Target Version | Fixed in Version | ||||
Merge Request Status | |||||
Review Assigned To | |||||
OBNetwork customer | |||||
Support ticket | |||||
Regression level | |||||
Regression date | |||||
Regression introduced in release | |||||
Regression introduced by commit | |||||
Triggers an Emergency Pack | No | ||||
Summary | 0046786: OB.App.State.Configuration.setCurrentWindow should not be directly called | ||||
Description | We have different places[1],[2] where the OB.App.State.Configuration.setCurrentWindow state action is being directly called. By doing this all the onExit/onEnter hook execution is skipped because they are fired from the user action layer. It would be nice to fix all the places doing this call and replace the correct user action to switch the window. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SelectCurrentSchema.js#L29 [^] [2] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/initialCount/OpenInitialCount.js#L35 [^] | ||||
Steps To Reproduce | . | ||||
Proposed Solution | Use the corresponding user action to navigate to the corresponding window/flow instead of calling OB.App.State.Configuration.setCurrentWindow. See[1] [1] https://docs.google.com/document/d/1tuGxwiNnThguqkrSfUmv9gktmdjdlWmcIkbTPUhVV3g/edit#heading=h.ap1d4lcsowsb [^] | ||||
Additional Information | |||||
Tags | No tags attached. | ||||
Relationships | |||||
Attached Files | |||||
Issue History | |||||
Date Modified | Username | Field | Change | ||
2021-05-21 13:19 | caristu | New Issue | |||
2021-05-21 13:19 | caristu | Assigned To | => Retail | ||
2021-05-21 13:19 | caristu | Resolution time | => 1625176800 | ||
2021-05-21 13:19 | caristu | Triggers an Emergency Pack | => No | ||
2021-05-21 18:22 | guilleaer | Assigned To | Retail => platform | ||
2021-05-21 18:22 | guilleaer | Status | new => acknowledged | ||
2021-07-14 13:26 | dmiguelez | Resolution time | 1625176800 => 1633039200 | ||
2021-07-26 17:48 | hgbot | Note Added: 0130765 | |||
2021-07-26 17:49 | hgbot | Note Added: 0130766 | |||
2021-07-27 12:47 | hgbot | Note Added: 0130791 | |||
2021-07-27 12:48 | hgbot | Note Added: 0130792 | |||
2021-07-27 12:48 | dmiguelez | Status | acknowledged => scheduled | ||
2021-07-27 12:48 | dmiguelez | Assigned To | platform => hernan-dp | ||
2021-07-27 12:48 | dmiguelez | Status | scheduled => resolved | ||
2021-07-27 12:48 | dmiguelez | Resolution | open => fixed | ||
2021-07-27 12:48 | dmiguelez | Status | resolved => closed | ||
2021-07-29 16:28 | hgbot | Note Added: 0130876 | |||
2021-07-29 16:30 | hgbot | Note Added: 0130878 | |||
2021-07-29 16:30 | hgbot | Note Added: 0130879 |