Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046779POS2Corepublic2021-05-21 10:412022-03-31 09:56
Reportershuehner 
Assigned ToTriage Platform Base 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusacknowledgedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046779: Fix warning that core2 dependency deepfreeze is already depended upon by mobile.core
Descriptionnpm install in a workspace including core2 always shows the following warning:


Validating npm dependencies included in Openbravo modules...
Warning: Package deepfreeze defined in modules/org.openbravo.mobile.core/package.json but already defined in modules/org.openbravo.core2/web-jspack/org.openbravo.core2/package.json with same version ^2.0.0

Assuming dependency system works fine that 'deepfreeze' should probably be removed from the core2 package.json

As core2 itself depends indirectly on mobile.core that should not change it being still installed.
Steps To ReproduceIn workspace including org.openbravo.core2 module
run "npm install"
Review output showing above warning
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0046781 new Retail Retail Modules Fix warning about npm dependencies already defined in other modules depended upon. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-05-21 10:41shuehnerNew Issue
2021-05-21 10:41shuehnerAssigned To => Retail
2021-05-21 10:41shuehnerTriggers an Emergency Pack => No
2021-05-21 10:56shuehnerRelationship addedrelated to 0046781
2021-05-21 18:36guilleaerResolution time => 1625436000
2021-05-21 18:36guilleaerAssigned ToRetail => platform
2021-05-21 18:36guilleaerStatusnew => acknowledged
2021-07-14 13:29dmiguelezResolution time1625436000 => 1633039200
2021-07-14 15:28alostaleStatusacknowledged => scheduled
2021-07-14 15:28alostaleAssigned Toplatform => alostale
2021-07-14 15:31hgbotNote Added: 0130475
2021-07-15 09:22hgbotResolutionopen => fixed
2021-07-15 09:22hgbotStatusscheduled => closed
2021-07-15 09:22hgbotNote Added: 0130493
2021-07-15 09:22hgbotNote Added: 0130494
2021-07-16 08:46hgbotNote Added: 0130529
2021-07-16 08:47hgbotNote Added: 0130530
2021-07-16 08:47hgbotNote Added: 0130531
2021-07-16 08:48alostaleAssigned Toalostale => platform
2021-07-16 08:48alostaleStatusclosed => new
2021-07-16 08:48alostaleResolutionfixed => open
2021-08-04 11:36dmiguelezStatusnew => acknowledged
2021-10-11 12:29guilleaerStatusacknowledged => scheduled
2021-10-11 12:29guilleaerStatusscheduled => resolved
2021-10-11 12:29guilleaerResolutionopen => fixed
2021-10-11 12:30guilleaerReview Assigned To => guilleaer
2021-10-11 12:30guilleaerNote Added: 0132297
2021-10-11 12:30guilleaerStatusresolved => closed
2021-10-11 12:32guilleaerStatusclosed => new
2021-10-11 12:32guilleaerResolutionfixed => open
2021-10-11 12:32guilleaerStatusnew => acknowledged
2022-02-01 08:05alostaleAssigned Toplatform => Triage Platform Base
2022-03-31 09:56AugustoMauchNote Added: 0136199

Notes
(0130475)
hgbot   
2021-07-14 15:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/595 [^]
(0130493)
hgbot   
2021-07-15 09:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a3211806d4d9ee34b587881bb0581055f3ac3754
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-07-14T15:29:52+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a3211806d4d9ee34b587881bb0581055f3ac3754 [^]

fixes ISSUE-46779: unneeded deepfreeze dependency

Removes unneeded deepfreeze dependency as it is already declared in
mobile.core which is a dependency for core2.

---
M web-jspack/org.openbravo.core2/package-lock.json
M web-jspack/org.openbravo.core2/package.json
---
(0130494)
hgbot   
2021-07-15 09:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/595 [^]
(0130529)
hgbot   
2021-07-16 08:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/597 [^]
(0130530)
hgbot   
2021-07-16 08:47   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 735e8f6992ac6da25d3456830c310c04a3e74bb6
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-07-16T08:41:27+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/735e8f6992ac6da25d3456830c310c04a3e74bb6 [^]

reverts ISSUE-46779: restores deepfreeze depndency

Even defined as a dependency of mobile.core's dependency, it must be
included in the package.json dependencies if it is going to be directly
used.

This reverts commit a3211806d4d9ee34b587881bb0581055f3ac3754.

---
M web-jspack/org.openbravo.core2/package-lock.json
M web-jspack/org.openbravo.core2/package.json
---
(0130531)
hgbot   
2021-07-16 08:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/597 [^]
(0132297)
guilleaer   
2021-10-11 12:30   
Closed without any change
(0136199)
AugustoMauch   
2022-03-31 09:56   
Removing due date because it is a minor issue