Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046738Retail ModulesCash uppublic2021-05-19 17:102021-05-27 08:33
Reportermalsasua 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q3 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket23944
Regression levelProduction - Confirmed Stable
Regression date2020-02-27
Regression introduced in releaseRR20Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/64bc961eacee4994574570b715435c805843972f [^]
Triggers an Emergency PackNo
Summary0046738: Wrong starting amount in cashup when there is only one payment method
DescriptionWhen there is only one payment method defined in the terminal, the starting amount cashup is retrieved from financial account current balance instead of amount to keep of previous cashup
Steps To Reproduce[BO]
. go to touchpoint - VBS-1 - tab: payment method
- deactivate all payment methods except cash
. go to financial account of payment method cash:
- create a new transaction (for example, amount 5) and process:
financial account current balance: 5

[POS]
. do login
. do cashup:
- amount to keep 0
. do cashup
- starting amount: 5
Proposed Solutionthe problem is in this line:
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/cashup/PaymentMethodUtils.js#L27 [^]
 if lastCashUpPayments.length is 1, then the condition is not satisfied, and the startingCash is not overwritten
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0046854RR21Q2.1 closed rqueralta Wrong starting amount in cashup when there is only one payment method 
depends on backport 0046855RR21Q1.2 closed rqueralta Wrong starting amount in cashup when there is only one payment method 
depends on backport 0046856RR20Q4.4 closed rqueralta Wrong starting amount in cashup when there is only one payment method 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-05-19 17:10malsasuaNew Issue
2021-05-19 17:10malsasuaAssigned To => Retail
2021-05-19 17:10malsasuaOBNetwork customer => Gold
2021-05-19 17:10malsasuaSupport ticket => 23944
2021-05-19 17:10malsasuaResolution time => 1620424800
2021-05-19 17:10malsasuaTriggers an Emergency Pack => No
2021-05-19 17:12malsasuaProposed Solution updated
2021-05-19 17:56marvintmResolution time1620424800 => 1623103200
2021-05-19 19:14martinsdanIssue Monitored: martinsdan
2021-05-19 22:17rqueraltaAssigned ToRetail => rqueralta
2021-05-26 18:16rqueraltaStatusnew => scheduled
2021-05-26 21:49hgbotMerge Request Status => open
2021-05-26 21:49hgbotNote Added: 0128687
2021-05-27 08:25hgbotMerge Request Statusopen => approved
2021-05-27 08:28hgbotNote Added: 0128694
2021-05-27 08:28hgbotResolutionopen => fixed
2021-05-27 08:28hgbotStatusscheduled => closed
2021-05-27 08:28hgbotFixed in Version => RR21Q3
2021-05-27 08:28hgbotNote Added: 0128695
2021-05-27 08:28marvintmStatusclosed => new
2021-05-27 08:28marvintmResolutionfixed => open
2021-05-27 08:29marvintmFixed in VersionRR21Q3 =>
2021-05-27 08:29marvintmStatusnew => scheduled
2021-05-27 08:29marvintmStatusscheduled => resolved
2021-05-27 08:29marvintmFixed in Version => RR21Q3
2021-05-27 08:29marvintmResolutionopen => fixed
2021-05-27 08:29marvintmReview Assigned To => marvintm
2021-05-27 08:29marvintmStatusresolved => closed
2021-05-27 08:33marvintmRegression level => Production - Confirmed Stable
2021-05-27 08:33marvintmRegression date => 2020-02-27
2021-05-27 08:33marvintmRegression introduced in release => RR20Q4
2021-05-27 08:33marvintmRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/64bc961eacee4994574570b715435c805843972f [^]

Notes
(0128687)
hgbot   
2021-05-26 21:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/436 [^]
(0128694)
hgbot   
2021-05-27 08:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/436 [^]
(0128695)
hgbot   
2021-05-27 08:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 060f575f275741686b339fac00a9c9d4a630b4fa
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-05-27T06:25:32+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/060f575f275741686b339fac00a9c9d4a630b4fa [^]

Fixed BUG-46738: Taking into account lastCashUpPayments length equals 1

---
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/PaymentMethodUtils.js
---