0046720: Lots of warnings "lib/so/libsapjco3.so is not a JAR" during several command line tasks (compile, run.test)

Openbravo Issue Tracking System - Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0046720

Modules

SAP Connector

public

2021-05-18 18:58

2021-11-09 09:30

Reporter

shuehner

Assigned To

platform

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Regression date

Regression introduced by commit

Regression level

Review Assigned To

Support ticket

OBNetwork customer

Regression introduced in release

Summary

0046720: Lots of warnings "lib/so/libsapjco3.so is not a JAR" during several command line tasks (compile, run.test)

Description

This module ship a non-standard folder/file in its lib folder.
Specifically

lib/so/libsapjco3.so

Several tasks of the build-system include lib/* into the classpath and they shows lots of warnings like
CLASSPATH element /home/huehner/ob/branches/pi_pristine_pg/modules/org.openbravo.service.integration.sapecc/lib/so/libsapjco3.so is not a JAR.

As jvm and/or ant is unhappy with that file being included.

Afaik that file is not even used from this place but just 'shipped' in the module and requires extra copy/config to be used

Steps To Reproduce

1.) Install/compile the module (and its dependencies)
git clone https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc [^]
git clone https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
git clone https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration [^]

2.) ant run.test -Dtest=org.openbravo.service.integration.sapecc.StandaloneTestSuite

3.a) Notice the huge number of warnings shown just running this one task.

3.b) Also several other tasks show the same warnings:
Example check mod-platform job
- wadvalidation
- minimizeJS
- compile.api (from openapi module)
- check.module.consistency
- run.all.tests
- run.webservice.tests
- (3.a) run.test

Proposed Solution

Either:
a.) Move it out of the lib/ folder (with its special meaning (to put into classpath)
b.)Ship the .so file inside a jar library

That b.) option might need a bit of research. Example other 3rd party jar library which seems to do that are libusb* inside org.openbravo.retail.poshwmanager.
That repo has several 'versions' of such jar files and each inside seems to ship the hw-specific so library.

So apart of fixing the problem described in this issue that could also improve usability (assuming the files are auto-picked up) instead of pointed to via some -D option as done so far.

Additional Information