Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046675POS2Restaurantspublic2021-05-14 09:212021-08-03 09:58
Reporterlorenzofidalgo 
Assigned Toagonzalez 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046675: [21Q2] [Restaurants] Popup where text notes are added has no margins
DescriptionMargins should be added to the field where the text notes are added (check attached image)
Steps To Reproduce0-Login POS2 as vallblanca.
1-In Restaurant schema, click Menu and then Simple Menu.
2-Complete the aforementioned Simple Menu with any products.
3-Once the Simple Menu is completed and added to the receipt, click on the menu in the receipt and click in Starter: Onion Soup. A popup with "ADD/EDIT NOTE" button will be shown. Click on that button.
4-Write any text in that field and realise margins must be added.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0047181 closed Retail [Restaurant] [Allergens Management] There is no left margin for the Allergens product card 
Attached Filespng NoMargins.png (101,958) 2021-05-14 09:21
https://issues.openbravo.com/file_download.php?file_id=15739&type=bug
png

png NoMargins2.png (256,198) 2021-08-02 08:57
https://issues.openbravo.com/file_download.php?file_id=16054&type=bug
png

png m1.png (41,324) 2021-08-02 16:22
https://issues.openbravo.com/file_download.php?file_id=16065&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-05-14 09:21lorenzofidalgoNew Issue
2021-05-14 09:21lorenzofidalgoAssigned To => Retail
2021-05-14 09:21lorenzofidalgoFile Added: NoMargins.png
2021-05-14 09:21lorenzofidalgoOBNetwork customer => No
2021-05-14 09:21lorenzofidalgoResolution time => 1625781600
2021-05-14 09:21lorenzofidalgoTriggers an Emergency Pack => No
2021-05-14 11:31guilleaerStatusnew => acknowledged
2021-06-18 09:14lorenzofidalgoRelationship addedrelated to 0047181
2021-07-14 15:45dmiguelezResolution time1625781600 => 1633039200
2021-07-19 18:52hgbotMerge Request Status => open
2021-07-19 18:52hgbotNote Added: 0130588
2021-07-22 09:42hgbotMerge Request Statusopen => approved
2021-07-22 09:42hgbotNote Added: 0130691
2021-07-22 09:42dmiguelezStatusacknowledged => scheduled
2021-07-22 09:42dmiguelezAssigned ToRetail => agonzalez
2021-07-22 09:42dmiguelezStatusscheduled => resolved
2021-07-22 09:42dmiguelezResolutionopen => fixed
2021-07-22 09:42dmiguelezStatusresolved => closed
2021-08-02 08:56lorenzofidalgoNote Added: 0130920
2021-08-02 08:56lorenzofidalgoStatusclosed => new
2021-08-02 08:56lorenzofidalgoResolutionfixed => open
2021-08-02 08:57lorenzofidalgoFile Added: NoMargins2.png
2021-08-02 09:14dmiguelezStatusnew => scheduled
2021-08-02 09:14dmiguelezStatusscheduled => resolved
2021-08-02 09:14dmiguelezResolutionopen => fixed
2021-08-02 09:14dmiguelezNote Added: 0130921
2021-08-02 09:14dmiguelezStatusresolved => closed
2021-08-02 16:20lorenzofidalgoNote Added: 0130934
2021-08-02 16:20lorenzofidalgoStatusclosed => new
2021-08-02 16:20lorenzofidalgoResolutionfixed => open
2021-08-02 16:22lorenzofidalgoFile Added: m1.png
2021-08-03 09:57dmiguelezNote Added: 0130944
2021-08-03 09:58dmiguelezStatusnew => acknowledged
2021-08-03 09:58dmiguelezStatusacknowledged => scheduled
2021-08-03 09:58dmiguelezNote Added: 0130945
2021-08-03 09:58dmiguelezStatusscheduled => resolved
2021-08-03 09:58dmiguelezResolutionopen => fixed
2021-08-03 09:58dmiguelezStatusresolved => closed

Notes
(0130588)
hgbot   
2021-07-19 18:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/55 [^]
(0130691)
hgbot   
2021-07-22 09:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/55 [^]
(0130920)
lorenzofidalgo   
2021-08-02 08:56   
Issue is not fixed. I have reproduced it in the following context:
https://livebuilds.openbravo.com/retail_pos2_modules_pgsql/web/pos/?terminal=VBS-2 [^]

I will upload a screenshot with the current layout.
(0130921)
dmiguelez   
2021-08-02 09:14   
It is no longer reproducible
(0130934)
lorenzofidalgo   
2021-08-02 16:20   
The issue is still reproducible (tested in Windows and Linux with Chrome 91, 92 and 94) using https://livebuilds.openbravo.com/retail_pos2_modules_pgsql/web/pos/?terminal=VBS-2 [^] context. The cache had been cleared before testing to be sure.
Video to show the wrong behaviour: https://drive.google.com/file/d/1H2VEeRJ4gy55SV9jNRc0VnjOhyg0dCuE/view?usp=sharing [^]

Two issues can be observed there:
1-This original reported issue. Once something is written in the field, the user can see there is no left margin.
2-When the text field where the note is written has the focus, the left line that delimits that field disappears. This can be induced because that left line is overflowing the component where the text field is contained.
(0130944)
dmiguelez   
2021-08-03 09:57   
This issue was partially fixed in the first commit.
It fixed the problem for the Menu Product line, but not for the lines of each of the items, this is why the issue has been reopened.
(0130945)
dmiguelez   
2021-08-03 09:58   
Problem with the line items solved by MR:
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/59 [^]