0046663: Cash Process does not create the G/L item for cash up transaction

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0046663

POS2

POS

public

2021-05-12 16:36

2021-05-31 11:47

Reporter

psanjuan

Assigned To

gorka_gil

Priority

urgent

Severity

critical

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Openbravo Appliance 14.04

Product Version

Target Version

TAP

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0046663: Cash Process does not create the G/L item for cash up transaction

Description

Cash Process does not create the G/L item for cash up transaction

Steps To Reproduce

Run a cash process to close all pending receipts.

Create a POS receipt for an amount of 18€. Pay it in cash.

Go to backoffice and verify that the corresponding sales order has been created with Invoice Status = 0%

Navigate to the financial account (POS2SD Cashbook - Vall Blanca Store - VBS2) and verify there is a transaction created in there with below details:

BP Deposit
Transaction date = 12/05/2021
Deposit Amount = 18

Run cash up process and match the amounts. Do not keep any cash amount.

Navigate once more to the financial account (cash book financial account of the terminal) and verify that no Withdrawal transaction has been created in there to move that cash up balance to the corresponding back office Financial Account of the store (Cashbook - Vall Blanca Backoffice).

Navigate to the reconciliation tab, and filter by the current date, then go to Cleared Items sub-tab. Verify that the reconciliation only includes one line

Navigate to the corresponding backoffice financial account (Cashbook - Vall Blanca Backoffice) and verify that no deposit transaction related to the same GL item has been created in there with cash up amount.

See screens attached for both livebuilds and new POS results.

Proposed Solution

A matching transaction needs to be created in the cash book account to withdraw cash up amount, to deposit that amount in the backoffice account of the store.

The problem seems to be that although the "expected" property is correctly set, the "foreignExpected" property is not, and finally it is this "foreignExpected" property the one that is used in the CashCloseProcessor.java (line 128) to calculate the reconciliationTotal. If this amount is set to 0, then no transaction to move the money out of the till is generated.

The solution therefore is to set this "foreignExpected" property inside the "cashCloseInfo" object inside the Cashup data to the proper value. Once this is done it seems the transaction will be generated correctly.

Additional Information