Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046657POS2POSpublic2021-05-13 12:462021-05-18 07:31
Reportercberner 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelCoding ( Testing )
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046657: Keypad missing button icons for "-" "," "+" and clear
DescriptionKeypad is missing the icons present in the buttons for minus, plus, and clear. Those icons previously appeared on the top corresponding part in the keypads that include a field within.

For more context, check the attached screenshot. This is they keypad that appears when clicking on qty on a ticket line. Ignore the bottom left error in the screenshot.
Steps To Reproduce1. Open WebPOS and login
2. Add a product to the ticket
3. Click on the ticket line added and click on Qty

A popover appears with a keypad, but there are missing button icons to the left and right of Qty field, clicking them will execute the actions.
Proposed Solution
Additional Information
Tagsscss
Relationships
blocks defect 0046548 closed migueldejuana Quantity in menu ticket line popover does not appear 
Attached Filespng localhost_3000__terminal=VBS-2(pos2) (42).png (112,916) 2021-05-13 12:46
https://issues.openbravo.com/file_download.php?file_id=15728&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-05-13 12:46cbernerNew Issue
2021-05-13 12:46cbernerAssigned To => Retail
2021-05-13 12:46cbernerFile Added: localhost_3000__terminal=VBS-2(pos2) (42).png
2021-05-13 12:46cbernerOBNetwork customer => No
2021-05-13 12:46cbernerResolution time => 1623276000
2021-05-13 12:46cbernerTriggers an Emergency Pack => No
2021-05-13 12:58cbernerTag Attached: scss
2021-05-13 19:24guilleaerResolution time1623276000 => 1621116000
2021-05-13 19:24guilleaerRegression level => Coding ( Testing )
2021-05-13 19:24guilleaerStatusnew => acknowledged
2021-05-17 11:45migueldejuanaAssigned ToRetail => migueldejuana
2021-05-17 11:45migueldejuanaStatusacknowledged => scheduled
2021-05-17 11:52migueldejuanaRelationship addedblocks 0046548
2021-05-17 12:03hgbotMerge Request Status => open
2021-05-17 12:03hgbotNote Added: 0128209
2021-05-17 12:17hgbotNote Added: 0128210
2021-05-17 18:18hgbotMerge Request Statusopen => approved
2021-05-18 07:31hgbotResolutionopen => fixed
2021-05-18 07:31hgbotStatusscheduled => closed
2021-05-18 07:31hgbotNote Added: 0128284
2021-05-18 07:31hgbotNote Added: 0128285
2021-05-18 07:31hgbotNote Added: 0128286
2021-05-18 07:31hgbotNote Added: 0128287
2021-05-18 07:31hgbotNote Added: 0128288
2021-05-18 07:31hgbotNote Added: 0128289
2021-05-18 07:31hgbotNote Added: 0128290

Notes
(0128209)
hgbot   
2021-05-17 12:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/461 [^]
(0128210)
hgbot   
2021-05-17 12:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/35 [^]
(0128284)
hgbot   
2021-05-18 07:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: fa019742b42072473ddc87d0dd9dc813e5091ecc
Author: Miguel de Juana <miguel.dejuana@openbravo.com>
Date: 2021-05-18T07:29:24+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/fa019742b42072473ddc87d0dd9dc813e5091ecc [^]

Fixed ISSUE-46657: Keypad missing button icons for "-" "," "+" and clear

- Show Qty also in Menu Ticket Line Popover
- Use a proper style fo "-" and "+" button in Ticket Line Popover

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.scss
---
(0128285)
hgbot   
2021-05-18 07:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4d757c638d4c2a7262f589425a7bc5379f0c6049
Author: Miguel de Juana <miguel.dejuana@openbravo.com>
Date: 2021-05-18T07:29:24+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4d757c638d4c2a7262f589425a7bc5379f0c6049 [^]

Fixed ISSUE-46657: Keypad missing button icons for "-" "," "+" and clear

- Define a unique selector for qty component. No need to have two
different.

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.scss
---
(0128286)
hgbot   
2021-05-18 07:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: fa63dd430b083966065e4eb2aa22f5d129cf8c5e
Author: Miguel de Juana <miguel.dejuana@openbravo.com>
Date: 2021-05-18T07:30:31+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/fa63dd430b083966065e4eb2aa22f5d129cf8c5e [^]

Fixed ISSUE-46657: Keypad missing button icons for "-" "," "+" and clear

- Update copyright year

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.scss
---
(0128287)
hgbot   
2021-05-18 07:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/461 [^]
(0128288)
hgbot   
2021-05-18 07:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: ebf9591386542a9a865ed321a1e3162699be3b4e
Author: Miguel de Juana <miguel.dejuana@openbravo.com>
Date: 2021-05-18T05:25:13+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/ebf9591386542a9a865ed321a1e3162699be3b4e [^]

Fixed ISSUE-46657: Keypad missing button icons for "-" "," "+" and clear

- Use the correct class
- Add missing icon to Note button (not directly related with the issue
but wrong in the popover)

---
M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLineHeaderPopover/TicketMenuLineHeaderPopover.config.json
---
(0128289)
hgbot   
2021-05-18 07:31   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: 4b5246b70e5c5f95a4d866a3c9ad6f88445a655b
Author: Miguel de Juana <miguel.dejuana@openbravo.com>
Date: 2021-05-18T05:25:13+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/4b5246b70e5c5f95a4d866a3c9ad6f88445a655b [^]

iFixed ISSUE-46657: Keypad missing button icons for "-" "," "+" and clear

- Set the style for the button to change between positive and negative
in Qty keypad

---
A web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLineHeaderPopover/TicketMenuLineHeaderPopover.scss
M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLineHeaderPopover/TicketMenuLineHeaderPopover.jsx
---
(0128290)
hgbot   
2021-05-18 07:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/35 [^]