Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046645POS2POSpublic2021-05-12 15:342021-05-19 14:06
Reporterjorge-garcia 
Assigned TojavierRodriguez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046645: Allow multiple instances per line flag for manual promotionsis not working properly
DescriptionAllow multiple instances per line allows to define the same manual promotion (m_offer_id) to be applied to the same line.

If the flag is unchecked, in old POS if a manual promotion is added to a line but this promotion was already in the line, the new added promotion overrides the previous applied promotion

If the flag is checked,every time this manual promotion is added, it will generate a new instance of the promotion (discountinstance property from promotion object)
Steps To Reproduce1) Configure Allow multiple instances per line allows flag in any way
2) The behavior is always the same
Proposed SolutionFor new POS, this is the expected behavior with "Allow multiple instances per line" flag:
  - Manual Promotion with flag CHECKED
      The promotion is added always to the ticket and the promotion object should generate a discountinstance value using an UUID
  - Manual Promotion with flag UNCHECKED
    - Ticket has not applied the promotion -> Add the promotion
    - Ticket has applied the promotion before -> A error message is shown indicating it cannot be added again

To know if a promotion is the same, we should always check the id and the discountinstance of the promotion
      
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0046646TAP closed javierRodriguez Allow multiple instances per line flag for manual promotionsis not working properly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-05-12 15:34jorge-garciaNew Issue
2021-05-12 15:34jorge-garciaAssigned To => Retail
2021-05-12 15:34jorge-garciaTriggers an Emergency Pack => No
2021-05-12 15:36jorge-garciaResolution time => 1622584800
2021-05-12 15:39guilleaerStatusnew => scheduled
2021-05-12 15:39guilleaerStatusscheduled => acknowledged
2021-05-18 20:17hgbotNote Added: 0128351
2021-05-19 10:13javierRodriguezAssigned ToRetail => javierRodriguez
2021-05-19 10:13javierRodriguezStatusacknowledged => scheduled
2021-05-19 14:06hgbotResolutionopen => fixed
2021-05-19 14:06hgbotStatusscheduled => closed
2021-05-19 14:06hgbotNote Added: 0128405
2021-05-19 14:06hgbotNote Added: 0128406

Notes
(0128351)
hgbot   
2021-05-18 20:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/469 [^]
(0128405)
hgbot   
2021-05-19 14:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f294814d5f964995e4f86649695f72d471ddbed6
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-19T14:05:17+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f294814d5f964995e4f86649695f72d471ddbed6 [^]

Fixed ISSUE-46645: Validate before include a new manual discount if it is allowed to include multiple instances of the same discount

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetManualDiscountToApplyActionPreparation.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/discounts/SetManualDiscountToApplyActionPreparation.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/DiscountPanelGrid.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/discounts/SelectManualDiscountsToApply.js
---
(0128406)
hgbot   
2021-05-19 14:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/469 [^]