Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046597POS2POSpublic2021-05-10 09:552021-06-02 17:28
Reporterjavietxe 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046597: JIRA 1777: Missing data-test-id field in send-email popup
DescriptionFor automatic testing purposes, the data-test-id property has to be fulfilled when creating a new component.

The new Send by mail popup, it doesn't have this properties fulfilled (see attached file) so the test cannot be automatized.
Steps To ReproduceConfigure the send by mail popup to appear (in agapes.test it is already working).

Log in in the new pos.

Do an order, let the send by mail apppear.

Open chrome developers tools and see that the data-test-id is not fulfilled.
Proposed Solution
Additional Information
TagsTakeaway
Relationships
depends on backport 0046933TAP closed AtulOpenbravo JIRA 1777: Missing data-test-id field in send-email popup 
Attached Filespng missing_testID.png (234,702) 2021-05-10 09:55
https://issues.openbravo.com/file_download.php?file_id=15680&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-05-10 09:55javietxeNew Issue
2021-05-10 09:55javietxeAssigned To => Retail
2021-05-10 09:55javietxeFile Added: missing_testID.png
2021-05-10 09:55javietxeOBNetwork customer => Gold
2021-05-10 09:55javietxeTriggers an Emergency Pack => No
2021-05-10 09:57javietxeResolution time => 1622412000
2021-05-10 09:57javietxeTag Attached: Takeaway
2021-05-10 09:59javietxeResolution time1622412000 => 1621807200
2021-05-10 11:49guilleaerResolution time1621807200 => 1623276000
2021-05-10 11:49guilleaerSeveritymajor => minor
2021-05-10 11:49guilleaerStatusnew => acknowledged
2021-05-27 09:33guilleaerStatusacknowledged => scheduled
2021-05-27 09:33guilleaerAssigned ToRetail => dmiguelez
2021-05-31 13:11AtulOpenbravoAssigned Todmiguelez => AtulOpenbravo
2021-06-01 16:12dmiguelezStatusscheduled => acknowledged
2021-06-01 16:12dmiguelezStatusacknowledged => scheduled
2021-06-01 17:29hgbotMerge Request Status => open
2021-06-01 17:29hgbotNote Added: 0128881
2021-06-02 17:05hgbotMerge Request Statusopen => approved
2021-06-02 17:28hgbotResolutionopen => fixed
2021-06-02 17:28hgbotStatusscheduled => closed
2021-06-02 17:28hgbotNote Added: 0128967
2021-06-02 17:28hgbotNote Added: 0128968
2021-06-02 17:28hgbotNote Added: 0128969

Notes
(0128881)
hgbot   
2021-06-01 17:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/509 [^]
(0128967)
hgbot   
2021-06-02 17:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f476c6c06448b51878a9e4ab40681fe06efd3682
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 2021-06-02T15:28:24+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f476c6c06448b51878a9e4ab40681fe06efd3682 [^]

Fixes BUG-0046597: JIRA 1777: Missing data-test-id field in
send-email popup

**Add testId in state using setState, this testId is used to be
set it in combination with button label in ReceiptDeliveryOptions
Dialog

---
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/ReceiptDeliveryOptions.jsx
---
(0128968)
hgbot   
2021-06-02 17:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 38ac12d2046090012479c64b1448ca40e27cebe1
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 2021-06-02T15:28:24+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/38ac12d2046090012479c64b1448ca40e27cebe1 [^]

Related To BUG-46597: Add test in order to check proper test id
is set for the buttons with default test id when test id is not
in dialog params

---
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/__test__/ReceiptDeliveryOptions.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/stories/ReceiptDeliveryOptions.stories.jsx
---
(0128969)
hgbot   
2021-06-02 17:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/509 [^]