Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0046568Openbravo ERPA. Platformpublic2021-05-05 16:382021-05-17 10:15
shuehner 
alostale 
normalminorhave not tried
closedfixed 
5
 
PR20Q4.4PR20Q4.4 
Core
No
0046568: junit DataSourceSecurity.fetchShouldBeAllowedOnlyIfRoleIsGranted fails on Tomcat9 (only for Datasource: AccountTreeMovement)
This junit test fails when application is deployed on tomcat 9.x but only for the specific datasource AccountTreeMovement.
It shows 4 failures as four RoleTypes are tested for each dataSource.

Problem is the test triggering the following error on tomcat 9.x:
May 05 12:27:36 ip-172-31-9-130 tomcat9[2709]: Error parsing HTTP request header
May 05 12:27:36 ip-172-31-9-130 tomcat9[2709]: Note: further occurrences of HTTP request parsing errors will be logged at DEBUG level.
May 05 12:27:36 ip-172-31-9-130 tomcat9[2709]: java.lang.IllegalArgumentException: Invalid character found in the request target. The valid characters are defined in RFC 7230 and RFC 3986

Deploy application with tomcat 9.x
ant run.test -Dtest=org.openbravo.test.datasource.DataSourceSecurity

Check result*.xml file in src/ folder for the result of the test run
Fix the invalid request target (values in url) to be valid.

No tags attached.
blocks defect 0046520PR21Q3 closed alostale junit DataSourceSecurity.fetchShouldBeAllowedOnlyIfRoleIsGranted fails on Tomcat9 (only for Datasource: AccountTreeMovement) 
Issue History
2021-05-07 08:11alostaleTypedefect => backport
2021-05-07 08:11alostaleTarget VersionPR21Q3 => PR20Q4.4
2021-05-17 08:07hgbotNote Added: 0128169
2021-05-17 10:15hgbotResolutionopen => fixed
2021-05-17 10:15hgbotStatusscheduled => closed
2021-05-17 10:15hgbotFixed in Version => PR20Q4.4
2021-05-17 10:15hgbotNote Added: 0128202
2021-05-17 10:15hgbotNote Added: 0128203

Notes
(0128169)
hgbot   
2021-05-17 08:07   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/363 [^]
(0128202)
hgbot   
2021-05-17 10:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 181ff893d2bea4bee99b3a5e68c4e7d200d2eacc
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-05-17T08:05:28+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/181ff893d2bea4bee99b3a5e68c4e7d200d2eacc [^]

fixes BUG-46568: DataSourceSecurity fails on Tomcat9

fetchShouldBeAllowedOnlyIfRoleIsGranted test was creating an invalid
request by adding some parameters with special characters and not
ecoding them. Tomcat 9 is stricter parsing URLs than previous version,
not allowing this case.

Fixed by removing those parameters that were causing problems as they
were not ncessary.

---
M src-test/src/org/openbravo/test/datasource/DataSourceSecurity.java
---
(0128203)
hgbot   
2021-05-17 10:15   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/363 [^]