Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046556Retail ModulesGift cards and gift voucherspublic2021-05-06 15:382021-05-12 06:29
Reporterguillermogil 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q3 
Merge Request Statusapproved
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2020-08-04
Regression introduced in releaseRR20Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/b9a457a4d9164fc248b50231345663bfb4b82258#60cdf603705f71dff9230c8fa90bb8c8ab277163_117_121 [^]
Triggers an Emergency PackNo
Summary0046556: OB.UI.GiftCardUtils.updatePaymentMethodCashUp does not exist
DescriptionThere is a problem when creating gift certificates, if the payment method is marked to be counted in the cashup. The error happens because a missing JS function is being called:

OB.UI.GiftCardUtils.updatePaymentMethodCashUp does not exist
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/blob/master/web/org.openbravo.retail.giftcards/js/components/GiftCardCertificate.js#L131 [^]

TypeError: OB.UI.GiftCardUtils.updatePaymentMethodCashUp is not a function

Steps To ReproduceSearch for that function and there is no definition.

It fails when creating a gift certificate, if the payment method is marked to be counted in the cashup.
Proposed SolutionThis part was refactored as part of the IndexedDB changes here:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/4f8b5f7b89f808520bf2d843cd684ecea564ecf5 [^]

However, in the subsequent merge part of the change was reverted, causing the regression:

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/b9a457a4d9164fc248b50231345663bfb4b82258#60cdf603705f71dff9230c8fa90bb8c8ab277163_117_121 [^]
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0046559RR21Q2 closed Retail OB.UI.GiftCardUtils.updatePaymentMethodCashUp does not exist 
depends on backport 0046560RR21Q1.2 closed Retail OB.UI.GiftCardUtils.updatePaymentMethodCashUp does not exist 
depends on backport 0046561RR20Q4.4 closed Retail OB.UI.GiftCardUtils.updatePaymentMethodCashUp does not exist 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-05-06 15:38guillermogilNew Issue
2021-05-06 15:38guillermogilAssigned To => Retail
2021-05-06 15:38guillermogilOBNetwork customer => Gold
2021-05-06 15:38guillermogilResolution time => 1621720800
2021-05-06 15:38guillermogilTriggers an Emergency Pack => No
2021-05-06 15:52marvintmRegression level => Production - Confirmed Stable
2021-05-06 15:52marvintmRegression date => 2020-06-15
2021-05-06 15:52marvintmRegression introduced in release => RR20Q4
2021-05-06 15:52marvintmRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/4f8b5f7b89f808520bf2d843cd684ecea564ecf5 [^]
2021-05-06 15:52marvintmStatusnew => scheduled
2021-05-06 16:00marvintmDescription Updatedbug_revision_view_page.php?rev_id=22464#r22464
2021-05-06 16:00marvintmSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22466#r22466
2021-05-06 16:00marvintmProposed Solution updated
2021-05-06 16:09marvintmRegression date2020-06-15 => 2020-08-04
2021-05-06 16:09marvintmRegression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/4f8b5f7b89f808520bf2d843cd684ecea564ecf5 [^] => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/b9a457a4d9164fc248b50231345663bfb4b82258#60cdf603705f71dff9230c8fa90bb8c8ab277163_117_121 [^]
2021-05-06 16:09marvintmProposed Solution updated
2021-05-06 16:37rqueraltaAssigned ToRetail => rqueralta
2021-05-07 06:43hgbotMerge Request Status => open
2021-05-07 06:43hgbotNote Added: 0127871
2021-05-07 15:23hgbotNote Added: 0127904
2021-05-10 15:59hgbotNote Added: 0127956
2021-05-12 06:28hgbotMerge Request Statusopen => approved
2021-05-12 06:29hgbotNote Added: 0128016
2021-05-12 06:29hgbotNote Added: 0128017
2021-05-12 06:29marvintmStatusscheduled => resolved
2021-05-12 06:29marvintmFixed in Version => RR21Q3
2021-05-12 06:29marvintmResolutionopen => fixed
2021-05-12 06:29marvintmReview Assigned To => marvintm
2021-05-12 06:29marvintmStatusresolved => closed

Notes
(0127871)
hgbot   
2021-05-07 06:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/56 [^]
(0127904)
hgbot   
2021-05-07 15:23   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/56 [^]
(0127956)
hgbot   
2021-05-10 15:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/57 [^]
(0128016)
hgbot   
2021-05-12 06:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 79713b504d5833fa8872802914e053c5e5486c6b
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-05-12T04:29:01+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/79713b504d5833fa8872802914e053c5e5486c6b [^]

Fix BUG-46556: Restored deleted changes to a previous mix

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardCertificate.js
---
(0128017)
hgbot   
2021-05-12 06:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/57 [^]