Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046550Openbravo ERPA. Platformpublic2021-05-05 16:542021-05-19 09:23
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionPR21Q1.3Fixed in VersionPR21Q1.2 
Merge Request Statusmerged
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046550: ant compile.test does not work incrementally because of wrong src definition
DescriptionThat ant target is used as dependency in any run of junit tests via ant.

It has a wrong src definition where the file-location in which the sources are found does not match the java-package.

That is similar to what we fixed in 20416 for the main compilation.

Effect of this bug is re-compiling 580 sources on every run of this target.
Example runtime:
- current ca. 41 seconds
- fixed: ca. 24 seconds

Apart from local waiting that is also run several times in many ci jobs:
- At least twice for stand-alone + webservice tests
- in jobs with custom junit tests even more times (+1 per each module)
  i.e. mod-platform runs that compile step 6 times and other mod-* jobs even more times

Steps To Reproducerun ant compile.test
run ant compile.test a second time

Notice that the 2nd compilation does compile many sources files when it should compile 0 (as there are no source changes).
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0046521PR21Q3 closed shuehner ant compile.test does not work incrementally because of wrong src definition 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-05-06 14:39shuehnerTypedefect => backport
2021-05-06 14:39shuehnerTarget VersionPR21Q3 => PR21Q1.2
2021-05-19 07:31alostaleTarget VersionPR21Q1.2 => PR21Q1.3
2021-05-19 09:17hgbotMerge Request Status => open
2021-05-19 09:17hgbotNote Added: 0128376
2021-05-19 09:23alostaleAssigned Toplatform => shuehner
2021-05-19 09:23hgbotResolutionopen => fixed
2021-05-19 09:23hgbotStatusscheduled => resolved
2021-05-19 09:23hgbotMerge Request Statusopen => merged
2021-05-19 09:23hgbotNote Added: 0128382
2021-05-19 09:23hgbotFixed in Version => PR21Q1.2
2021-05-19 09:23hgbotNote Added: 0128383
2021-05-19 09:23alostaleReview Assigned To => alostale
2021-05-19 09:23alostaleStatusresolved => closed

Notes
(0128376)
hgbot   
2021-05-19 09:17   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/373 [^]
(0128382)
hgbot   
2021-05-19 09:23   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/373 [^]
(0128383)
hgbot   
2021-05-19 09:23   
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 70755bf0559f834ed9f5ba36726a0663e5f36353
Author: Stefan Hühner <stefan.huehner@openbravo.com>
Date: 2021-05-19T09:15:49+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/70755bf0559f834ed9f5ba36726a0663e5f36353 [^]

fixed BUG-46550: ant compile.test does not work incrementally

Whenever compile.test task was executed all test classes were compiled
instead of doing an incremental compilation of the only the ones whose
source files changed since last compilation.

This was caused by an incorrect path definition of tests in core module,
sources are within src-test/src directory but pathelement was declared
as src-test only, this makes ant not to be able to detect changes and to
always compile all the files. See [1].

[1] https://ant.apache.org/faq.html#always-recompiles [^]

---
M src-test/build.xml
---