Openbravo Issue Tracking System - POS2
View Issue Details
0046546POS2POSpublic2021-05-06 14:082022-03-31 09:55
cberner 
Triage Platform Base 
normalminorhave not tried
acknowledgedopen 
5
 
 
No
0046546: SelectCurrentSchema user action does more than it should
SelectCurrentSchema user action does several things:
- Change schema to the provided schema
- Change current window to main window
- Change current flow to add product flow
- Change multilineSelection to default(not open)

This is incorrect and should be changed. The user action should only change the schema and maybe the multilineselection, but both current window and current flow should be changed in using the corresponding user action for these.
In description.
Two options:
1. Change all places that call SelectCurrentSchema to also call afterwards switch current window and switch flow user action. This will allow removing those calls from inside SelectCurrentSchema, which should not be responsible to know of any window/flow.
2. Change SelectCurrentSchema to call the correct user action for SelectCurrentWindow/SelectCurrentFlow and document that this user action does that too, not only changing the schema.
No tags attached.
Issue History
2021-05-06 14:08cbernerNew Issue
2021-05-06 14:08cbernerAssigned To => cberner
2021-05-06 14:08cbernerTriggers an Emergency Pack => No
2021-05-07 11:42cbernerPrioritynormal => high
2021-05-07 12:37guilleaerResolution time => 1625522400
2021-05-07 12:37guilleaerStatusnew => acknowledged
2021-07-14 15:38dmiguelezResolution time1625522400 => 1633039200
2021-07-14 15:38dmiguelezAssigned Tocberner => platform
2021-11-05 00:26guilleaerPriorityhigh => normal
2021-11-05 08:19caristuNote Added: 0132865
2022-02-01 08:05alostaleAssigned Toplatform => Triage Platform Base
2022-03-31 09:55AugustoMauchNote Added: 0136194

Notes
(0132865)
caristu   
2021-11-05 08:19   
Also note that the SelectCurrentSchema user action is breaking one basic rule: it is defined as a UIAction which means that only actions of the UI model must be invoked, but it is currently calling to an action of the Global model (OB.App.State.Global.setCurrentSchema)
(0136194)
AugustoMauch   
2022-03-31 09:55   
Removing due date because it is a minor issue