Openbravo Issue Tracking System - POS2
View Issue Details
0046538POS2Corepublic2021-05-06 09:092021-09-24 12:16
migueldejuana 
Retail 
normaltrivialalways
acknowledgedopen 
5
 
 
No
0046538: Apply button in discount should be disabled by default
- In Discounts window, Apply button should be disabled till we have applied changes.
n/a
No tags attached.
Issue History
2021-05-06 09:09migueldejuanaNew Issue
2021-05-06 09:09migueldejuanaAssigned To => Retail
2021-05-06 09:09migueldejuanaTriggers an Emergency Pack => No
2021-05-07 12:28guilleaerResolution time => 1625436000
2021-05-07 12:29guilleaerStatusnew => acknowledged
2021-07-14 13:30dmiguelezResolution time1625436000 => 1633039200
2021-07-19 21:06hernan-dpAssigned ToRetail => hernan-dp
2021-07-19 21:07hernan-dpStatusacknowledged => scheduled
2021-07-19 21:13hgbotNote Added: 0130590
2021-07-23 12:44hgbotResolutionopen => fixed
2021-07-23 12:44hgbotStatusscheduled => closed
2021-07-23 12:44hgbotNote Added: 0130726
2021-07-23 12:44hgbotNote Added: 0130727
2021-07-23 12:45dmiguelezNote Added: 0130728
2021-07-28 15:54hgbotNote Added: 0130842
2021-07-28 15:54hgbotNote Added: 0130843
2021-07-28 15:55hgbotNote Added: 0130844
2021-07-28 15:59hgbotNote Added: 0130845
2021-07-28 16:06hgbotNote Added: 0130846
2021-07-28 16:06hgbotNote Added: 0130847
2021-07-28 16:07hgbotNote Added: 0130848
2021-07-28 16:10dmiguelezNote Added: 0130849
2021-07-28 16:10dmiguelezStatusclosed => new
2021-07-28 16:10dmiguelezResolutionfixed => open
2021-07-28 16:10dmiguelezStatusnew => acknowledged
2021-08-30 12:45dmiguelezAssigned Tohernan-dp => Retail
2021-09-15 12:23guilleaerAssigned ToRetail => prakashmurugesan88
2021-09-15 12:24guilleaerAssigned Toprakashmurugesan88 => migueldejuana
2021-09-16 14:18guilleaerAssigned Tomigueldejuana => Retail
2021-09-24 09:04prakashmurugesan88Assigned ToRetail => prakashmurugesan88
2021-09-24 09:04prakashmurugesan88Statusacknowledged => scheduled
2021-09-24 12:16prakashmurugesan88Assigned Toprakashmurugesan88 => Retail
2021-09-24 12:16prakashmurugesan88Statusscheduled => acknowledged

Notes
(0130590)
hgbot   
2021-07-19 21:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/614 [^]
(0130726)
hgbot   
2021-07-23 12:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: cdeed6abf816fbc126bf132e03a26bc96ec31f37
Author: hernan-dp <h.de.prada1@gmail.com>
Date: 2021-07-23T10:43:59+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cdeed6abf816fbc126bf132e03a26bc96ec31f37 [^]

fixes ISSUE-46538: Apply button in discount disabled when no changes applied.

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanel/DiscountPanel.config.json
---
(0130727)
hgbot   
2021-07-23 12:44   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/614 [^]
(0130728)
dmiguelez   
2021-07-23 12:45   
Related commit:
https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/03ae615a813710084f6e1ba2b08cb0bab81de985 [^]
(0130842)
hgbot   
2021-07-28 15:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/613 [^]
(0130843)
hgbot   
2021-07-28 15:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/613 [^]
(0130844)
hgbot   
2021-07-28 15:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/644 [^]
(0130845)
hgbot   
2021-07-28 15:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/614 [^]
(0130846)
hgbot   
2021-07-28 16:06   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/614 [^]
(0130847)
hgbot   
2021-07-28 16:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/644 [^]
(0130848)
hgbot   
2021-07-28 16:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 82ae4a92fa557d8426fe6fabc0f0fb90061e5720
Author: hernan-dp <h.de.prada1@gmail.com>
Date: 2021-07-28T10:54:26-03:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/82ae4a92fa557d8426fe6fabc0f0fb90061e5720 [^]

Revert "fixes ISSUE-46538: Apply button in discount disabled when no changes applied."

This reverts commit cdeed6abf816fbc126bf132e03a26bc96ec31f37.

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanel/DiscountPanel.config.json
---
(0130849)
dmiguelez   
2021-07-28 16:10   
Fix has been reverted.

The reason is that, even if the fix is correct, it is possible to implement a better solution that does not required to use the state to communicate both react components