0046531: Cancel and replace fails when used from ExternalOrderLoader

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0046531

Retail Modules

Web POS

public

2021-05-06 08:38

2021-05-11 08:23

Reporter

marvintm

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR21Q2

Fixed in Version

RR21Q2

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0046531: Cancel and replace fails when used from ExternalOrderLoader

Description

ExternalOrderLoader can be used to Cancel&Replace an order after it was implemented in the following issue:

https://issues.openbravo.com/view.php?id=45423 [^]

However, it currently fails if used because of an "OutDatedDataChangeException" error. This error happens because in C&R the canceledorder needs to be specified, but then the concurrency modification check is performed. This problem is avoided in the Cancel order flow because there the check is disabled. The same thing should be done for the C&R flow

Steps To Reproduce

Download the postman from the Retail API repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.api/-/blob/master/examples/Retail%20API.postman_collection.json [^]

Execute the "Import Order - Order with consistent id (to C&R later)" request (in Order folder). An order will be created in the backend.
Execute the "Import Order - Order cancel and replace" request (in Order folder). Verify that it fails with OutDatedDataChangeException exception.

Proposed Solution

The disableConcurrencyCheck method should also be called in the C&R flow.

Additional Information