Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046506POS2POSpublic2021-05-05 10:552021-05-19 10:33
Reporterjcbourgeois 
Assigned Toaferraz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046506: JIRA 1825 - Cash up / Counting tool : possibility to enter a wrong number
DescriptionAt cashup, when using "split coin / bills" feature, it's possible to enter a value which is not coherent regarding the coin and notes configured for the currency.
Steps To Reproduce1) In livebuilds, configure Coins and bank notes for the currency = EUR (check screenshot)
2) In POS2, go to cash up
3) Select cash payment method
4) Click on "split coin / bills"
5) In cash (Bills), type 0.01 : the value is accepted but it's not relevant as this value corresponds to a coin (and not to the minimum value of a note = 5€)
=> An error message should be raised in this case
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
duplicate of defect 0047183 closed Retail JIRA 2113 - Safe Count - Amount should be a multiple of 0.01 
depends on backport 0046526TAP closed aferraz JIRA 1825 - Cash up / Counting tool : possibility to enter a wrong number 
related to defect 0046728 closed AugustoMauch When checking the if the amount to pay with bills is correct, the minimum bill value is not being properly fetched 
Attached Filespng 2021-05-05 10_47_20-Openbravo - Currency - EUR.png (69,828) 2021-05-05 10:55
https://issues.openbravo.com/file_download.php?file_id=15639&type=bug
png

png 2021-05-05 10_45_58-Openbravo POS2.png (40,376) 2021-05-05 10:55
https://issues.openbravo.com/file_download.php?file_id=15640&type=bug
png

png 2021-05-05 10_45_43-Openbravo POS2.png (48,799) 2021-05-05 10:55
https://issues.openbravo.com/file_download.php?file_id=15641&type=bug
png

png 2021-05-18 18_04_51-.png (76,730) 2021-05-18 18:09
https://issues.openbravo.com/file_download.php?file_id=15764&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-05-05 10:55jcbourgeoisNew Issue
2021-05-05 10:55jcbourgeoisAssigned To => Retail
2021-05-05 10:55jcbourgeoisTriggers an Emergency Pack => No
2021-05-05 10:55jcbourgeoisFile Added: 2021-05-05 10_47_20-Openbravo - Currency - EUR.png
2021-05-05 10:55jcbourgeoisFile Added: 2021-05-05 10_45_58-Openbravo POS2.png
2021-05-05 10:55jcbourgeoisFile Added: 2021-05-05 10_45_43-Openbravo POS2.png
2021-05-05 18:11guilleaerResolution time => 1621375200
2021-05-05 18:11guilleaerStatusnew => scheduled
2021-05-05 18:12guilleaerStatusscheduled => acknowledged
2021-05-11 16:32aferrazStatusacknowledged => scheduled
2021-05-11 16:32aferrazAssigned ToRetail => aferraz
2021-05-12 12:14hgbotNote Added: 0128034
2021-05-17 12:31hgbotResolutionopen => fixed
2021-05-17 12:31hgbotStatusscheduled => resolved
2021-05-17 12:31hgbotNote Added: 0128211
2021-05-17 12:31hgbotNote Added: 0128212
2021-05-17 12:56AugustoMauchStatusresolved => closed
2021-05-17 12:57AugustoMauchReview Assigned To => AugustoMauch
2021-05-18 07:07hgbotNote Added: 0128280
2021-05-18 18:08jcbourgeoisNote Added: 0128349
2021-05-18 18:08jcbourgeoisStatusclosed => new
2021-05-18 18:08jcbourgeoisResolutionfixed => open
2021-05-18 18:09jcbourgeoisFile Added: 2021-05-18 18_04_51-.png
2021-05-19 10:33AugustoMauchNote Added: 0128390
2021-05-19 10:33AugustoMauchStatusnew => scheduled
2021-05-19 10:33AugustoMauchStatusscheduled => resolved
2021-05-19 10:33AugustoMauchResolutionopen => fixed
2021-05-19 10:33AugustoMauchStatusresolved => closed
2021-05-19 10:49AugustoMauchRelationship addedrelated to 0046728
2021-06-18 14:22dmiguelezRelationship addedduplicate of 0047183

Notes
(0128034)
hgbot   
2021-05-12 12:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/450 [^]
(0128211)
hgbot   
2021-05-17 12:31   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3cf14fdd5c41c14c3fc3f78e99b9b6749fc53bc7
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 2021-05-17T12:30:16+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3cf14fdd5c41c14c3fc3f78e99b9b6749fc53bc7 [^]

Fixes ISSUE-46506: Don't allow to enter wrong amount when counting coins or bills

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupProcess/stories/CashupProcess.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSplitInputs/CashupSplitInputs.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSplitInputs/__test__/CashupSplitInputs.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSplitInputs/stories/CashupSplitInputs.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountPaymentMethodsStep/stories/CountPaymentMethodsStep.stories.jsx
---
(0128212)
hgbot   
2021-05-17 12:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/450 [^]
(0128280)
hgbot   
2021-05-18 07:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 26e5f3c304ba38121902ffd6ca2646ecf913e629
Author: Antonio Moreno <anmorenoperez@gmail.com>
Date: 2021-05-18T07:07:16+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/26e5f3c304ba38121902ffd6ca2646ecf913e629 [^]

Related to ISSUE-46506. Fixed missing formatting

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSplitInputs/CashupSplitInputs.jsx
---
(0128349)
jcbourgeois   
2021-05-18 18:08   
Test KO in Livebuilds : if the cashier enters 5 in Cash (notes) row, this value is refused and an error message is raised.
Note of 5€ should be accepted here as it's the minimum value for note (for currency=EUR).
POS should consider the coins and notes configured for the currency (instead of checking if the entered value is a multiple of 10)
(0128390)
AugustoMauch   
2021-05-19 10:33   
Problem is reproducible, will be managed in a separate issue