0046505: action preparation order is modified when the action fails

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0046505

POS2

Core

public

2021-05-05 09:33

2021-05-05 09:42

Reporter

guilleaer

Assigned To

guilleaer

Priority

normal

Severity

critical

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

TAP

Fixed in Version

TAP

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0046505: action preparation order is modified when the action fails

Description

When an action fails, the action preparation rollback mechanism is executed[1].

This mechanism executes all the rollback functions of each action preparation in reverse order.

In order to retrieve the reversed order of rollback functions we are using the reverse function[2]. Note that reverse function mutates the original array[3].

In practice, this means that if an action fails, the next time it is executed the action preparations are executed in reversed order.

[1] http://wiki.openbravo.com/wiki/StateController#Action_Preparations [^] [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/State.js#L60 [^] [^]
[3] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reverse [^] [^]

Steps To Reproduce

1) Put mobile.core in this branch:
2) Execute the State.test.js which contains a reproducer for the situation described in Description
3) Note that the test fails

Proposed Solution

Additional Information