Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046328POS2POSpublic2021-04-22 15:122021-05-18 18:57
Reporterjmelin 
Assigned Topablobessone 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046328: JIRA 1522 - Assigned customer remains after closing the till
DescriptionIf a customer is assigned to an empty order, it remains after closing the till and reconnecting
Steps To Reproduce1. Connect to POS VBS-2
2. Go to "customer" screen and select a customer -> customer is assigned to a new ticket (ticket must be left empty)
3. Close the till
4. Relog to POS and go to "Order" screen => the previous customer is still assigned
Proposed SolutionUnassigned the customer when closing the till
Additional Information
TagsTakeaway
Relationships
depends on backport 0046719TAP closed pablobessone JIRA 1522 - Assigned customer remains after closing the till 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-04-22 15:12jmelinNew Issue
2021-04-22 15:12jmelinAssigned To => Retail
2021-04-22 15:12jmelinOBNetwork customer => Gold
2021-04-22 15:12jmelinTriggers an Emergency Pack => No
2021-04-22 15:12jmelinTag Attached: suresh
2021-04-22 15:12jmelinTag Attached: Takeaway
2021-04-22 15:12jmelinTag Detached: suresh
2021-04-22 17:45guilleaerResolution time => 1619992800
2021-04-23 21:40pablobessoneAssigned ToRetail => pablobessone
2021-04-23 22:09pablobessoneStatusnew => scheduled
2021-05-04 21:42hgbotMerge Request Status => open
2021-05-04 21:42hgbotNote Added: 0127789
2021-05-12 18:22hgbotNote Added: 0128047
2021-05-14 09:40hgbotNote Added: 0128097
2021-05-14 09:43hgbotMerge Request Statusopen => approved
2021-05-14 09:43hgbotResolutionopen => fixed
2021-05-14 09:43hgbotStatusscheduled => closed
2021-05-14 09:43hgbotNote Added: 0128098
2021-05-14 09:43hgbotNote Added: 0128099
2021-05-14 09:43hgbotNote Added: 0128100
2021-05-14 09:43hgbotNote Added: 0128101
2021-05-14 09:43hgbotNote Added: 0128103
2021-05-14 09:43hgbotNote Added: 0128104
2021-05-14 09:43hgbotNote Added: 0128105
2021-05-14 09:43hgbotNote Added: 0128106
2021-05-18 18:57guilleaerStatusclosed => new
2021-05-18 18:57guilleaerResolutionfixed => open
2021-05-18 18:57guilleaerStatusnew => scheduled
2021-05-18 18:57guilleaerStatusscheduled => resolved
2021-05-18 18:57guilleaerResolutionopen => fixed
2021-05-18 18:57guilleaerStatusresolved => closed

Notes
(0127789)
hgbot   
2021-05-04 21:42   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/433 [^]
(0128047)
hgbot   
2021-05-12 18:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/411 [^]
(0128097)
hgbot   
2021-05-14 09:40   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/411 [^]
(0128098)
hgbot   
2021-05-14 09:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6f90f56f400c101febab9faac83fdd23d3314912
Author: pablo.bessone <pablo.bessone@smfconsulting.es>
Date: 2021-05-13T16:36:03-03:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6f90f56f400c101febab9faac83fdd23d3314912 [^]

fixed ISSUE-0046328: wip action implementation to remove external BP when close till is done

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/ClearExternalBusinessPartner.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/FinishCashup.js
---
(0128099)
hgbot   
2021-05-14 09:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 50b419495da970d5a16d967a8aba40a8c1044447
Author: pablo.bessone <pablo.bessone@smfconsulting.es>
Date: 2021-05-13T16:36:03-03:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/50b419495da970d5a16d967a8aba40a8c1044447 [^]

fixed ISSUE-0046328: wip reverting changes to implement another solution

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/FinishCashup.js
---
(0128100)
hgbot   
2021-05-14 09:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 38302df43b4b04c5c785c901ee5afa54878195c5
Author: Pablo Bessone <pablo.bessone@smfconsulting.es>
Date: 2021-05-13T16:36:03-03:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/38302df43b4b04c5c785c901ee5afa54878195c5 [^]

fixed ISSUE-0046328: removed all tickets when close till is done

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/FinishCashupUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/finishCashupUi.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/FinishCashup.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/ClearExternalBusinessPartner.js
---
(0128101)
hgbot   
2021-05-14 09:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 5b1fd26dfb17481ce29690f0aa66d23e5831f41e
Author: Pablo Bessone <pablo.bessone@smfconsulting.es>
Date: 2021-05-13T16:36:03-03:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5b1fd26dfb17481ce29690f0aa66d23e5831f41e [^]

fixed ISSUE-0046328: removed useless if condition

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/FinishCashup.js
---
(0128103)
hgbot   
2021-05-14 09:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 18f633dec7fb4b60205ace54add85484afce46e3
Author: Pablo Bessone <pablo.bessone@smfconsulting.es>
Date: 2021-05-13T16:36:03-03:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/18f633dec7fb4b60205ace54add85484afce46e3 [^]

fixed ISSUE-0046328: wip added posthook, new action call TicketUtil function to delete orders

---
A web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/clearAllTickets.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/ClearAllTickets.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/ClearCurrentTickets.js
M web-jspack/org.openbravo.pos2/src/model/cashup/CashupExtension.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/ClearCurrentTicketsActionPreparation.js
---
(0128104)
hgbot   
2021-05-14 09:43   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/433 [^]
(0128105)
hgbot   
2021-05-14 09:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 811f01fea37aa80510bff90abd65a473d1388bed
Author: Pablo Bessone <pablo.bessone@smfconsulting.es>
Date: 2021-05-13T16:36:03-03:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/811f01fea37aa80510bff90abd65a473d1388bed [^]

fixed ISSUE-0046328: changed a cashup extension from actionprep to posthook, modified finishcashup to prepare payload for the posthook

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/ClearAllTickets.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/ClearCurrentTickets.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/FinishCashup.js
---
(0128106)
hgbot   
2021-05-14 09:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a5c5d64bb2655d2c8054c943137877175f81504a
Author: Pablo Bessone <pablo.bessone@smfconsulting.es>
Date: 2021-05-13T16:36:03-03:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a5c5d64bb2655d2c8054c943137877175f81504a [^]

fixed ISSUE-0046328: simplified method to clear tickets after cashup

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/ClearCurrentTickets.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/clearAllTickets.test.js
R web-jspack/org.openbravo.pos2/src/model/user-interface/actions/cashup/ClearAllTickets.js
---