Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0046324 | POS2 | POS | public | 2021-04-22 14:02 | 2021-05-17 19:15 |
|
| Reporter | jmelin | |
| Assigned To | javierRodriguez | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 30 | OS Version | Openbravo Appliance 14.04 |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | approved |
| Review Assigned To | |
| OBNetwork customer | Gold |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0046324: JIRA 1737 - 'null' value in POS promotion window |
| Description | If the manual promotion don't have a predefined amount or percentage (must be set on the POS) then 'null' value is printed |
| Steps To Reproduce | 1. Create a promotion with a no predefined discount (ex: "User Defined Percentage" and leave "Percentage discount" empty)
2. Connect to POS and refresh master data
3. Create an order and select the promotion you created => display 'null' is the window |
| Proposed Solution | |
| Additional Information | |
| Tags | Takeaway |
| Relationships | | depends on | backport | 0046413 | TAP | closed | javierRodriguez | JIRA 1737 - 'null' value in POS promotion window |
|
| Attached Files |  null_value.PNG (61,836) 2021-04-22 14:02
https://issues.openbravo.com/file_download.php?file_id=15559&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-04-22 14:02 | jmelin | New Issue | |
| 2021-04-22 14:02 | jmelin | Assigned To | => Retail |
| 2021-04-22 14:02 | jmelin | File Added: null_value.PNG | |
| 2021-04-22 14:02 | jmelin | OBNetwork customer | => Gold |
| 2021-04-22 14:02 | jmelin | Triggers an Emergency Pack | => No |
| 2021-04-22 14:02 | jmelin | Tag Attached: Takeaway | |
| 2021-04-22 17:35 | guilleaer | Resolution time | => 1619992800 |
| 2021-04-23 13:30 | javierRodriguez | Assigned To | Retail => javierRodriguez |
| 2021-04-29 10:31 | guilleaer | Status | new => scheduled |
| 2021-05-12 16:52 | hgbot | Merge Request Status | => open |
| 2021-05-12 16:52 | hgbot | Note Added: 0128045 | |
| 2021-05-12 19:13 | hgbot | Note Added: 0128048 | |
| 2021-05-17 08:19 | hgbot | Merge Request Status | open => approved |
| 2021-05-17 19:14 | hgbot | Note Added: 0128268 | |
| 2021-05-17 19:14 | hgbot | Note Added: 0128269 | |
| 2021-05-17 19:15 | hgbot | Resolution | open => fixed |
| 2021-05-17 19:15 | hgbot | Status | scheduled => closed |
| 2021-05-17 19:15 | hgbot | Note Added: 0128270 | |
| 2021-05-17 19:15 | hgbot | Note Added: 0128271 | |
| 2021-05-17 19:15 | hgbot | Note Added: 0128272 | |
| 2021-05-17 19:15 | hgbot | Note Added: 0128273 | |
| 2021-05-17 19:15 | hgbot | Note Added: 0128274 | |
| 2021-05-17 19:15 | hgbot | Note Added: 0128275 | |
|
Notes |
|
|
(0128045)
|
|
hgbot
|
|
2021-05-12 16:52
|
|
|
|
|
(0128048)
|
|
hgbot
|
|
2021-05-12 19:13
|
|
|
|
|
(0128268)
|
|
hgbot
|
|
2021-05-17 19:14
|
|
|
|
|
(0128269)
|
|
hgbot
|
|
2021-05-17 19:14
|
|
|
|
|
(0128270)
|
|
hgbot
|
|
2021-05-17 19:15
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8d19dea6d4988180c2109e03994c9385d1e71984
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-17T15:45:37+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8d19dea6d4988180c2109e03994c9385d1e71984 [^]
Fixed ISSUE-46324: Handle null discount value in manual discounts and order discounts flows
---
A web-jspack/org.openbravo.pos2/src/model/ticket/__test__/DiscountActionPreparation.test.js
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/DiscountActionPreparation.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountAmountCell/DiscountAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountInputAmountCell/DiscountInputAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/OrderDiscountAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/__test__/OrderDiscountAmountCell.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountInputAmountCell/OrderDiscountInputAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountInputAmountCell/__test__/OrderDiscountInputAmountCell.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountInputAmountCell/__test__/__mock__/discountMock.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
---
|
|
|
|
(0128271)
|
|
hgbot
|
|
2021-05-17 19:15
|
|
|
|
|
(0128272)
|
|
hgbot
|
|
2021-05-17 19:15
|
|
|
|
|
(0128273)
|
|
hgbot
|
|
2021-05-17 19:15
|
|
|
|
|
(0128274)
|
|
hgbot
|
|
2021-05-17 19:15
|
|
|
|
|
(0128275)
|
|
hgbot
|
|
2021-05-17 19:15
|
|
|