Openbravo Issue Tracking System - POS2
View Issue Details
0046324POS2POSpublic2021-04-22 14:022021-05-17 19:15
jmelin 
javierRodriguez 
highmajoralways
closedfixed 
30Openbravo Appliance 14.04
 
 
No
0046324: JIRA 1737 - 'null' value in POS promotion window
If the manual promotion don't have a predefined amount or percentage (must be set on the POS) then 'null' value is printed
1. Create a promotion with a no predefined discount (ex: "User Defined Percentage" and leave "Percentage discount" empty)
2. Connect to POS and refresh master data
3. Create an order and select the promotion you created => display 'null' is the window
Takeaway
depends on backport 0046413TAP closed javierRodriguez JIRA 1737 - 'null' value in POS promotion window 
png null_value.PNG (61,836) 2021-04-22 14:02
https://issues.openbravo.com/file_download.php?file_id=15559&type=bug
png
Issue History
2021-04-22 14:02jmelinNew Issue
2021-04-22 14:02jmelinAssigned To => Retail
2021-04-22 14:02jmelinFile Added: null_value.PNG
2021-04-22 14:02jmelinTriggers an Emergency Pack => No
2021-04-22 14:02jmelinTag Attached: Takeaway
2021-04-22 17:35guilleaerResolution time => 1619992800
2021-04-23 13:30javierRodriguezAssigned ToRetail => javierRodriguez
2021-04-29 10:31guilleaerStatusnew => scheduled
2021-05-12 16:52hgbotNote Added: 0128045
2021-05-12 19:13hgbotNote Added: 0128048
2021-05-17 19:14hgbotNote Added: 0128268
2021-05-17 19:14hgbotNote Added: 0128269
2021-05-17 19:15hgbotResolutionopen => fixed
2021-05-17 19:15hgbotStatusscheduled => closed
2021-05-17 19:15hgbotNote Added: 0128270
2021-05-17 19:15hgbotNote Added: 0128271
2021-05-17 19:15hgbotNote Added: 0128272
2021-05-17 19:15hgbotNote Added: 0128273
2021-05-17 19:15hgbotNote Added: 0128274
2021-05-17 19:15hgbotNote Added: 0128275

Notes
(0128045)
hgbot   
2021-05-12 16:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/498 [^]
(0128048)
hgbot   
2021-05-12 19:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/452 [^]
(0128268)
hgbot   
2021-05-17 19:14   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: a1be804b86670c836c751deef218a8e631396763
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-17T16:08:52+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a1be804b86670c836c751deef218a8e631396763 [^]

Related ISSUE-46324: need some improvements in BaseFormInput, MultiButtonBar and VirtualNumericInput

---
M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.jsx
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonBar.jsx
M web-jspack/org.openbravo.core2/src/components/VirtualNumericInput/VirtualNumericInput.jsx
---
(0128269)
hgbot   
2021-05-17 19:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/498 [^]
(0128270)
hgbot   
2021-05-17 19:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8d19dea6d4988180c2109e03994c9385d1e71984
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-17T15:45:37+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8d19dea6d4988180c2109e03994c9385d1e71984 [^]

Fixed ISSUE-46324: Handle null discount value in manual discounts and order discounts flows

---
A web-jspack/org.openbravo.pos2/src/model/ticket/__test__/DiscountActionPreparation.test.js
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/DiscountActionPreparation.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountAmountCell/DiscountAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountInputAmountCell/DiscountInputAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/OrderDiscountAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/__test__/OrderDiscountAmountCell.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountInputAmountCell/OrderDiscountInputAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountInputAmountCell/__test__/OrderDiscountInputAmountCell.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountInputAmountCell/__test__/__mock__/discountMock.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
---
(0128271)
hgbot   
2021-05-17 19:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/452 [^]
(0128272)
hgbot   
2021-05-17 19:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ddf4c5d03c845370601969d8a4b806aeeac9d301
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-17T15:45:37+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ddf4c5d03c845370601969d8a4b806aeeac9d301 [^]

Related to ISSUE-46324: Add message and refactor isEmptyValue function in DiscountActionPreparation

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/DiscountActionPreparation.js
---
(0128273)
hgbot   
2021-05-17 19:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: df4ff1cb4f350795e4b938119079abf7751481a7
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-17T15:45:37+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/df4ff1cb4f350795e4b938119079abf7751481a7 [^]

Related to ISSUE-46324: fix empty value function

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/DiscountActionPreparation.js
---
(0128274)
hgbot   
2021-05-17 19:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0c258df960b4caa569e27e4f787cd77a4570f3de
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-17T15:45:37+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0c258df960b4caa569e27e4f787cd77a4570f3de [^]

Related to ISSUE-46324: Change how to show when the discount has not a default value in grid row

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountAmountCell/DiscountAmountCell.jsx
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/OrderDiscountAmountCell.jsx
---
(0128275)
hgbot   
2021-05-17 19:15   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3e80f414054ec883c4b096ad93e125eb2862f7e9
Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com>
Date: 2021-05-17T15:45:37+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3e80f414054ec883c4b096ad93e125eb2862f7e9 [^]

Related to ISSUE-46324: Fix some tests

---
M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountAmountCell/__test__/OrderDiscountAmountCell.test.jsx
---