Openbravo Issue Tracking System - POS2
View Issue Details
0046317POS2POSpublic2021-04-21 18:482021-07-07 20:11
jmelin 
jarmendariz 
highmajoralways
closedfixed 
30Openbravo Appliance 14.04
 
 
No
0046317: JIRA 1506 - Missing feature to get customer informations and unassigned customer on order screen
The following screen was presented and validated in the mockup but he is not available.

https://drive.google.com/file/d/1mo6WRG_lqlh_cOL8dGPGXtNseCk2FiRz/view [^]

When clicking on an assigned customer, a popup should appear to allow to :
- Unassigned the customer
- See customer personal information
- Add some custom dev linked to Comarch (get order and promotions/coupons)
Click on an assigned customer => No popup available.
Takeaway
depends on backport 0047073TAP closed jarmendariz JIRA 1506 - Missing feature to get customer informations and unassigned customer on order screen 
has duplicate design defect 0047034TAP closed Retail JIRA 2019 - ux/ui - unselect a client 
png image-20210603-091420.png (125,928) 2021-06-24 10:23
https://issues.openbravo.com/file_download.php?file_id=15958&type=bug
png

png image-20210608-102239.png (101,820) 2021-06-24 10:23
https://issues.openbravo.com/file_download.php?file_id=15959&type=bug
png
Issue History
2021-04-21 18:48jmelinNew Issue
2021-04-21 18:48jmelinAssigned To => Retail
2021-04-21 18:48jmelinTriggers an Emergency Pack => No
2021-04-22 23:05guilleaerTag Attached: Takeaway
2021-04-28 13:36guilleaerNote Added: 0127619
2021-04-28 13:36guilleaerAssigned ToRetail => jmelin
2021-04-28 13:36guilleaerStatusnew => feedback
2021-04-28 15:19jmelinNote Added: 0127622
2021-04-28 15:19jmelinAssigned Tojmelin => guilleaer
2021-04-28 15:19jmelinStatusfeedback => new
2021-04-28 17:23guilleaerNote Added: 0127626
2021-04-28 17:23guilleaerAssigned Toguilleaer => dbaz
2021-04-28 17:23guilleaerStatusnew => feedback
2021-04-28 17:40dbazNote Added: 0127627
2021-04-28 17:42guilleaerAssigned Todbaz => Retail
2021-04-28 17:42guilleaerStatusfeedback => new
2021-04-29 10:22guilleaerStatusnew => acknowledged
2021-06-09 11:56dmiguelezRelationship addedhas duplicate 0047034
2021-06-11 13:47dmiguelezResolution time => 1625176800
2021-06-11 13:47dmiguelezStatusacknowledged => scheduled
2021-06-11 13:48dmiguelezStatusscheduled => acknowledged
2021-06-24 10:23guilleaerFile Added: image-20210603-091420.png
2021-06-24 10:23guilleaerFile Added: image-20210608-102239.png
2021-06-24 10:24guilleaerNote Added: 0129761
2021-06-24 10:26guilleaerResolution time1625176800 => 1625781600
2021-06-24 10:27guilleaerStatusacknowledged => scheduled
2021-06-24 10:27guilleaerAssigned ToRetail => jarmendariz
2021-07-01 17:24hgbotNote Added: 0130076
2021-07-01 18:10hgbotNote Added: 0130082
2021-07-07 20:08hgbotNote Added: 0130244
2021-07-07 20:08hgbotNote Added: 0130245
2021-07-07 20:11hgbotResolutionopen => fixed
2021-07-07 20:11hgbotStatusscheduled => closed
2021-07-07 20:11hgbotNote Added: 0130246
2021-07-07 20:11hgbotNote Added: 0130247

Notes
(0127619)
guilleaer   
2021-04-28 13:36   
How this popover can appear?
currently when this button is clicked the popup to search customer is opened and AFAIK this is correct
(0127622)
jmelin   
2021-04-28 15:19   
It should be seen with David as it's part of the mockup he did.
He told me to open this issue
(0127626)
guilleaer   
2021-04-28 17:23   
How this popover can appear?
currently when this button is clicked the popup to search customer is opened and AFAIK this is correct
(0127627)
dbaz   
2021-04-28 17:40   
In Figma has been just added in "A110 - Set Customer - 060 - Options"

This is shown only if the Customer has been already set to the receipt header (if not, it should continue showing the search customer popup).

View Info should open the readonly popup with the form of all the information about the customer. In the bottom, there should be "EDIT" and "UNASSIGN FROM RECEIPT" and "CLOSE" buttons.

Ticket History by the moment can be as simple as go to "Orders" window with the Customer filter set to this particular customer.

Unassign should remove the Customer from the receipt header.

Additionally, custom developments should be able to add more entries there, like the "Promotions" one that jmelin pointed
(0129761)
guilleaer   
2021-06-24 10:24   
Approved to do:

Unassign should remove the Customer from the receipt header.
View Info should open the readonly popup with the form of all the information about the customer. In the bottom, there should be "EDIT" and "UNASSIGN FROM RECEIPT" and "CLOSE" buttons.

Rest of the things are out of the scope
(0130076)
hgbot   
2021-07-01 17:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/589 [^]
(0130082)
hgbot   
2021-07-01 18:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/583 [^]
(0130244)
hgbot   
2021-07-07 20:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 6a5a0f7201e4e1cabbb82dfea92ff512cb6ee168
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-07-07T20:08:27+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6a5a0f7201e4e1cabbb82dfea92ff512cb6ee168 [^]

Related to ISSUE-46317: Extending BaseMenu to pass a payload object to menu item user actions

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/583 [^]

---
M web-jspack/org.openbravo.core2/src/components/BaseMenu/BaseMenu.jsx
M web-jspack/org.openbravo.core2/src/components/BaseMenu/__test__/BaseMenu.test.jsx
---
(0130245)
hgbot   
2021-07-07 20:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/583 [^]
(0130246)
hgbot   
2021-07-07 20:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d2604bee22898e414b62528d2750395c74dc6caf
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-07-07T20:10:29+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d2604bee22898e414b62528d2750395c74dc6caf [^]

Fixed ISSUE-46317: Adding menu to view details and unassign Customer from Ticket header

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/589 [^]

---
A web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormTicketFooter.config.json
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPButton/TicketHeaderBPMenu.config.json
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPButton/TicketHeaderBPMenu.jsx
A web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPButton/selectFooterConfigByContext.js
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/UnassignExternalBusinessPartner.js
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/UnassignExternalBusinessPartner.test.js
A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/UnassignExternalBusinessPartner.js
A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/UnassignExternalBusinessPartner.test.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/stories/ButtonBar1.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerForm.jsx
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerFormFooter.config.json
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPButton/TicketHeaderBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPButton/__test__/TicketHeaderBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPButton/stories/TicketHeaderBPButton.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeaderBPWithDocType/stories/TicketHeaderBPWithDocTypeStoriesUtils.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AssignExternalBusinessPartner.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetCustomerToManage.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/actions/SetCustomerToManage.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/ViewCustomer.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0130247)
hgbot   
2021-07-07 20:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/589 [^]