Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046313POS2POSpublic2021-04-20 18:112021-06-02 14:40
Reporterjcbourgeois 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046313: JIRA 1653 - Safe box : In Count Safe Box window, display drawers having status=free only
DescriptionIn Count Safe Box window, all the drawers configured for the store are displayed without considering the status of the drawer.
Drawers with status = Attached should not be counted by the cashier. So it's useless to display those drawers in the list.
So it should be better to display only drawers with status=free in this window
Steps To Reproduce1) In OB Backend, configure safe boxes and cash payment method to be processed with safe box.
2) In WebPOS, after logging in, assign a safe box to the current session.
3) Status of this safe box turns into Attached
4) Open Count Safe Box menu, all known safe boxes are displayed.
5) Click on a safe box having status = Attached. It starts the count safebox process but it should not be allowed because the safebox is part of an ongoing cashup, and should not be counted until it has been extracted by closing the till.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0046389TAP closed AugustoMauch JIRA 1653 - Safe box : In Count Safe Box window, display drawers having status=free only 
related to defect 0046375 closed pablobessone JIRA 1653 - Safe box : In Open Safe Box window, display drawers having status=free or attached (not in use) only 
Attached Filespng 2021-04-20 18_05_35-.png (45,317) 2021-04-20 18:11
https://issues.openbravo.com/file_download.php?file_id=15548&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2021-04-20 18:11jcbourgeoisNew Issue
2021-04-20 18:11jcbourgeoisAssigned To => Retail
2021-04-20 18:11jcbourgeoisFile Added: 2021-04-20 18_05_35-.png
2021-04-20 18:11jcbourgeoisTriggers an Emergency Pack => No
2021-04-27 16:20jcbourgeoisNote Added: 0127588
2021-04-28 11:45AugustoMauchSummaryJIRA 1653 - Safe box : In Count Safe Box window, display drawers having status=attached only => JIRA 1653 - Safe box : In Count Safe Box window, display drawers having status=free only
2021-04-28 11:45AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=22378#r22378
2021-04-28 11:45AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22380#r22380
2021-04-28 11:51guilleaerResolution time => 1620770400
2021-04-28 12:03guilleaerAssigned ToRetail => pablobessone
2021-04-28 12:03guilleaerStatusnew => scheduled
2021-04-28 20:45hgbotNote Added: 0127628
2021-04-29 20:11guilleaerRelationship addedrelated to 0046375
2021-05-13 18:04hgbotResolutionopen => fixed
2021-05-13 18:04hgbotStatusscheduled => closed
2021-05-13 18:04hgbotNote Added: 0128066
2021-05-13 18:04hgbotNote Added: 0128067
2021-05-21 17:59guilleaerAssigned Topablobessone => AugustoMauch
2021-05-21 17:59guilleaerStatusclosed => new
2021-05-21 17:59guilleaerResolutionfixed => open
2021-05-21 17:59guilleaerStatusnew => scheduled
2021-06-02 00:38hgbotNote Added: 0128898
2021-06-02 14:40hgbotResolutionopen => fixed
2021-06-02 14:40hgbotStatusscheduled => closed
2021-06-02 14:40hgbotNote Added: 0128943
2021-06-02 14:40hgbotNote Added: 0128944

Notes
(0127588)
jcbourgeois   
2021-04-27 16:20   
Actually the requirement is the following : in Count Safe Box feature, we should only display drawers that have been closed (=drawers having a closing date or status=Free)
(0127628)
hgbot   
2021-04-28 20:45   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/426 [^]
(0128066)
hgbot   
2021-05-13 18:04   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0cdec4f2258268b876a16a3864380c941cfe349b
Author: pablo.bessone <pablo.bessone@smfconsulting.es>
Date: 2021-05-13T18:04:17+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0cdec4f2258268b876a16a3864380c941cfe349b [^]

fixed ISSUE-0046313 and ISSUE-0046375: added new condition to only show drawers that are status FREE or has a CLOSING DATE

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/mock/SelectDrawerStepMock.config.json
---
(0128067)
hgbot   
2021-05-13 18:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/426 [^]
(0128898)
hgbot   
2021-06-02 00:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/512 [^]
(0128943)
hgbot   
2021-06-02 14:40   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: baa178302386d0a907d8095d3f130d0fe508de60
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 2021-06-02T14:39:13+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/baa178302386d0a907d8095d3f130d0fe508de60 [^]

Fixes ISSUE-46313: If user is not safebox manager do not show currently attached safebox

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx
---
(0128944)
hgbot   
2021-06-02 14:40   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/512 [^]