Openbravo Issue Tracking System - Retail Modules
View Issue Details
0046302Retail ModulesWeb POSpublic2021-04-20 08:042021-04-21 10:12
caristu 
caristu 
highminorhave not tried
closedfixed 
5
 
RR21Q3 
Packaging and release
2021-03-04
https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/59e0d5edb148d43136aa6c37efcfa57d033828f7 [^]
No
0046302: Context change is not properly checked in some requests
With every backend request, it is checked whether the current context (client, org, user, role) has changed. If changed, a confirmation is shown to the user in order to log in again.

This check is being wrongly skipped in some backend requests.
1) Put a breakpoint here[1]. This is the place where the context check is skipped when it is not possible to get the information.
2) Log in in WebPOS.
3) Note that we are skipping the check in some requests although they contain context information


[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/integration/remote-server/BackendServer.js#L72 [^]
The context info is not being recovered properly in some requests, this is because we are recovering it from the "contextInfo" property of the response object and in some requests it comes inside "response.contextInfo" property instead
No tags attached.
depends on backport 0046312RR21Q2.1 closed caristu Context change is not properly checked in some requests 
caused by feature request 0045918 closed caristu Offline<->Online Transitions Reimplementation 
related to design defect 0046303 new Retail Review if context change check mechanism should be deleted 
Issue History
2021-04-20 08:04caristuNew Issue
2021-04-20 08:04caristuAssigned To => Retail
2021-04-20 08:04caristuTriggers an Emergency Pack => No
2021-04-20 08:10caristuIssue cloned0046303
2021-04-20 08:10caristuRelationship addedrelated to 0046303
2021-04-20 08:20hgbotNote Added: 0127378
2021-04-20 08:29caristuRelationship addedrelated to 0045918
2021-04-20 18:03caristuRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/59e0d5edb148d43136aa6c37efcfa57d033828f7 [^]
2021-04-20 18:05caristuRegression level => Packaging and release
2021-04-20 18:05caristuRegression date => 2021-03-04
2021-04-20 18:07caristuStatusnew => scheduled
2021-04-20 18:14caristuRelationship deletedrelated to 0045918
2021-04-20 18:15caristuRelationship addedcaused by 0045918
2021-04-21 10:12hgbotResolutionopen => fixed
2021-04-21 10:12hgbotStatusscheduled => closed
2021-04-21 10:12hgbotFixed in Version => RR21Q3
2021-04-21 10:12hgbotNote Added: 0127405
2021-04-21 10:12hgbotNote Added: 0127406
2021-04-21 10:12alostaleAssigned ToRetail => caristu

Notes
(0127378)
hgbot   
2021-04-20 08:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/213 [^]
(0127405)
hgbot   
2021-04-21 10:12   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 0a96ab90f7faba6df29379842a84296629a8b772
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-04-21T08:03:56+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/0a96ab90f7faba6df29379842a84296629a8b772 [^]

fixes ISSUE-46302: context is not properly checked in some requests

---
M web/org.openbravo.mobile.core/app/integration/remote-server/BackendServer.js
---
(0127406)
hgbot   
2021-04-21 10:12   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/213 [^]