Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046294POS2POSpublic2021-04-19 14:382021-04-24 10:20
Reporterjmelin 
Assigned Tocberner 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046294: JIRA 1711 - Keymap editor can not be disabled on POS
DescriptionNo "User action access" in role management or preference is available to disable access to "Keymap editor" on POS or other switch window user actions.
Steps To Reproduce1. Connect to BO with Openbravo and role "White valley group admin"
2. Open "Role" window and "User action access" tab for role ='VallBlancaUser'
3. Look for an action related to "Keymap editor"=> none is available
Proposed Solution
Additional Information
TagsTakeaway
Relationships
depends on defect 0046332 closed cberner User actions that exceed 40 characters can't be secured in AD 
depends on backport 0046336TAP closed cberner JIRA 1711 - Keymap editor can not be disabled on POS 
related to defect 0046295 closed cberner JIRA 1713 - Can not remove or disable "Organization Variables" from POS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-04-19 14:38jmelinNew Issue
2021-04-19 14:38jmelinAssigned To => Retail
2021-04-19 14:38jmelinTriggers an Emergency Pack => No
2021-04-19 14:39jmelinSummaryKeymap editor can not be disabled on POS => JIRA 1711 - Keymap editor can not be disabled on POS
2021-04-21 16:30cbernerNote Added: 0127421
2021-04-21 16:30cbernerAssigned ToRetail => jmelin
2021-04-21 16:30cbernerStatusnew => feedback
2021-04-22 11:00jmelinNote Added: 0127440
2021-04-22 11:00jmelinStatusfeedback => new
2021-04-22 11:00jmelinAssigned Tojmelin => cberner
2021-04-22 14:03jmelinTag Attached: Takeaway
2021-04-22 17:18guilleaerStatusnew => scheduled
2021-04-22 17:20guilleaerResolution time => 1619992800
2021-04-22 19:47hgbotNote Added: 0127472
2021-04-22 19:47hgbotNote Added: 0127473
2021-04-23 09:44hgbotNote Added: 0127490
2021-04-23 09:50cbernerDescription Updatedbug_revision_view_page.php?rev_id=22358#r22358
2021-04-23 09:57cbernerNote Added: 0127491
2021-04-23 10:16caristuRelationship addeddepends on 0046332
2021-04-23 13:16cbernerStatusscheduled => resolved
2021-04-23 13:16cbernerResolutionopen => fixed
2021-04-23 13:16cbernerStatusresolved => new
2021-04-23 13:16cbernerResolutionfixed => open
2021-04-23 13:16cbernerStatusnew => scheduled
2021-04-23 14:29hgbotNote Added: 0127502
2021-04-23 14:29hgbotNote Added: 0127503
2021-04-23 14:29hgbotResolutionopen => fixed
2021-04-23 14:29hgbotStatusscheduled => closed
2021-04-23 14:29hgbotNote Added: 0127504
2021-04-23 14:29hgbotNote Added: 0127505
2021-04-23 14:29hgbotNote Added: 0127506
2021-04-23 14:29hgbotNote Added: 0127507
2021-04-24 10:19cbernerRelationship addedrelated to 0046295
2021-04-24 10:20cbernerNote Added: 0127517

Notes
(0127421)
cberner   
2021-04-21 16:30   
To be able to see the Keymap editor user action in User action access tab for role VallBlancaUser it is necessary to first add it to User Action and secure it. To achieve this follow this steps:
1. Connect to Backoffice as System
2. Go to Application Dictionary -> User Action
3. Add a new entry here with the following searchKey: "SwitchCurrentWindow_OBPOS2_KeyMapEditorWindow", set also a name(it will be the one that will appear in the corresponding combo in User Action Access)
4. Change to role "White valley group admin"
5. Open "Role" window and "User action access" tab for role ='VallBlancaUser'
6. Look for the user action name added previously, it should appear there
(0127440)
jmelin   
2021-04-22 11:00   
Why is it not added by default with the module 'Web POS 2' like OBPOS2_LoadRemoteTicket or OBPOS2_CreateCustomer for example ?
(0127472)
hgbot   
2021-04-22 19:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/10 [^]
(0127473)
hgbot   
2021-04-22 19:47   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/477 [^]
(0127490)
hgbot   
2021-04-23 09:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/412 [^]
(0127491)
cberner   
2021-04-23 09:57   
This same problem happens for all user actions that are window switch actions, as such the merge requests associated with this, should also fix those.

For example: SwitchCurrentWindow_OBPOS2_MainWindow, SwitchCurrentWindow_OBPOS2_OrgVariablesWindow, SwitchCurrentWindow_OBPOS2_CustomerWindow...
(0127502)
hgbot   
2021-04-23 14:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 6ded4977adafafbe6862bd3880f9da828a192205
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-04-23T12:26:47+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/6ded4977adafafbe6862bd3880f9da828a192205 [^]

Related to ISSUE-46294: Add missing SwitchCurrentWindow_OBC2_OrgVariablesWindow user action

SwitchCurrentWindow user actions have all been registered by default, so
those may be secured by other modules.

---
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
---
(0127503)
hgbot   
2021-04-23 14:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/477 [^]
(0127504)
hgbot   
2021-04-23 14:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: dd0d64f23d9b0db54246945ed3ab11b88739a2dc
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-04-23T14:28:46+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/dd0d64f23d9b0db54246945ed3ab11b88739a2dc [^]

Fixes ISSUE-46294: Keymap editor can not be disabled on POS

Keymap editor switch window user action is not the only one that needs
to be secured. All SwitchCurrentWindow_ user actions should be added by
default, for example SwitchCurrentWindow_OBPOS2_MainWindow.

SwitchCurrentWindow user actions have all been registered by default, so
those may be secured by other modules.

---
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
---
(0127505)
hgbot   
2021-04-23 14:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/412 [^]
(0127506)
hgbot   
2021-04-23 14:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata [^]
Changeset: 2a3e47a8f5c392e73b3bf532c57020a4c5921ce0
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-04-23T12:26:50+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/commit/2a3e47a8f5c392e73b3bf532c57020a4c5921ce0 [^]

Related to ISSUE-46294: Add UserActionAccess for all SwitchCurrentWindow on all roles

Keymap editor switch window user action is not the only one that needs
to be secured. All SwitchCurrentWindow_ user actions should be added by
default, for example SwitchCurrentWindow_OBPOS2_MainWindow.

This is fixed by adding all SwitchCurrentWindow generated user actions
to the specific role and this commit adds the User Action Access information for
all roles in The White Valley Group

---
M referencedata/sampledata/The_White_Valley_Group/OBC2_USER_ACTION_ACCESS.xml
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
---
(0127507)
hgbot   
2021-04-23 14:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/10 [^]
(0127517)
cberner   
2021-04-24 10:20   
Added the corresponding user actions to core2 and pos2 for all SwitchCurrentWindow user actions to be able to use them in User Action Access roles.