Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046260Openbravo LocalizationsLocalization Portugalpublic2021-04-13 15:402021-09-22 12:07
Reporterpsanjuan 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Support ticket23186
OBNetwork customerGold
Regression introduced in release
Summary0046260: Wrong region code for Açores and Madeira regions. Rest of regions need to have the code PT
DescriptionWrong region code for Açores and Madeira regions. ISO code is required by PT SAFT file.
Steps To ReproduceN/A
Proposed SolutionCorrect search key or value for below listed PT regions is:

Madeira = MA
Acores = AC

Rest of Regions should have as search key the value "PT", as that is the country ISO code of Portugal, validated in SAFT file.

This change needs to be done in the module Portuguese Regions:

https://centralrepository.openbravo.com/openbravo/org.openbravo.forge.ui/sso/ForgeModuleDetail/Portuguese-Regions [^]
Additional Information
TagsNOR
Relationships
related to defect 0046262 closed markmm82 SAFT code must export the region search key if a tax rate has a region setup 
related to feature request 0046264 closed caristu New taxes need to be created in the PT taxes dataset 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-04-13 15:40psanjuanNew Issue
2021-04-13 15:40psanjuanAssigned To => psanjuan
2021-04-13 15:40psanjuanOBNetwork customer => No
2021-04-13 15:40psanjuanAssigned Topsanjuan => Triage Finance
2021-04-13 15:54psanjuanProposed Solution updated
2021-04-13 15:56psanjuanDescription Updatedbug_revision_view_page.php?rev_id=22309#r22309
2021-04-13 15:56psanjuanProposed Solution updated
2021-04-13 15:58psanjuanProposed Solution updated
2021-04-13 17:56vmromanosAssigned ToTriage Finance => markmm82
2021-04-14 08:55maiteResolution time => 1620165600
2021-04-14 08:55maiteSupport ticket => 23186
2021-04-14 08:55maiteOBNetwork customerNo => Gold
2021-04-14 09:05rafarodaTag Attached: NOR
2021-04-14 09:05rafarodaIssue Monitored: rafaroda
2021-04-14 10:31maiteIssue Monitored: maite
2021-04-20 14:01psanjuanProposed Solution updated
2021-04-20 14:07psanjuanRelationship addedrelated to 0046262
2021-04-20 16:19markmm82Statusnew => scheduled
2021-04-20 17:03hgbotMerge Request Status => open
2021-04-20 17:03hgbotNote Added: 0127395
2021-04-20 17:10markmm82Note Added: 0127396
2021-04-23 08:33hgbotMerge Request Statusopen => approved
2021-04-23 08:34hgbotResolutionopen => fixed
2021-04-23 08:34hgbotNote Added: 0127487
2021-04-23 08:34hgbotStatusscheduled => closed
2021-04-23 08:34hgbotNote Added: 0127488
2021-04-23 09:24psanjuanNote Added: 0127489
2021-04-23 14:18markmm82Note Added: 0127501
2021-09-22 12:07psanjuanSummaryWrong region code for Açores and Madeira regions => Wrong region code for Açores and Madeira regions. Rest of regions need to have the code PT
2021-09-22 12:16rafarodaRelationship addedrelated to 0046264

Notes
(0127395)
hgbot   
2021-04-20 17:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.portugal.regions/-/merge_requests/1 [^]
(0127396)
markmm82   
2021-04-20 17:10   
Test Plan:

Go to Country and Regions window.
Filter by Portugal Search Key = PT
Go to Regions tab.
Notice all te regions have "PT" as search key, except Madeira and Acores that have the following information:
  Madeira = MA
  Acores = AC
(0127487)
hgbot   
2021-04-23 08:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.portugal.regions/-/merge_requests/1 [^]
(0127488)
hgbot   
2021-04-23 08:34   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.portugal.regions [^]
Changeset: 3feb9d55ee5487d354f000abeb93da16da3a1f8d
Author: Mark Orlando Molina <markmm82@gmail.com>
Date: 2021-04-23T06:34:15+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.portugal.regions/-/commit/3feb9d55ee5487d354f000abeb93da16da3a1f8d [^]

Fixes BUG-46260: Fixed Portugal region search keys

---
M referencedata/standard/Portuguese_Regions.xml
M src-db/database/sourcedata/AD_DATASET.xml
---
(0127489)
psanjuan   
2021-04-23 09:24   
Query below will have to be executed for existing customer enviroments as Country/Region dataset is a system dataset which can only be applied through "install.source" process.
(0127501)
markmm82   
2021-04-23 14:18   
Query to update Portugal regions manually:
update c_region set value = 'PT' where c_country_id='281' and name not in ('Açores', 'Madeira');