Openbravo Issue Tracking System - Retail Modules | ||||||||||||
View Issue Details | ||||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | |||||||
0046244 | Retail Modules | Web POS | public | 2021-04-10 08:10 | 2021-04-12 09:57 | |||||||
Reporter | jetxarri | |||||||||||
Assigned To | Retail | |||||||||||
Priority | normal | Severity | minor | Reproducibility | always | |||||||
Status | new | Resolution | open | |||||||||
Platform | OS | 5 | OS Version | |||||||||
Product Version | RR21Q1.1 | |||||||||||
Target Version | Fixed in Version | |||||||||||
Merge Request Status | ||||||||||||
Review Assigned To | ||||||||||||
OBNetwork customer | ||||||||||||
Support ticket | ||||||||||||
Regression level | ||||||||||||
Regression date | ||||||||||||
Regression introduced in release | ||||||||||||
Regression introduced by commit | ||||||||||||
Triggers an Emergency Pack | No | |||||||||||
Summary | 0046244: Remove legacy code that it is not working and it is making the login slower | |||||||||||
Description | File "web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js" We can find the following peace of code if (!OB.MobileApp.model.hasPermission('OBPOS_remote.product', true)) { loadProductCharacteristics(); } else { var criteria = {}; OB.Dal.find( OB.Model.Characteristic, criteria, successCallbackProductCh, errorCallback ); } If we go deeper it is going to load all the product characteristics value let characteritics = await OB.App.MasterdataModels.ProductCharacteristicValue.find( criteriaCharacteristics ); And finally include into array for (let i = 0; i < characteritics.length; i++) { transformedCharacteristics.push( OB.Dal.transform( OB.Model.ProductCharacteristicValue, characteritics[i] ) ); } And finally include in the component attribute me.productsCh.reset(dataProductCh.models); But as it is an array, dataProductCh.models is always undefined and because it is not a backbone collection. This is an old code that maybe had sense in the past but no longer. P.S.: me.productsCh is set in another peace of code with product characteristic and not "product characteristics value" what it has more sense | |||||||||||
Steps To Reproduce | Do the login and verify that the above code is executed. | |||||||||||
Proposed Solution | Attached patch | |||||||||||
Additional Information | ||||||||||||
Tags | NOR | |||||||||||
Relationships |
| |||||||||||
Attached Files | patch.diff (2,797) 2021-04-10 08:10 https://issues.openbravo.com/file_download.php?file_id=15520&type=bug | |||||||||||
Issue History | ||||||||||||
Date Modified | Username | Field | Change | |||||||||
2021-04-10 08:10 | jetxarri | New Issue | ||||||||||
2021-04-10 08:10 | jetxarri | Assigned To | => Retail | |||||||||
2021-04-10 08:10 | jetxarri | File Added: patch.diff | ||||||||||
2021-04-10 08:10 | jetxarri | Triggers an Emergency Pack | => No | |||||||||
2021-04-12 09:45 | jetxarri | Tag Attached: NOR | ||||||||||
2021-04-12 09:57 | rafaroda | Relationship added | related to 0046182 |
There are no notes attached to this issue. |