Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046238Retail ModulesWeb POSpublic2021-04-09 13:522021-04-12 17:28
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046238: OrgVariables should be limited to 1 per organization tree, as hierarchy is not yet supported
DescriptionAn organizational variable should not be created in a parent/child of the same organizational tree if already present. This is needed because hierarchy is not supported yet in this part and it would avoid inconsistency with 2 variables with the same name from parent organizations.
Steps To Reproduce-
Proposed SolutionDo a check in OrgVariableEventObserver for this case.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-04-09 13:52cbernerNew Issue
2021-04-09 13:52cbernerAssigned To => cberner
2021-04-09 13:52cbernerOBNetwork customer => No
2021-04-09 13:52cbernerTriggers an Emergency Pack => No
2021-04-09 14:23hgbotMerge Request Status => open
2021-04-09 14:23hgbotNote Added: 0127199
2021-04-12 10:17hgbotMerge Request Statusopen => approved
2021-04-12 10:52hgbotResolutionopen => fixed
2021-04-12 10:52hgbotStatusnew => closed
2021-04-12 10:52hgbotNote Added: 0127228
2021-04-12 10:52hgbotFixed in Version => RR21Q3
2021-04-12 10:52hgbotNote Added: 0127229
2021-04-12 17:28hgbotNote Added: 0127239

Notes
(0127199)
hgbot   
2021-04-09 14:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/206 [^]
(0127228)
hgbot   
2021-04-12 10:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/206 [^]
(0127229)
hgbot   
2021-04-12 10:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: d831f680fdd7c7a6855225aa36c74cc94a6d23a2
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-04-12T09:50:38+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d831f680fdd7c7a6855225aa36c74cc94a6d23a2 [^]

Fixes ISSUE-46238: OrgVariables should be limited to 1 per organization tree

This is necessary due to hierarchy not being supported in OrgVariables.
A check has been implemented in EventObserver to detect this case, where
an organization variable reference is already present in one of the
organization natural tree, if so, it will fail with an explicative
error.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/mobile/core/eventobservers/OrgVariableEventObserver.java
---
(0127239)
hgbot   
2021-04-12 17:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 9756282091a517e4f4f180c0e63bc54a7c47f776
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-04-12T17:26:41+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9756282091a517e4f4f180c0e63bc54a7c47f776 [^]

Related to ISSUE-46238: Remove not used import in OrgVariableEventObserver

A warning was being shown in ret-checks because of a not used import.

---
M src/org/openbravo/mobile/core/eventobservers/OrgVariableEventObserver.java
---