Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046131Retail ModulesWeb POSpublic2021-03-24 12:132021-03-25 18:29
Reportergorka_gil 
Assigned Togorka_gil 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046131: Terminal log should use the new way to check if pos is online
DescriptionThis is the new way to check if pos is online or offline:
- OB.App.State.getState().RemoteServer.BackendServer?.isOnline

This was the old way:
- OB.App.TerminalProperty.get('connectedToERP')

In new pos the old way to check is no longer working,
and the new way is available in old an new pos.

So the new way should be implemented in new and old pos
Steps To ReproduceIn new pos in the openbravo log there are errors:
TerminalLogLoader.java: JSONException: JSONObject["o"] not found.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-03-24 12:13gorka_gilNew Issue
2021-03-24 12:13gorka_gilAssigned To => gorka_gil
2021-03-24 12:13gorka_gilOBNetwork customer => No
2021-03-24 12:13gorka_gilTriggers an Emergency Pack => No
2021-03-24 12:17hgbotMerge Request Status => open
2021-03-24 12:17hgbotNote Added: 0126887
2021-03-24 12:22hgbotNote Added: 0126888
2021-03-25 18:18hgbotMerge Request Statusopen => approved
2021-03-25 18:28hgbotResolutionopen => fixed
2021-03-25 18:28hgbotStatusnew => closed
2021-03-25 18:28hgbotFixed in Version => RR21Q2
2021-03-25 18:28hgbotNote Added: 0126923
2021-03-25 18:28hgbotNote Added: 0126924
2021-03-25 18:28hgbotNote Added: 0126925
2021-03-25 18:29hgbotNote Added: 0126926
2021-03-25 18:29hgbotNote Added: 0126927

Notes
(0126887)
hgbot   
2021-03-24 12:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/197 [^]
(0126888)
hgbot   
2021-03-24 12:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/412 [^]
(0126923)
hgbot   
2021-03-25 18:28   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 6185f62f0da282debf5302c76ec509407e8e60c5
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-03-25T17:28:34+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/6185f62f0da282debf5302c76ec509407e8e60c5 [^]

Fixes ISSUE-46131: terminal log use the new way to check if online/offline

---
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/TerminalLogUtils.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddButtonClick.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddKey.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddLog.js
M web/org.openbravo.mobile.core/app/model/business-object/terminal-log/actions/AddProcess.js
---
(0126924)
hgbot   
2021-03-25 18:28   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 21842e93fe3db66e707c3d083e38703f2d46a5ef
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-03-25T17:28:34+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/21842e93fe3db66e707c3d083e38703f2d46a5ef [^]

Related to ISSUE-46131: adapt terminal log tests to the new online check

---
M web-test/model/business-object/terminal-log/TerminalLog-AddButtonClick-ActionPreparation.test.js
M web-test/model/business-object/terminal-log/TerminalLog-AddLog-ActionPreparation.test.js
M web-test/model/business-object/terminal-log/TerminalLog-AddProcess-ActionPreparation.test.js
M web-test/model/business-object/terminal-log/TerminalLog-Addkey-ActionPreparation.test.js
---
(0126925)
hgbot   
2021-03-25 18:28   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/197 [^]
(0126926)
hgbot   
2021-03-25 18:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 142ea263676a8a7168894ffe3fa7ce47d22234d5
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-03-25T17:29:10+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/142ea263676a8a7168894ffe3fa7ce47d22234d5 [^]

Related to ISSUE-46131: terminal log use the new way to check if online/offline

---
M web-jspack/org.openbravo.core2/src/model/terminal-log/actions/AddUserActionActionPreparation.js
---
(0126927)
hgbot   
2021-03-25 18:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/412 [^]