Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046121Retail ModulesWeb POSpublic2021-03-23 14:102021-03-29 09:07
Reporterjetxarri 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR20Q3.4 
Target VersionFixed in VersionRR21Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046121: Next button enabled in Count Safe Box
DescriptionAn js error is raise when 'Count Safe Box' and:
- There are more than one payment method as 'Defined in Safe Box' = Yes
- The preference 'CashUp - Group payments by expected amount' = Yes

The error (image 1) happens in step count cash. Next button is enabled before the payments are count.
Steps To ReproduceConfiguration:
1. Log into retail
2. Create a new Financial Account as image2.
3. Define a new payment method for the safe box VBSB03 as image3
4. In the 'Channel - Touchpoint Type'=VBS POS Safe Box Terminal Type, define the payment method 'Voucher' as 'Defined in Safe Box'=Yes.
5. Set the preference 'CashUp - Group payments by expected amount' = Yes
Proposed Solution
Additional Information
TagsNOR
Relationships
related to defect 0046123 closed rqueralta Incompatibility fix for issue 45905 module org.openbravo.retail.maxlevelofcash is broken 
related to defect 0045908 closed rqueralta js error when 'Count Safe Box' 
related to defect 0046122 closed rqueralta Javascript error when executing Count Safe Box process 
Attached Filesjpg Image1.JPG (216,059) 2021-03-23 14:10
https://issues.openbravo.com/file_download.php?file_id=15448&type=bug
jpg

jpg image2.JPG (183,982) 2021-03-23 14:10
https://issues.openbravo.com/file_download.php?file_id=15449&type=bug
jpg

jpg image3.JPG (150,279) 2021-03-23 14:10
https://issues.openbravo.com/file_download.php?file_id=15450&type=bug
jpg

diff nextButton.diff (1,337) 2021-03-23 14:10
https://issues.openbravo.com/file_download.php?file_id=15451&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-03-23 14:10jetxarriNew Issue
2021-03-23 14:10jetxarriAssigned To => Retail
2021-03-23 14:10jetxarriFile Added: Image1.JPG
2021-03-23 14:10jetxarriTriggers an Emergency Pack => No
2021-03-23 14:10jetxarriFile Added: image2.JPG
2021-03-23 14:10jetxarriFile Added: image3.JPG
2021-03-23 14:10jetxarriFile Added: nextButton.diff
2021-03-23 14:13jetxarriNote Added: 0126851
2021-03-23 14:35rafarodaRelationship addedrelated to 0046122
2021-03-23 14:35rafarodaTag Attached: NOR
2021-03-23 14:36rafarodaRelationship addedrelated to 0046123
2021-03-23 14:37rafarodaRelationship addedrelated to 0045908
2021-03-23 14:38rafarodaOBNetwork customer => Gold
2021-03-23 14:38rafarodaResolution time => 1617919200
2021-03-23 21:10rqueraltaAssigned ToRetail => rqueralta
2021-03-23 21:10rqueraltaStatusnew => scheduled
2021-03-24 08:48marvintmStatusscheduled => acknowledged
2021-03-24 08:48marvintmStatusacknowledged => scheduled
2021-03-24 08:48marvintmStatusscheduled => feedback
2021-03-24 08:48marvintmStatusfeedback => new
2021-03-24 08:48marvintmStatusnew => scheduled
2021-03-29 00:22hgbotMerge Request Status => open
2021-03-29 00:22hgbotNote Added: 0126961
2021-03-29 09:06hgbotMerge Request Statusopen => approved
2021-03-29 09:07hgbotResolutionopen => fixed
2021-03-29 09:07hgbotStatusscheduled => closed
2021-03-29 09:07hgbotFixed in Version => RR21Q2
2021-03-29 09:07hgbotNote Added: 0126979
2021-03-29 09:07hgbotNote Added: 0126980

Notes
(0126851)
jetxarri   
2021-03-23 14:13   
I can't edit the issue.

Related to issue https://issues.openbravo.com/view.php?id=45908 [^]

The problem is that due to preference "CashUp - Group payments by expected amount" the "allowNext" is getting wrong attribute in the model.
(0126961)
hgbot   
2021-03-29 00:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/356 [^]
(0126979)
hgbot   
2021-03-29 09:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: cf3b795f9dca32eb3ff098404b0f8251afd5dbe9
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-03-29T07:06:52+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/cf3b795f9dca32eb3ff098404b0f8251afd5dbe9 [^]

Fixed BUG-46121: Next button enabled in Count Safe Box

---
M web/org.openbravo.retail.posterminal/js/closecash/model/closecash-steps.js
---
(0126980)
hgbot   
2021-03-29 09:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/356 [^]