Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046087Retail ModulesWeb POSpublic2021-03-16 12:042021-03-17 09:54
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046087: Date filter is not properly applied when using the Discounts webservice
DescriptionDate filter is not properly applied when using the Discounts webservice. The expiration date is always compared to "now", instead of the orderdate specified as part of the order information
Steps To Reproduce- Define a discount with a specific "valid from" date.
- Use the Discounts webservice with an order with date earlier from that date
- Realise the discount is still applied.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0046055 closed ranjith_qualiantech_com API Discounts - issues found 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-03-16 12:04marvintmNew Issue
2021-03-16 12:04marvintmAssigned To => Retail
2021-03-16 12:04marvintmOBNetwork customer => Gold
2021-03-16 12:04marvintmResolution time => 1616626800
2021-03-16 12:04marvintmTriggers an Emergency Pack => No
2021-03-16 12:05marvintmRelationship addedrelated to 0046055
2021-03-16 12:08ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-03-16 12:09ranjith_qualiantech_comStatusnew => scheduled
2021-03-16 12:14hgbotMerge Request Status => open
2021-03-16 12:14hgbotNote Added: 0126727
2021-03-16 12:17hgbotMerge Request Statusopen => approved
2021-03-16 12:17hgbotNote Added: 0126729
2021-03-16 12:17hgbotResolutionopen => fixed
2021-03-16 12:17hgbotStatusscheduled => closed
2021-03-16 12:17hgbotFixed in Version => RR21Q2
2021-03-16 12:17hgbotNote Added: 0126730
2021-03-17 09:48hgbotNote Added: 0126741
2021-03-17 09:54hgbotNote Added: 0126742
2021-03-17 09:54hgbotNote Added: 0126743

Notes
(0126727)
hgbot   
2021-03-16 12:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/20 [^]
(0126729)
hgbot   
2021-03-16 12:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/20 [^]
(0126730)
hgbot   
2021-03-16 12:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 33104adf44032eccf6768f7fe12679aa0893f7ed
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-16T16:42:57+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/33104adf44032eccf6768f7fe12679aa0893f7ed [^]

Fixed ISSUE-46087: Updated discount date validation with orderDate instead of currentDate

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
---
(0126741)
hgbot   
2021-03-17 09:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/21 [^]
(0126742)
hgbot   
2021-03-17 09:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/21 [^]
(0126743)
hgbot   
2021-03-17 09:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 4b4d1cd255ab382ce6cdcaf253c9251dffd87b30
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-17T13:14:49+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/4b4d1cd255ab382ce6cdcaf253c9251dffd87b30 [^]

Fixed ISSUE-46087: Added Organization to Ticket for DiscountTest

---
A src-test/org/openbravo/retail/discounts/test/base/model/Organization.java
M src-test/org/openbravo/retail/discounts/test/base/model/Ticket.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
---