Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046086Retail ModulesWeb POSpublic2021-03-16 12:022021-03-16 12:17
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046086: Organisation filter is not properly applied when using the Discounts webservice
DescriptionWhen a discount is defined for some specific organisation, if the webservice is executed and an order for a different one is specified, the discount will still be applied
Steps To Reproduce- Define a discount for a particular organisation
- Use the webservice to specify an order from a different store
- Realise that the discount is still applied
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0046055 closed ranjith_qualiantech_com API Discounts - issues found 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-03-16 12:02marvintmNew Issue
2021-03-16 12:02marvintmAssigned To => Retail
2021-03-16 12:02marvintmOBNetwork customer => No
2021-03-16 12:02marvintmResolution time => 1616540400
2021-03-16 12:02marvintmTriggers an Emergency Pack => No
2021-03-16 12:04marvintmOBNetwork customerNo => Gold
2021-03-16 12:05marvintmRelationship addedrelated to 0046055
2021-03-16 12:08ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-03-16 12:09ranjith_qualiantech_comStatusnew => scheduled
2021-03-16 12:15hgbotMerge Request Status => open
2021-03-16 12:15hgbotNote Added: 0126728
2021-03-16 12:17hgbotMerge Request Statusopen => approved
2021-03-16 12:17hgbotResolutionopen => fixed
2021-03-16 12:17hgbotStatusscheduled => closed
2021-03-16 12:17hgbotNote Added: 0126731
2021-03-16 12:17hgbotNote Added: 0126732

Notes
(0126728)
hgbot   
2021-03-16 12:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/4 [^]
(0126731)
hgbot   
2021-03-16 12:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^]
Changeset: cf680038cc7580fe63ce95801f96b24488e27d03
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-16T16:42:44+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/cf680038cc7580fe63ce95801f96b24488e27d03 [^]

Fixed ISSUE-46086: Updated Discount query to check Included organizations
* Added active condition to discount subquery

---
M src/org/openbravo/discounts/engine/DiscountJSExecutor.java
---
(0126732)
hgbot   
2021-03-16 12:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/4 [^]