Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0046074Retail ModulesWeb POSpublic2021-03-15 14:032021-07-08 08:45
Reporterjetxarri 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0046074: Models with multiple queries do not accept pagination by Id
DescriptionWeb POS models like BP, Product or BPLoc can not be load using the pagination by id and instead they are being paginated using the offset.

Using the offset is creating a performance problem in the server when more than 400 full master data refreshes are executed at the same time. The main problem of using offset, it is creating a massive reading of the disk.
Steps To Reproduce-Configure a batch of 100 using preference "Masterdata models batch size". You need to have more than 100 products, however configure a lower number
-Do the login in Web POS
-Verify that the pagination is done using offset
Proposed Solution
Additional Information
TagsNOR, Performance
Relationships
related to defect 0046077 closed rqueralta Double upper case in the where clause searching by Name, search key or UPC 
related to feature request 0046183 new Retail Hierarchy of Price Lists: development to reduce number of records M_PRODUCTPRICE 
related to feature request 0046182 new Retail Refactor/improve of Promo Engine and full / incremental refresh to remove the ProductCharacteristicsValue model 
related to defect 0046187 closed ranjith_qualiantech_com WebPOS triggered unexpected Full Refresh 
related to defect 0047939 closed ranjith_qualiantech_com When the batch of products is small than the number of products to load, some products are not loaded 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-03-15 14:03jetxarriNew Issue
2021-03-15 14:03jetxarriAssigned To => Retail
2021-03-15 14:03jetxarriTriggers an Emergency Pack => No
2021-03-15 16:25rafarodaTag Attached: NOR
2021-03-15 16:26rafarodaResolution time => 1616194800
2021-03-15 16:26rafarodaPriorityhigh => urgent
2021-03-15 17:31rafarodaRelationship addedrelated to 0046077
2021-03-18 07:59marvintmResolution time1616194800 =>
2021-03-18 07:59marvintmNote Added: 0126766
2021-03-18 07:59marvintmTypedefect => feature request
2021-03-30 14:07rafarodaRelationship addedrelated to 0046183
2021-03-30 14:10rafarodaRelationship addedrelated to 0046182
2021-03-30 16:53rafarodaRelationship addedrelated to 0046187
2021-04-14 13:12rafarodaTag Attached: Performance
2021-05-03 13:28jetxarriNote Added: 0127741
2021-06-21 06:19ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-06-23 07:23ranjith_qualiantech_comStatusnew => scheduled
2021-06-28 09:09hgbotNote Added: 0129836
2021-06-28 09:09hgbotNote Added: 0129837
2021-07-08 08:45hgbotResolutionopen => fixed
2021-07-08 08:45hgbotStatusscheduled => closed
2021-07-08 08:45hgbotFixed in Version => RR21Q4
2021-07-08 08:45hgbotNote Added: 0130264
2021-07-08 08:45hgbotNote Added: 0130265
2021-07-08 08:45hgbotNote Added: 0130266
2021-07-08 08:45hgbotNote Added: 0130267
2021-11-30 07:23ranjith_qualiantech_comRelationship addedrelated to 0047939

Notes
(0126766)
marvintm   
2021-03-18 07:59   
I've moved this topic to feature request. This change would be useful, but it is not really a defect but a new project that would need to be developed, to add a feature that would allow us to enable pagination by id in masterdata models that are composed of more than one query.
(0127741)
jetxarri   
2021-05-03 13:28   
Merge requests were created

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/378 [^]

https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/208 [^]
(0129836)
hgbot   
2021-06-28 09:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/491 [^]
(0129837)
hgbot   
2021-06-28 09:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/245 [^]
(0130264)
hgbot   
2021-07-08 08:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: d658f7b0be24fd33a21e8459e5840933ced20374
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-07-08T12:08:06+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d658f7b0be24fd33a21e8459e5840933ced20374 [^]

Fixed ISSUE-46074: Added pagination by Id for MasterDataModels

---
M src/org/openbravo/mobile/core/process/JSONRowConverter.java
M src/org/openbravo/mobile/core/process/ProcessHQLQuery.java
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
---
(0130265)
hgbot   
2021-07-08 08:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/245 [^]
(0130266)
hgbot   
2021-07-08 08:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/491 [^]
(0130267)
hgbot   
2021-07-08 08:45   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 4ca875704d21401a027070c9496199aa10a7b93e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-07-08T11:39:23+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4ca875704d21401a027070c9496199aa10a7b93e [^]

Related to ISSUE-46074: Added Pagination by Id for MasterData Models

---
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
M src/org/openbravo/retail/posterminal/master/Discount.java
M src/org/openbravo/retail/posterminal/master/Product.java
M web/org.openbravo.retail.posterminal/app/model/masterdata/BusinessPartnerLocationModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/BusinessPartnerModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/ProductModel.js
M web/org.openbravo.retail.posterminal/app/model/masterdata/discount/DiscountModel.js
---