Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045966Retail ModulesLoyalty Programs for Web POSpublic2021-03-01 05:042021-03-11 08:11
Reportercollazoandy4 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045966: Customer Member Id field is empty in Loyalty Card popup if the subscription is flaged as isActive = false
DescriptionWhen customers can only subscribe to one loyalty program and this program have an inactive status (the subscription ends) the member id is shown empty in Loyalty Card popup if a new subscription is registered for a customer with a subscription with inactive status

This behavior can be simulate outside the client environment when the existing subscription is updated as isActive = false because the customer loyalty subscription is not loaded in LoyaltySubscriptions.java
Steps To ReproduceEnable Remote for Customer preference
  Log in STA-1 Pos terminal
    Search for Arturo Montoro customer and click on View Details contextual menu
    In Customer popup check the customer is subscribed to LOYA - Gold Customers loyalty program
    Click on Loyalty program to open Loyalty Program subscription popup
    Open loyalty subscription details popup (click on View details contextual menu) and check Member Id is LOY1000000
  Log in As Retail Test Admin Role in the backend
    Go to Business Partner window and select Arturo Montoro record
      In Subscription tab edit the first record as isActive = False
  Log in STA-1 Pos terminal
    Search for Arturo Montoro customer and click on View Details contextual menu
    In Customer popup check no loyalty subscription is shown
    Register a new subscription for Gold Customers loyalty program
    Check In new Loyalty Card popup the member Id field is empty
Proposed SolutionShow the customer Member Id in Loyalty Card popup when a new subscription are registering for the same loyalty program even if the last subscription can be retrieve in LoyaltySubscriptions.java because subscription status is inactive (client enviroment) or isActive = false
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-03-01 05:04collazoandy4New Issue
2021-03-01 05:04collazoandy4Assigned To => Retail
2021-03-01 05:04collazoandy4Resolution time => 1615762800
2021-03-01 05:04collazoandy4Triggers an Emergency Pack => No
2021-03-08 06:58ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-03-08 11:11ranjith_qualiantech_comStatusnew => scheduled
2021-03-10 06:58hgbotNote Added: 0126579
2021-03-10 06:59hgbotNote Added: 0126580
2021-03-11 08:11hgbotResolutionopen => fixed
2021-03-11 08:11hgbotStatusscheduled => closed
2021-03-11 08:11hgbotNote Added: 0126609
2021-03-11 08:11hgbotNote Added: 0126610
2021-03-11 08:11hgbotNote Added: 0126611
2021-03-11 08:11hgbotNote Added: 0126612

Notes
(0126579)
hgbot   
2021-03-10 06:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/1 [^]
(0126580)
hgbot   
2021-03-10 06:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/16 [^]
(0126609)
hgbot   
2021-03-11 08:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: a3577d59ee2e6090adf7317416ffa4fc14cb84f4
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-08T18:38:14+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/a3577d59ee2e6090adf7317416ffa4fc14cb84f4 [^]

Fixed ISSUE-45966: Updated FilterQuery to get memberid from inactive subscriptions

---
M src/org/openbravo/retail/loyalty/programs/process/LoyaltySubscriptionsCardLoader.java
M web/org.openbravo.retail.loyalty.programs/js/component/program-selection-popup.js
---
(0126610)
hgbot   
2021-03-11 08:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/16 [^]
(0126611)
hgbot   
2021-03-11 08:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^]
Changeset: 3f914cee6d09c1f5fa72c5cee36f4eccf0dc16f3
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-10T08:38:38+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/3f914cee6d09c1f5fa72c5cee36f4eccf0dc16f3 [^]

Related to ISSUE-45966: Added Eventhandler to validate the Program and Memberid unique status

---
M src-db/database/model/tables/OBLP_SUBSCRIPTION.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/loyalty/programs/eventhandler/SubscriptionEventHandler.java
---
(0126612)
hgbot   
2021-03-11 08:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/1 [^]