Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045965Retail ModulesWeb POSpublic2021-02-27 07:182021-03-24 07:30
Reportercaristu 
Assigned Toranjith_qualiantech_com 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045965: Extract action preparations requesting approvals from the business logic bundle
DescriptionExtract action preparations requesting approvals (for example this one[1]) from the business logic bundle.

This is needed in order to avoid having duplicated approval requests when using the new approvals infrastructure[2]

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddProduct.js#L122 [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/297 [^]
Steps To ReproduceIn description
Proposed SolutionExtract the action preparations which are requesting approvals into separated files which will not be included in the business logic bundle
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-02-27 07:18caristuNew Issue
2021-02-27 07:18caristuAssigned To => Retail
2021-02-27 07:18caristuOBNetwork customer => No
2021-02-27 07:18caristuTriggers an Emergency Pack => No
2021-03-01 10:29ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-03-03 14:25ranjith_qualiantech_comStatusnew => scheduled
2021-03-05 07:08hgbotMerge Request Status => open
2021-03-05 07:08hgbotNote Added: 0126511
2021-03-05 13:54aferrazIssue Monitored: aferraz
2021-03-08 07:36hgbotMerge Request Statusopen => approved
2021-03-08 07:37hgbotResolutionopen => fixed
2021-03-08 07:37hgbotStatusscheduled => closed
2021-03-08 07:37hgbotFixed in Version => RR21Q2
2021-03-08 07:37hgbotNote Added: 0126542
2021-03-08 07:37hgbotNote Added: 0126543
2021-03-22 15:07hgbotNote Added: 0126837
2021-03-24 07:30hgbotNote Added: 0126871
2021-03-24 07:30hgbotNote Added: 0126872

Notes
(0126511)
hgbot   
2021-03-05 07:08   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/337 [^]
(0126542)
hgbot   
2021-03-08 07:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 434b108e22e193e2636b8c951d7f8b778796c45e
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-08T06:36:51+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/434b108e22e193e2636b8c951d7f8b778796c45e [^]

Fixed ISSUE-45965: Moved Approval from BusinessLogic to POS

---
A web/org.openbravo.retail.posterminal/js/actionpreparation/AddProduct.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteLayaway.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicket.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/DeleteLine.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/SetLinePrice.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web-test/model/business-object/ticket/CompleteTicketUtils.test.js
M web-test/model/business-object/ticket/actions/AddProduct-actionPreparation.test.js
M web-test/model/business-object/ticket/actions/DeleteLine-actionPreparation.test.js
M web-test/model/business-object/ticket/actions/SetLinePrice-actionPreparation.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddProduct.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteLayaway.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteLine.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/SetLinePrice.js
---
(0126543)
hgbot   
2021-03-08 07:37   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/337 [^]
(0126837)
hgbot   
2021-03-22 15:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/349 [^]
(0126871)
hgbot   
2021-03-24 07:30   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b2a0fc10042bda23a058dba458e392eb117cb5b7
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-22T15:05:15+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b2a0fc10042bda23a058dba458e392eb117cb5b7 [^]

Related to ISSUE-45965: Renamed ActionPreparations js files for approval actions

---
A web/org.openbravo.retail.posterminal/js/actionpreparation/AddProductApproval.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteLayawayApproval.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketApproval.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/DeleteLineApproval.js
A web/org.openbravo.retail.posterminal/js/actionpreparation/SetLinePriceApproval.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
---
(0126872)
hgbot   
2021-03-24 07:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/349 [^]