Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045959Openbravo ERPA. Platformpublic2021-02-26 11:532021-03-01 09:54
Reporterjarmendariz 
Assigned Tojarmendariz 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045959: ESLint does not evaluate .jsx files by default in React code
DescriptionWith 0045846 we added infrastructure to support React applications in the future.
ESLint CLI by default looks for only all .js files not ignored in the .eslintignore files, so .jsx files are not checked until you pass it explicitly to ESLint (e.g. in git hooks)
Steps To Reproduce- Open any .jsx file
- Add code that introduces an error to the linter, for example:
  const unused = 'unused';

- Run org.openbravo.client.kernel/jslint/jslint
- The introduced error does not appear
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0045846 closed alostale prepare infrastructure to support react applications 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-02-26 11:53jarmendarizNew Issue
2021-02-26 11:53jarmendarizAssigned To => jarmendariz
2021-02-26 11:53jarmendarizModules => Core
2021-02-26 11:53jarmendarizTriggers an Emergency Pack => No
2021-02-26 11:53jarmendarizRelationship addedrelated to 0045846
2021-02-26 11:58hgbotNote Added: 0126373
2021-02-26 15:49hgbotNote Added: 0126374
2021-02-26 15:54hgbotNote Added: 0126375
2021-02-26 15:58hgbotNote Added: 0126376
2021-03-01 09:51hgbotNote Added: 0126410
2021-03-01 09:51hgbotNote Added: 0126411
2021-03-01 09:52jarmendarizStatusnew => scheduled
2021-03-01 09:52hgbotNote Added: 0126412
2021-03-01 09:52hgbotNote Added: 0126413
2021-03-01 09:53hgbotNote Added: 0126414
2021-03-01 09:53hgbotNote Added: 0126415
2021-03-01 09:54hgbotResolutionopen => fixed
2021-03-01 09:54hgbotStatusscheduled => closed
2021-03-01 09:54hgbotFixed in Version => PR21Q2
2021-03-01 09:54hgbotNote Added: 0126416
2021-03-01 09:54hgbotNote Added: 0126417

Notes
(0126373)
hgbot   
2021-02-26 11:58   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/322 [^]
(0126374)
hgbot   
2021-02-26 15:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/263 [^]
(0126375)
hgbot   
2021-02-26 15:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/335 [^]
(0126376)
hgbot   
2021-02-26 15:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.restaurant/-/merge_requests/69 [^]
(0126410)
hgbot   
2021-03-01 09:51   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.restaurant [^]
Changeset: 849b5e48a141b1a4f2defc221b2db86036c510e8
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-03-01T09:04:04+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.restaurant/-/commit/849b5e48a141b1a4f2defc221b2db86036c510e8 [^]

Related to ISSUE-45959: Fixing ESLint issues in jsx files

---
M web-jspack/org.openbravo.retail.restaurant/src/components/TicketMenuLine/TicketMenuInProgressLineItems/TicketMenuInProgressLineItems.jsx
---
(0126411)
hgbot   
2021-03-01 09:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.restaurant/-/merge_requests/69 [^]
(0126412)
hgbot   
2021-03-01 09:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4b9a1838100e505195b215db33bb2ab95fba45e1
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-03-01T09:49:04+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4b9a1838100e505195b215db33bb2ab95fba45e1 [^]

Related to ISSUE-45959: Fixing ESLint issues in jsx files

---
M web-jspack/org.openbravo.pos2/src/components/Drawer/__test__/DrawerDynamicMenuGroup.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductCategoryButton/__test__/ProductCategoryButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TerminalAuthentication/TerminalAuthenticationForm.jsx
M web-jspack/org.openbravo.pos2/src/components/TerminalAuthentication/TerminalAuthenticationScreen.jsx
M web-jspack/org.openbravo.pos2/src/components/TerminalAuthentication/__test__/TerminalAuthenticationForm.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TerminalAuthentication/__test__/TerminalAuthenticationHeader.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TerminalAuthentication/stories/TerminalAuthenticationForm.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/TerminalAuthentication/stories/TerminalAuthenticationHeader.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/TerminalAuthentication/stories/TerminalAuthenticationScreen.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketSummary/__test__/TicketSummary.test.jsx
---
(0126413)
hgbot   
2021-03-01 09:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/263 [^]
(0126414)
hgbot   
2021-03-01 09:53   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: b5fe9d4bef4efdf005f46a0f5c87c45101ffc785
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-03-01T09:02:13+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b5fe9d4bef4efdf005f46a0f5c87c45101ffc785 [^]

Related to ISSUE-45959: Fixing ESLint issues in jsx files

---
M web-jspack/org.openbravo.core2/src/components/StatePropertySwitcher/__test__/StatePropertySwitcher.test.jsx
M web-jspack/org.openbravo.core2/src/components/StateSwitcher/__test__/StateSwitcher.test.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UseEnabledUserAction.test.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UseUserAction.test.jsx
---
(0126415)
hgbot   
2021-03-01 09:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/335 [^]
(0126416)
hgbot   
2021-03-01 09:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: a0c4385059e8f58a47cf5ff4e73bc8901cd75f61
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-02-26T11:55:07+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/a0c4385059e8f58a47cf5ff4e73bc8901cd75f61 [^]

Fixed ISSUE-45959: ESLint will look for jsx files in folders with React code

---
M modules/org.openbravo.client.kernel/eslint-airbnb/eslintrc-airbnb-react.template
---
(0126417)
hgbot   
2021-03-01 09:54   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/322 [^]