Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045928Retail ModulesWeb POSpublic2021-02-19 13:472021-02-24 13:22
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045928: Create new Approval Name column to allow new approval entries without approval property infrastructure
DescriptionA new column(Approval Name) should be added to OBPOS_Order_Approval and OBPOS_Cashup_Approval to allow new entries in this table, without a preference. Previously Approval Type was being used, which has a reference to preferences, and that doesn't allow other infrastructure to create new entries without a preference being present.

Also, those Approval Type and Approval Name columns should not be mandatory. The former should be changed to not be mandatory.
Steps To ReproduceIn description.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0045927 closed cberner API Change: Not mandatory column Approval_Type for OBPOS_Order_Approval and OBPOS_Cashup_Approval 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-02-19 13:47cbernerNew Issue
2021-02-19 13:47cbernerAssigned To => cberner
2021-02-19 13:47cbernerOBNetwork customer => No
2021-02-19 13:47cbernerTriggers an Emergency Pack => No
2021-02-19 13:50hgbotMerge Request Status => open
2021-02-19 13:50hgbotNote Added: 0126218
2021-02-19 14:18hgbotMerge Request Statusopen => approved
2021-02-24 12:21cbernerRelationship addedcauses 0045927
2021-02-24 13:22hgbotResolutionopen => fixed
2021-02-24 13:22hgbotStatusnew => closed
2021-02-24 13:22hgbotFixed in Version => RR21Q2
2021-02-24 13:22hgbotNote Added: 0126350
2021-02-24 13:22hgbotNote Added: 0126351
2021-02-24 13:22hgbotNote Added: 0126352

Notes
(0126218)
hgbot   
2021-02-19 13:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/309 [^]
(0126350)
hgbot   
2021-02-24 13:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ff3492aac2acb3cb16f2c7f68034273997199c07
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-02-24T12:41:27+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ff3492aac2acb3cb16f2c7f68034273997199c07 [^]

Fixes ISSUE-45928: Make approval_type column non-mandatory in Order_Approval table

This column has no need to be mandatory, to allow other forms of
approval, that do not include it.

---
M src-db/database/model/tables/OBPOS_ORDER_APPROVAL.xml
---
(0126351)
hgbot   
2021-02-24 13:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/309 [^]
(0126352)
hgbot   
2021-02-24 13:22   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 401b15b53410db091349ea7a5c51e83b6cc12651
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-02-24T12:50:35+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/401b15b53410db091349ea7a5c51e83b6cc12651 [^]

Related to ISSUE-45928: Add column approval_name to Order approval table

This column is intended to be used by some infrastructure instead of the
previous preference approval_type.

---
M src-db/database/model/tables/OBPOS_ORDER_APPROVAL.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---