Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045890Openbravo ERPA. Platformpublic2021-02-12 07:492021-02-12 10:01
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR21Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045890: ClassLoaderTest fails if a Tomcat filter is added
DescriptionClassLoaderTest fails if a Tomcat filter is added because it cannot be found in the classpath.
Steps To Reproduce1. add org.apache.catalina.filters.ExpiresFilter [1]
2. run ant run.test -Dtest=org.openbravo.test.model.ClassLoaderTest
  -> ERROR org.apache.catalina.filters.ExpiresFilter cannot be found in the classpath

Note when the same is executed in Eclipse works because Tomcat libraries are added to the classpath.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/092339d71ab02caaead795f6312ab19ef21ab53a [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-02-12 07:49alostaleNew Issue
2021-02-12 07:49alostaleAssigned To => platform
2021-02-12 07:49alostaleModules => Core
2021-02-12 07:49alostaleTriggers an Emergency Pack => No
2021-02-12 07:49alostaleAssigned Toplatform => alostale
2021-02-12 07:59hgbotNote Added: 0126085
2021-02-12 10:01hgbotResolutionopen => fixed
2021-02-12 10:01hgbotStatusnew => closed
2021-02-12 10:01hgbotFixed in Version => PR21Q2
2021-02-12 10:01hgbotNote Added: 0126092
2021-02-12 10:01hgbotNote Added: 0126093

Notes
(0126085)
hgbot   
2021-02-12 07:59   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/311 [^]
(0126092)
hgbot   
2021-02-12 10:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 42994805a73c95b0fe2ffcac319d81fd184f1ee2
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-02-12T09:00:54+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/42994805a73c95b0fe2ffcac319d81fd184f1ee2 [^]

fixed ISSUE-45890: ClassLoaderTest fails if a Tomcat filter is added

Tomcat filters (ie. org.apache.catalina.filters.ExpiresFilter) are not
included in the classpath when executing ClassLoaderTesst from CLI. This
makes the test to fail they are included.

Fixed by allowing org.apache.catalina.filters.* classes as filters, note
they are skipped, so it is not guaranteed they actually exist.

---
M src-test/src/org/openbravo/test/model/ClassLoaderTest.java
---
(0126093)
hgbot   
2021-02-12 10:01   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/311 [^]