Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045885Retail ModulesCoupons OTFpublic2021-02-11 14:552021-02-19 08:18
Reportergsuarez 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045885: OTF Rule generate cupons with products that are excluded.
DescriptionWe have a OTF rule with a min amount receipt of 100 and we excluded a product with price greater than 100, so when we do a sales with the excluded product and other product with price minimun than 100, the system generates a coupon. This coupon is wrong, because the total of sales minus the excluded product is not greater than 100.
Steps To Reproduce1. Create a Discount / Promotion with the check Is OTF Coupon.
2. Create a OTF Rule with these fields:
   a. Min Receipt Amount: 100.
   b. Is one coupon per transaction: Unchecked.
   c. Is variable coupon: Unchecked.
   d. Included Organizations: All excluding defined.
   e. Included BP Categories: All excluding defined.
   f. Included Products: All excluding defined.
   g. Included Proucts Categories: All excluding defined
3. In the product tab, add the product Samsung 32'' LED TV with price 192.67.
4. Go to WebPOS and start a sales.
5. Add the product Samsung 32'' LED TV.
6. Add other product with price minimun than 100.
7. Checkout.
8. Check that the coupon was generated.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0045494 closed ranjith_qualiantech_com OTF rules expired continue to generate coupons 
related to defect 0045495 closed prakashmurugesan88 Head settings of OTF rules doesn't work as expected 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-02-11 14:55gsuarezNew Issue
2021-02-11 14:55gsuarezAssigned To => Retail
2021-02-11 14:55gsuarezResolution time => 1581721200
2021-02-11 14:55gsuarezTriggers an Emergency Pack => No
2021-02-11 15:31rafarodaRelationship addedrelated to 0045494
2021-02-11 15:31rafarodaRelationship addedrelated to 0045495
2021-02-11 15:50marvintmResolution time1581721200 => 1613343600
2021-02-12 06:22ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-02-15 11:33ranjith_qualiantech_comStatusnew => scheduled
2021-02-16 06:49hgbotNote Added: 0126115
2021-02-19 08:18hgbotResolutionopen => fixed
2021-02-19 08:18hgbotStatusscheduled => closed
2021-02-19 08:18hgbotNote Added: 0126194
2021-02-19 08:18hgbotNote Added: 0126195

Notes
(0126115)
hgbot   
2021-02-16 06:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/11 [^]
(0126194)
hgbot   
2021-02-19 08:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 7fbf9d6054d0f71ad8b9f09621b0bddd6638012a
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-02-19T07:18:44+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/7fbf9d6054d0f71ad8b9f09621b0bddd6638012a [^]

Fixed ISSUE-45885: Coupon should be created if order amt exceeds defined minimum amount
* If receipt amount exceeds coupon rule amount, then coupon should not be created
* Refactored by removing duplicated logic when creating coupon

---
M web/org.openbravo.retail.discounts.coupons.otf/js/utils.js
---
(0126195)
hgbot   
2021-02-19 08:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/11 [^]