Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0045857 | Retail Modules | Web POS | public | 2021-02-04 16:09 | 2021-02-25 06:52 |
|
| Reporter | ucarrion | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR21Q2 | |
| Merge Request Status | approved |
| Review Assigned To | marvintm |
| OBNetwork customer | Gold |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0045857: Italian Localization - The lottery code popup must not be displayed for return transactions |
| Description | Currently, the lottery code request popup is displayed for the return flows (both verified and blind). Following the functional requirements, this popup should not be displayed in case of blind returns. Also, Claudia (Decathlon Italy) has confirmed that it has neither to be displayed in case of verified returns (maybe that should be corrected on the document) |
| Steps To Reproduce | For the verified returns:
-Login a till
-Add some article
-Press the total amount button
-In the lottery popup, enter some code
-Pay the ticket and complete the transaction
-Select the Verified Returns menu entry
-In the popup, search and select the transaction just completed
-Press the total amount button
-Check that the lottery popup is again displayed
For the blind returns:
-Login a till
-Select the 'Return this receipt' menu entry
-Add some item
-Press the total amount
-In the popup, press cancel
-Check that the lottery popup is displayed
***Note: the Italian Localization must be set into the environment |
| Proposed Solution | What we need:
To save the lottery code entered in the sales transaction in order to persist it in case of verified returns. The lottery popup won't be shown in these transactions.
For the blind returns, the popup is incorrectly displayed currently. Just remove it from this flow (return this receipt - return line) |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | causes | defect | 0046226 | | closed | rqueralta | The Fiscal Reference Document popup info is not infomed in the printed ticket |
|
| Attached Files |  45857_19Q3_DKT_lottery.diff (14,047) 2021-02-24 01:50
https://issues.openbravo.com/file_download.php?file_id=15340&type=bug
45857_19Q3_DKT_rtserver.diff (1,091) 2021-02-24 01:50
https://issues.openbravo.com/file_download.php?file_id=15341&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2021-02-04 16:09 | ucarrion | New Issue | |
| 2021-02-04 16:09 | ucarrion | Assigned To | => Retail |
| 2021-02-04 16:09 | ucarrion | OBNetwork customer | => Gold |
| 2021-02-04 16:09 | ucarrion | Resolution time | => 1614553200 |
| 2021-02-04 16:09 | ucarrion | Triggers an Emergency Pack | => No |
| 2021-02-05 13:50 | psanjuan | Issue Monitored: psanjuan | |
| 2021-02-08 08:59 | ucarrion | Issue Monitored: ucarrion | |
| 2021-02-08 09:40 | psanjuan | Note Added: 0126021 | |
| 2021-02-17 03:41 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2021-02-17 08:51 | ranjith_qualiantech_com | Status | new => scheduled |
| 2021-02-22 06:38 | hgbot | Merge Request Status | => open |
| 2021-02-22 06:38 | hgbot | Note Added: 0126235 | |
| 2021-02-22 06:38 | hgbot | Note Added: 0126236 | |
| 2021-02-22 07:45 | hgbot | Merge Request Status | open => approved |
| 2021-02-22 07:45 | hgbot | Note Added: 0126241 | |
| 2021-02-22 07:45 | hgbot | Note Added: 0126242 | |
| 2021-02-22 07:45 | hgbot | Resolution | open => fixed |
| 2021-02-22 07:45 | hgbot | Status | scheduled => closed |
| 2021-02-22 07:45 | hgbot | Note Added: 0126243 | |
| 2021-02-22 07:45 | hgbot | Note Added: 0126244 | |
| 2021-02-23 12:44 | ucarrion | Note Added: 0126300 | |
| 2021-02-23 12:44 | ucarrion | Status | closed => new |
| 2021-02-23 12:44 | ucarrion | Resolution | fixed => open |
| 2021-02-23 12:45 | ucarrion | Note Added: 0126301 | |
| 2021-02-24 01:50 | ranjith_qualiantech_com | File Added: 45857_19Q3_DKT_lottery.diff | |
| 2021-02-24 01:50 | ranjith_qualiantech_com | File Added: 45857_19Q3_DKT_rtserver.diff | |
| 2021-02-24 08:43 | ucarrion | Note Added: 0126312 | |
| 2021-02-25 06:51 | marvintm | Status | new => scheduled |
| 2021-02-25 06:51 | marvintm | Status | scheduled => resolved |
| 2021-02-25 06:51 | marvintm | Fixed in Version | => RR21Q2 |
| 2021-02-25 06:51 | marvintm | Resolution | open => fixed |
| 2021-02-25 06:52 | marvintm | Review Assigned To | => marvintm |
| 2021-02-25 06:52 | marvintm | Note Added: 0126363 | |
| 2021-02-25 06:52 | marvintm | Status | resolved => closed |
| 2021-04-14 17:04 | ucarrion | Relationship added | causes 0046226 |
|
Notes |
|
|
|
Proposed solution:
1.- Save the lottery code entered in each sales transaction.
This lottery code is entered in the lottery code pop-up. Once entered it has to be saved in the corresponding sales transaction, therefore a new field will have to be created to get that.
2.- In the case of a return (either blind or verified), the lottery code pop-up must NOT be shown in any case.
3.- For verified returns, the lottery code will be the one entered in the "original" transaction, which now must be retrieved.
4.- It will not be possible to add any lottery code in case of booking a blind return. |
|
|
|
(0126235)
|
|
hgbot
|
|
2021-02-22 06:38
|
|
|
|
|
(0126236)
|
|
hgbot
|
|
2021-02-22 06:38
|
|
|
|
|
(0126241)
|
|
hgbot
|
|
2021-02-22 07:45
|
|
|
|
|
(0126242)
|
|
hgbot
|
|
2021-02-22 07:45
|
|
|
|
|
(0126243)
|
|
hgbot
|
|
2021-02-22 07:45
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.lotterycode [^]
Changeset: 35b6d71ca7480ac73faacff3deb33cacae32966d
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-02-22T12:09:14+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.lotterycode/-/commit/35b6d71ca7480ac73faacff3deb33cacae32966d [^]
Fixed ISSUE-45857: LotteryCode added to Order when completing ticket
* New column lotteryCode added to c_order
* When doing verified return with lotterycode, receipt should be updated with lotterycode
---
A src-db/database/model/modifiedTables/C_ORDER.xml
A src-db/database/sourcedata/AD_COLUMN.xml
A src-db/database/sourcedata/AD_ELEMENT.xml
A src/org/openbravo/retail/lotterycode/PaidReceiptProperties.java
A web/org.openbravo.retail.lotterycode/js/hooks/oblotc-returnorderhook.js
M src/org/openbravo/retail/lotterycode/OBLOTCComponentProvider.java
M web/org.openbravo.retail.lotterycode/js/components/oblotc-modallotterycodeinformation.js
M web/org.openbravo.retail.lotterycode/js/hookUtils/oblotc-getlotterycode.js
---
|
|
|
|
(0126244)
|
|
hgbot
|
|
2021-02-22 07:45
|
|
|
|
|
|
|
An unexpected javascript error is displayed now when pressing the total amount. This was not reproduced before the fix. |
|
|
|
|
Uncaught TypeError: this.$.body.$.lotteryCodeContainer.coreElement.setValue is not a function
at Object.executeOnShow (e6741171ba7210bf5e78ad078b5569b5.js:4825)
at Object.show (e6741171ba7210bf5e78ad078b5569b5.js:638)
at Object.showPopup (e6741171ba7210bf5e78ad078b5569b5.js:708)
at Object.showPopupHandler (e6741171ba7210bf5e78ad078b5569b5.js:706)
at Object.dispatch (enyo.js:628)
at Object.dispatchEvent (enyo.js:612)
at Object.enyo.kind.inherited (enyo.js:410)
at Object.dispatchEvent (enyo.js:1338)
at Object.dispatchBubble (enyo.js:616)
at Object.bubbleUp (enyo.js:608) |
|
|
|
|
|
|
|
|
|
Problems were related to the backport applied to the customer environment, not to the fix in master. |
|