Openbravo Issue Tracking System - Retail Modules
View Issue Details
0045829Retail ModulesGift cards and gift voucherspublic2021-02-01 21:502021-03-09 16:08
wicherr 
rqueralta 
normalmajorhave not tried
closedfixed 
5
 
RR20Q3.1 
No
0045829: Display and usage of gift cards / gift certificates and credit notes
Hello Team,

I'll take the gift cards for example but it's the same for gift certificates and credit notes.

For gift cards usage/research, we have only 1 preference : "Web POS Forbid use Gift Card with different gift card owner"

Currently, if I put the preference "Web POS Forbid use Gift Card with different gift card owner" to "Y". I expect that gift cards are NOT supposed to be used by someone else than the owner.
In fact, this is what happens :
- I'm able to use a gift card owned by a specific customer if he's the owner
- I'm able to use a gift card created which my customer is the owner or the owner is nobody

if I put the preference "Web POS Forbid use Gift Card with different gift card owner" to "N", I expect that gift cards are supposed to be used by the owner and no one else.
- I'm able ONLY to see and pay with gift cards assigned to the customer who bought it (not specially the owner - If I put a different owner from the customer who buy it, he (the owner) can't see the card)


=> First, the preferences are not clear and are not working as they are supposed to work.
=> Second, we miss an option to hide the gift cards without any owner or the owner is the anonymous customer
Try with different values of the preference, with gift cards bought by different customers :

- On webPOS, select a customer
- Go on customer details
- click on the gift card and credit notes button
- try different searches
"Web POS Forbid use Gift Card with different gift card owner" should work with the owner only and not the purchaser. It means :
- 'Y' -> I can't use a gift card if the customer assigned to the ticket is not the owner of the gift card or the purchaser
- 'N' -> I can use a gift card even if the customer assigned to the ticket is not the owner of the gift card or the purchaser


We should have a new preference : "Web POS - customer restriction for gift cards list display" or whatever
- if value = 'Y' ->
         - If I don't put any gift card number in the GC search and click on the magnifier. I only see gift cards which have been bought or which are owned by the customer assigned (not by other customers or anonymous customer).
         - If I put a gift card number in the GC search and click on the magnifier, I can see and use the gift card regarding the preference "Web POS Forbid use Gift Card with different gift card owner"


- If value = 'N' -> Same behavior than current


The same features should be fixed for credit notes and gift certificates.


We can discuss if needed.
NOR
has duplicate defect 0046246 closed ranjith_qualiantech_com search filter credit notes or gift card 
Issue History
2021-02-01 21:50wicherrNew Issue
2021-02-01 21:50wicherrAssigned To => Retail
2021-02-01 21:50wicherrTriggers an Emergency Pack => No
2021-02-01 21:51wicherrTag Attached: NOR
2021-02-01 21:51wicherrTag Attached: NORAUTO
2021-02-03 16:53rafarodaTag Detached: NORAUTO
2021-02-03 16:54rafarodaResolution time => 1613862000
2021-02-05 04:33rqueraltaAssigned ToRetail => rqueralta
2021-02-05 04:35rqueraltaStatusnew => scheduled
2021-02-22 04:14hgbotNote Added: 0126232
2021-02-23 00:40hgbotNote Added: 0126282
2021-02-26 18:52hgbotNote Added: 0126382
2021-03-01 17:57hgbotNote Added: 0126431
2021-03-02 11:54hgbotNote Added: 0126471
2021-03-05 09:51hgbotNote Added: 0126515
2021-03-05 09:51hgbotResolutionopen => fixed
2021-03-05 09:51hgbotStatusscheduled => closed
2021-03-05 09:51hgbotNote Added: 0126516
2021-03-09 02:41hgbotNote Added: 0126557
2021-03-09 16:08hgbotNote Added: 0126569
2021-03-09 16:08hgbotNote Added: 0126570
2021-04-26 09:32ranjith_qualiantech_comRelationship addedrelated to 0046246
2021-04-27 08:01marvintmRelationship replacedhas duplicate 0046246

Notes
(0126232)
hgbot   
2021-02-22 04:14   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/40 [^]
(0126282)
hgbot   
2021-02-23 00:40   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/40 [^]
(0126382)
hgbot   
2021-02-26 18:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/42 [^]
(0126431)
hgbot   
2021-03-01 17:57   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/42 [^]
(0126471)
hgbot   
2021-03-02 11:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/43 [^]
(0126515)
hgbot   
2021-03-05 09:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/43 [^]
(0126516)
hgbot   
2021-03-05 09:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: c208e8700afe95ace1bc8d18a1004ab161c8cf3c
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-03-05T08:50:36+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/c208e8700afe95ace1bc8d18a1004ab161c8cf3c [^]

Fixed BUG-45829: Renamed Web POS Forbid use Gift Card with different gift card owner. Also was added a new preference Web POS Show gift cards owned or bought by current customer to show only gift cards for which either the business partner field, or the owner, corresponds to the currently selected business partner.

---
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/giftcards/FindGiftCards.java
M src/org/openbravo/retail/giftcards/ListGiftCard.java
M web/org.openbravo.retail.giftcards/js/components/GiftCardDialog.js
M web/org.openbravo.retail.giftcards/js/components/GiftCardSearchDialog.js
---
(0126557)
hgbot   
2021-03-09 02:41   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/74 [^]
(0126569)
hgbot   
2021-03-09 16:08   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/74 [^]
(0126570)
hgbot   
2021-03-09 16:08   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: dfc60055963e026ba0b9e61f19d205f26700aba5
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-03-09T07:07:25+05:30
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/dfc60055963e026ba0b9e61f19d205f26700aba5 [^]

Verifies ISSUE-45829: Updated test CreateGiftCertificateWithApproval
* Updated Approval for creating gift certificate

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/CreateGiftCertificateWithApproval.java
---