Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045809POS2POSpublic2021-01-29 09:112021-02-03 17:01
Reporterguilleaer 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045809: POS2 should use POS2 as appName in requests. This AppName should be used to avoid initial validations execution
DescriptionPOS2 should use POS2 as appName in requests instead of POS.

Initial validations should have a mechanism to avoid execution based on appName
Steps To ReproduceLogin in old web POS without schema

customInitialValidations coming from POS2 are executed (schemas existance validation). This does not make sense since schemas is unknow for web POS
Proposed Solutionattached patch with all improvemnts.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0045841 closed ranjith_qualiantech_com Retail Modules API change: the validateTerminal method in the InitialValidations.java class needs to be changed to support multiple apps 
related to defect 0047940 closed alostale Retail Modules CustomInitialValidations are not filtered by application 
Attached Filesdiff pos2InitialValidations.diff (5,346) 2021-01-29 09:38
https://issues.openbravo.com/file_download.php?file_id=15288&type=bug
diff customValidationImprovementsUsingAppName.diff (2,283) 2021-01-29 09:38
https://issues.openbravo.com/file_download.php?file_id=15289&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-01-29 09:11guilleaerNew Issue
2021-01-29 09:11guilleaerAssigned To => Retail
2021-01-29 09:11guilleaerOBNetwork customer => No
2021-01-29 09:11guilleaerTriggers an Emergency Pack => No
2021-01-29 09:38guilleaerFile Added: pos2InitialValidations.diff
2021-01-29 09:38guilleaerFile Added: customValidationImprovementsUsingAppName.diff
2021-01-29 09:48guilleaerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22089#r22089
2021-01-29 09:48guilleaerProposed Solution updated
2021-01-29 13:48alostaleNote Added: 0125864
2021-01-31 13:44ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2021-02-01 06:25ranjith_qualiantech_comStatusnew => scheduled
2021-02-02 08:04hgbotMerge Request Status => open
2021-02-02 08:04hgbotNote Added: 0125936
2021-02-02 13:07hgbotNote Added: 0125944
2021-02-03 16:32hgbotMerge Request Statusopen => approved
2021-02-03 16:39marvintmRelationship addedrelated to 0045841
2021-02-03 17:01hgbotResolutionopen => fixed
2021-02-03 17:01hgbotStatusscheduled => closed
2021-02-03 17:01hgbotFixed in Version => RR21Q2
2021-02-03 17:01hgbotNote Added: 0125958
2021-02-03 17:01hgbotNote Added: 0125959
2021-02-03 17:01hgbotNote Added: 0125960
2021-02-03 17:01hgbotNote Added: 0125961
2021-10-27 10:13alostaleRelationship addedrelated to 0047940

Notes
(0125864)
alostale   
2021-01-29 13:48   
The platform part to rename the application is implemented in this FR, ob-config part chunk in the attached diff shouldn't be applied:

https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/259 [^]
(0125936)
hgbot   
2021-02-02 08:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/283 [^]
(0125944)
hgbot   
2021-02-02 13:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/189 [^]
(0125958)
hgbot   
2021-02-03 17:01   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8c23cb8dcb78968634a24382981dd173b580f1d1
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-02-03T15:33:24+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8c23cb8dcb78968634a24382981dd173b580f1d1 [^]

Fixed ISSUE-45809 : Added method to check the execution of Custom Validation

---
M src/org/openbravo/retail/posterminal/CustomInitialValidation.java
M src/org/openbravo/retail/posterminal/InitialValidations.java
---
(0125959)
hgbot   
2021-02-03 17:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/283 [^]
(0125960)
hgbot   
2021-02-03 17:01   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d211b6a45b014f1a2b0cde71ce8fd5b01a42937c
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-02-03T15:33:41+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d211b6a45b014f1a2b0cde71ce8fd5b01a42937c [^]

Related to ISSUE-45809: Added check to execute the InitialValidation from CustomValidation

---
M src/org/openbravo/pos2/POS2Constants.java
M src/org/openbravo/pos2/login/POS2InitialValidations.java
M src/org/openbravo/pos2/login/POS2LoginUtilsServlet.java
---
(0125961)
hgbot   
2021-02-03 17:01   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/189 [^]