Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045765Openbravo LocalizationsLocalization Portugalpublic2021-01-20 14:512021-09-10 14:18
Reportergsuarez 
Assigned Topsanjuan 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Support ticket
OBNetwork customer
Regression introduced in release
Summary0045765: Limit location field in Customer to 50 characters - SAFT
DescriptionWhen validating the SAF-T file from Portugal, an error occurred in a bussiness partner because the location (town) has more than 50 characters.
Steps To ReproduceMake a sales on a WebPOS configurated with SAFT functionality selecting a business partner that have a location with more than 50 characters.

We need to stop the sales when the system identifies a location has more than 50 characters.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff saftptCity.diff (2,452) 2021-09-01 14:26
https://issues.openbravo.com/file_download.php?file_id=16165&type=bug
Issue History
Date ModifiedUsernameFieldChange
2021-01-20 14:51gsuarezNew Issue
2021-01-20 14:51gsuarezAssigned To => Xpand-IT
2021-01-20 14:51gsuarezResolution time => 1581289200
2021-02-17 11:54lbressanNote Added: 0126138
2021-02-17 16:18egoitzResolution time1581289200 => 1582153200
2021-02-17 16:18egoitzAssigned ToXpand-IT => Triage Finance
2021-02-17 18:01psanjuanNote Added: 0126145
2021-02-23 13:13vmromanosStatusnew => acknowledged
2021-03-12 13:09psanjuanAssigned ToTriage Finance => psanjuan
2021-03-23 11:09psanjuanNote Added: 0126847
2021-08-23 10:28aferrazResolution time1582153200 => 1613775600
2021-08-24 09:00vmromanosStatusacknowledged => scheduled
2021-08-24 09:59psanjuanNote Added: 0131285
2021-09-01 14:26psanjuanNote Added: 0131488
2021-09-01 14:26psanjuanFile Added: saftptCity.diff
2021-09-09 16:12hgbotNote Added: 0131680
2021-09-09 16:17hgbotNote Added: 0131681
2021-09-09 16:21hgbotNote Added: 0131682
2021-09-09 16:21hgbotResolutionopen => fixed
2021-09-09 16:21hgbotStatusscheduled => resolved
2021-09-09 16:21hgbotNote Added: 0131683
2021-09-09 16:21hgbotNote Added: 0131684
2021-09-09 16:22hgbotNote Added: 0131685
2021-09-09 16:22hgbotNote Added: 0131686
2021-09-09 16:22hgbotNote Added: 0131687
2021-09-09 16:22hgbotNote Added: 0131688
2021-09-10 14:18hgbotNote Added: 0131707
2021-09-10 14:18hgbotStatusresolved => closed
2021-09-10 14:18hgbotNote Added: 0131708
2021-09-10 14:18hgbotNote Added: 0131709

Notes
(0126138)
lbressan   
2021-02-17 11:54   
anyone update?
(0126145)
psanjuan   
2021-02-17 18:01   
Reported
http://practicsbs.zendesk.com/hc/requests/7124 [^]
(0126847)
psanjuan   
2021-03-23 11:09   
Reported once again
http://practicsbs.zendesk.com/hc/requests/7771 [^]
(0131285)
psanjuan   
2021-08-24 09:59   
https://practicsbs.zendesk.com/hc/es/requests/10869 [^]
(0131488)
psanjuan   
2021-09-01 14:26   
Respuesta de Practics.
Buenas tardes Patricia,

Hemos revisado todos los campos City que puede haber en el fichero E-Fatura, y hemos limitado su contenido a 50 caracteres para que no aparezca dicho error en el validador.

La opción escogida ha sido la de comprobar si la longitud de la "ciudad" es superior a 50 caracteres, y en caso afirmativo, usar los primeros 50 caracteres para rellenar el campo.

Es la misma lógica que hemos aplicado en otros campos que nos daban el mismo error.

Os dejo el DIFF adjunto para que podáis aplicar los cambios en vuestro repositorio. El diff debe aplicarse en el path: .../modules/com.practicsbs.saftpt

Gracias,

Atentamente
(0131680)
hgbot   
2021-09-09 16:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/13 [^]
(0131681)
hgbot   
2021-09-09 16:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/14 [^]
(0131682)
hgbot   
2021-09-09 16:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/15 [^]
(0131683)
hgbot   
2021-09-09 16:21   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: c35cad7480b453d326952409de45109abd9b05ba
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-09-09T16:16:03+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/c35cad7480b453d326952409de45109abd9b05ba [^]

Fixed ISSUE-45765: Limit city to 50 characters

In the places where a city is set, we make sure the length is always <= 50

Patch created by Practis and adapted to new versions by VMA

---
M src/com/practicsbs/saftpt/data/ExportHeader.java
M src/com/practicsbs/saftpt/data/ExportMFSupplier.java
M src/com/practicsbs/saftpt/data/Utils.java
---
(0131684)
hgbot   
2021-09-09 16:21   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/14 [^]
(0131685)
hgbot   
2021-09-09 16:22   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: bef73a95134970c6f937c0e7a69e0a88be91733f
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-09-09T16:20:18+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/bef73a95134970c6f937c0e7a69e0a88be91733f [^]

Fixed ISSUE-45765: Limit city to 50 characters

In the places where a city is set, we make sure the length is always <= 50

Patch created by Practis and adapted to new versions by VMA

---
M src/com/practicsbs/saftpt/data/ExportHeader.java
M src/com/practicsbs/saftpt/data/ExportMFSupplier.java
M src/com/practicsbs/saftpt/data/Utils.java
---
(0131686)
hgbot   
2021-09-09 16:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/15 [^]
(0131687)
hgbot   
2021-09-09 16:22   
Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: 2ab3ef1c660f1bb73e3ab4d2f4e34f2ea2427556
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-09-09T16:05:08+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/2ab3ef1c660f1bb73e3ab4d2f4e34f2ea2427556 [^]

Fixed ISSUE-45765: Limit city to 50 characters

In the places where a city is set, we make sure the length is always <= 50

Patch created by Practis and adapted to new versions by VMA

---
M src/com/practicsbs/saftpt/data/ExportHeader.java
M src/com/practicsbs/saftpt/data/ExportMFSupplier.java
M src/com/practicsbs/saftpt/data/Utils.java
---
(0131688)
hgbot   
2021-09-09 16:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/13 [^]
(0131707)
hgbot   
2021-09-10 14:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/16 [^]
(0131708)
hgbot   
2021-09-10 14:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: df7fcaaf3b85ef22d744412b1da5d7840b9599f5
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-09-10T14:15:55+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/df7fcaaf3b85ef22d744412b1da5d7840b9599f5 [^]

Fixed ISSUE-45765: Limit city to 50 characters

In the places where a city is set, we make sure the length is always <= 50

Patch created by Practis

---
M src/com/practicsbs/saftpt/data/ExportHeader.java
M src/com/practicsbs/saftpt/data/ExportMFSupplier.java
M src/com/practicsbs/saftpt/data/Utils.java
---
(0131709)
hgbot   
2021-09-10 14:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/16 [^]