Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045745Openbravo ERPA. Platformpublic2021-01-18 17:532021-01-19 10:41
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusmerged
Review Assigned Tojarmendariz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045745: Fix missing ESLint issues in modules
DescriptionAfter 0045516, there are some modules which still has linting issues that needs to be fixed.
Steps To ReproduceIn a environment with the modules contained in merge.json, run the jslint script.
The following modules has errors:

- org.openbravo.module.remittance
- org.openbravo.paymentgateway.elementps
- org.openbravo.retail.checkpayment
- org.openbravo.retail.fiscalprinters
- org.openbravo.retail.paymentgateway
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0045516 closed jarmendariz Upgrade ESLint and Jest to its latest version 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-01-18 17:53jarmendarizNew Issue
2021-01-18 17:53jarmendarizAssigned To => platform
2021-01-18 17:53jarmendarizOBNetwork customer => No
2021-01-18 17:53jarmendarizModules => Core
2021-01-18 17:53jarmendarizTriggers an Emergency Pack => No
2021-01-18 17:53jarmendarizRelationship addedrelated to 0045516
2021-01-18 17:53jarmendarizStatusnew => scheduled
2021-01-18 17:53jarmendarizAssigned Toplatform => jarmendariz
2021-01-18 20:25hgbotMerge Request Status => open
2021-01-18 20:25hgbotNote Added: 0125532
2021-01-18 20:25hgbotNote Added: 0125533
2021-01-18 20:25hgbotMerge Request Statusopen => merged
2021-01-18 20:25hgbotNote Added: 0125534
2021-01-18 21:03hgbotNote Added: 0125535
2021-01-18 21:03hgbotResolutionopen => fixed
2021-01-18 21:03hgbotStatusscheduled => resolved
2021-01-18 21:03hgbotNote Added: 0125536
2021-01-18 21:03hgbotNote Added: 0125537
2021-01-18 21:04hgbotNote Added: 0125538
2021-01-18 21:04hgbotNote Added: 0125539
2021-01-18 21:04hgbotNote Added: 0125540
2021-01-18 21:05hgbotNote Added: 0125541
2021-01-18 21:06hgbotNote Added: 0125542
2021-01-18 21:06hgbotNote Added: 0125543
2021-01-18 21:07hgbotNote Added: 0125544
2021-01-18 21:07hgbotNote Added: 0125545
2021-01-18 21:07hgbotNote Added: 0125546
2021-01-19 10:34hgbotNote Added: 0125639
2021-01-19 10:41jarmendarizReview Assigned To => jarmendariz
2021-01-19 10:41jarmendarizStatusresolved => closed

Notes
(0125532)
hgbot   
2021-01-18 20:25   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/1 [^]
(0125533)
hgbot   
2021-01-18 20:25   
Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance [^]
Changeset: 889574c38be76bcd5e9ac2d109a2d8fab6959406
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-01-18T20:24:43+01:00
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/commit/889574c38be76bcd5e9ac2d109a2d8fab6959406 [^]

Related to ISSUE-45745: Fixing missing ESLint errors

---
M web/org.openbravo.module.remittance/js/ob-rem-utilities.js
---
(0125534)
hgbot   
2021-01-18 20:25   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/1 [^]
(0125535)
hgbot   
2021-01-18 21:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.paymentgateway.elementps/-/merge_requests/1 [^]
(0125536)
hgbot   
2021-01-18 21:03   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.paymentgateway.elementps [^]
Changeset: b757936d8e6842c53f3ce6ecf682f5c4b6c11b17
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-01-18T21:02:41+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.paymentgateway.elementps/-/commit/b757936d8e6842c53f3ce6ecf682f5c4b6c11b17 [^]

Fixed ISSUE-45745: Fixed missing ESLint errors

---
M web/org.openbravo.paymentgateway.elementps/js/creditcardcredit.js
M web/org.openbravo.paymentgateway.elementps/js/creditcardreturn.js
M web/org.openbravo.paymentgateway.elementps/js/creditcardsale.js
M web/org.openbravo.paymentgateway.elementps/js/elementpscommon.js
M web/org.openbravo.paymentgateway.elementps/js/hostedpayments.js
---
(0125537)
hgbot   
2021-01-18 21:03   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.paymentgateway.elementps/-/merge_requests/1 [^]
(0125538)
hgbot   
2021-01-18 21:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.checkpayment/-/merge_requests/4 [^]
(0125539)
hgbot   
2021-01-18 21:04   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.checkpayment [^]
Changeset: f9ebaa18a5c436cbdcd3f6ad8e8681a66d4b37e9
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-01-18T21:04:14+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.checkpayment/-/commit/f9ebaa18a5c436cbdcd3f6ad8e8681a66d4b37e9 [^]

Fixed ISSUE-45745: Fixed missing ESLint errors

---
M web/org.openbravo.retail.checkpayment/js/check-provider-void.js
M web/org.openbravo.retail.checkpayment/js/check-provider.js
---
(0125540)
hgbot   
2021-01-18 21:04   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.checkpayment/-/merge_requests/4 [^]
(0125541)
hgbot   
2021-01-18 21:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.fiscalprinters/-/merge_requests/1 [^]
(0125542)
hgbot   
2021-01-18 21:06   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.fiscalprinters [^]
Changeset: b002ff9cce9cc48c4585531ee4da89ebda852f9b
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-01-18T21:05:15+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.fiscalprinters/-/commit/b002ff9cce9cc48c4585531ee4da89ebda852f9b [^]

Fixed ISSUE-45745: Fixed missing ESLint errors

---
M web/org.openbravo.retail.fiscalprinters/js/model/FiscalTaxes.js
---
(0125543)
hgbot   
2021-01-18 21:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.fiscalprinters/-/merge_requests/1 [^]
(0125544)
hgbot   
2021-01-18 21:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.paymentgateway/-/merge_requests/1 [^]
(0125545)
hgbot   
2021-01-18 21:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.paymentgateway [^]
Changeset: d55f8f7b986d3e24c9a0aa2f8808da8d16da6d0c
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-01-18T18:30:37+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.paymentgateway/-/commit/d55f8f7b986d3e24c9a0aa2f8808da8d16da6d0c [^]

Fixed ISSUE-45745: Fix missing ESLint issues in modules

---
M web/org.openbravo.retail.paymentgateway/js/paymentprovider.js
---
(0125546)
hgbot   
2021-01-18 21:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.paymentgateway/-/merge_requests/1 [^]
(0125639)
hgbot   
2021-01-19 10:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 3c87beebe965e866ade9f8f8205a9912472714f4
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-01-19T10:31:39+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/3c87beebe965e866ade9f8f8205a9912472714f4 [^]

Related to ISSUE-45745: Fix missing ESLint issues

---
M web-jspack/org.openbravo.core2/package-part.json
M web-jspack/org.openbravo.core2/src/core/AppInitializer.js
M web-jspack/org.openbravo.core2/src/core/authentication/InitializeAppData.js
M web-jspack/org.openbravo.core2/src/core/authentication/RestoreSession.js
M web-jspack/org.openbravo.core2/src/storybook/module-paths.js
---