Openbravo Issue Tracking System - Retail Modules
View Issue Details
0045736Retail ModulesSelfcheckoutpublic2021-01-15 08:452021-01-28 18:37
lmonreal 
rqueralta 
urgentmajoralways
closedfixed 
5
 
RR21Q2 
approved
Gold
No
0045736: Approval not displayed in SCO when discount out of range is applied
If I have matrix discount configured and I apply a discount outside range in WEBPOS when I switch to SCO nothing stops me to complete the action, there is no approval.

Flow is different in WEBPOS (where approval is shown) that in SCO.
Prerequ: Discount Matrix preference approval configured and % defined in Role of the Casier

1. Login with Cashier in WEBPOS and add product
2. Add a manual discount outside of the cashier range
3. Go to SCO
4. Complete payment

-->See no approval is displayed in SCO or nothing stops me for applying this discount outside of range.

Video of Livebuilds: https://drive.google.com/file/d/1gKzUX2tKvVXR4OCysz1S3aZ3Arv4jSmJ/view [^]

Approval to be displayed in SCO
No tags attached.
patch Fixed BUG-45736-Discount Matrix.patch (8,498) 2021-01-28 18:37
https://issues.openbravo.com/file_download.php?file_id=15287&type=bug
Issue History
2021-01-15 08:45lmonrealNew Issue
2021-01-15 08:45lmonrealAssigned To => Retail
2021-01-15 08:45lmonrealOBNetwork customer => Gold
2021-01-15 08:45lmonrealResolution time => 1580511600
2021-01-15 08:45lmonrealTriggers an Emergency Pack => No
2021-01-15 08:49lmonrealSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22039#r22039
2021-01-18 06:35marvintmResolution time1580511600 => 1612134000
2021-01-18 17:21rqueraltaAssigned ToRetail => rqueralta
2021-01-18 17:21rqueraltaStatusnew => scheduled
2021-01-25 06:59hgbotMerge Request Status => open
2021-01-25 06:59hgbotNote Added: 0125743
2021-01-25 06:59hgbotNote Added: 0125744
2021-01-26 07:53hgbotMerge Request Statusopen => approved
2021-01-26 07:53hgbotResolutionopen => fixed
2021-01-26 07:53hgbotStatusscheduled => closed
2021-01-26 07:53hgbotNote Added: 0125769
2021-01-26 07:53hgbotNote Added: 0125770
2021-01-26 07:53hgbotFixed in Version => RR21Q2
2021-01-26 07:53hgbotNote Added: 0125771
2021-01-26 07:53hgbotNote Added: 0125772
2021-01-28 18:37rqueraltaFile Added: Fixed BUG-45736-Discount Matrix.patch

Notes
(0125743)
hgbot   
2021-01-25 06:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/-/merge_requests/3 [^]
(0125744)
hgbot   
2021-01-25 06:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/136 [^]
(0125769)
hgbot   
2021-01-26 07:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement [^]
Changeset: 0d0833eb20cecdb638385638ef08f697e93d92f1
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-01-24T15:18:06-05:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/-/commit/0d0833eb20cecdb638385638ef08f697e93d92f1 [^]

Fixed BUG-45736: Added approval for discount matrix before navigate to Selfcheckout

---
M web/org.openbravo.retail.discounts.discountmatrixmanagement/js/hookRoleDiscounts.js
---
(0125770)
hgbot   
2021-01-26 07:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/-/merge_requests/3 [^]
(0125771)
hgbot   
2021-01-26 07:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: dd1dea623d8b65b660fa59b93c454f89c008a4d8
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-01-24T22:37:03-05:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/dd1dea623d8b65b660fa59b93c454f89c008a4d8 [^]

Fixed BUG-45736: Checked if inEvent.key is undefined

---
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
---
(0125772)
hgbot   
2021-01-26 07:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/136 [^]