Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045680Retail ModulesWeb POSpublic2021-01-05 12:302021-01-13 09:50
Reporteraferraz 
Assigned ToRetail 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR21Q2Fixed in VersionRR21Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2020-08-19
Regression introduced in releaseRR20Q4
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/06f59cc239c2141539b424a1b9bc4b1ae78649ae [^]
Triggers an Emergency PackNo
Summary0045680: Delete ticket from cashup window doesn't delete the correct ticket
DescriptionDelete ticket from cashup window doesn't delete the correct ticket
Steps To Reproduce- Login in POS.
- Create new ticket with 1 unit of Adhesive body warmers classic. Amount: 5.
- Create new ticket with 1 unit of Balaclava cap. Amount: 169.
- Click on Menu - Cash Up
- Click on Delete button on the ticket with amount 5 and confirm.
- Realize cashup window shows ticket with amount 169 remains created.
- Click on Cancel.
- Realize the ticket deleted was the one with amount 169 instead of the one with amount 5.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0045696RR21Q1 closed Retail Delete ticket from cashup window doesn't delete the correct ticket 
depends on backport 0045697RR20Q4.1 closed Retail Delete ticket from cashup window doesn't delete the correct ticket 
has duplicate defect 0045692 closed ranjith_qualiantech_com Make a Cashup with draft ticket duplicate the call to OrderLoader 
related to defect 0045698RR21Q2 closed aferraz Set terminal organization inside deleteTicket action 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-01-05 12:30aferrazNew Issue
2021-01-05 12:30aferrazAssigned To => Retail
2021-01-05 12:30aferrazOBNetwork customer => No
2021-01-05 12:30aferrazRegression level => Production - QA Approved
2021-01-05 12:30aferrazRegression introduced in release => RR20Q4
2021-01-05 12:30aferrazTriggers an Emergency Pack => No
2021-01-05 12:30aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=22013#r22013
2021-01-05 12:47aferrazRegression date => 2020-08-19
2021-01-05 12:47aferrazRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/06f59cc239c2141539b424a1b9bc4b1ae78649ae [^]
2021-01-07 11:23hgbotMerge Request Status => open
2021-01-07 11:23hgbotNote Added: 0125284
2021-01-07 16:55aferrazStatusnew => scheduled
2021-01-07 16:57aferrazProposed Solution updated
2021-01-07 16:59aferrazRelationship addedrelated to 0045698
2021-01-08 13:09aferrazRelationship addedrelated to 0045705
2021-01-08 15:40aferrazNote Added: 0125337
2021-01-13 09:06hgbotMerge Request Statusopen => approved
2021-01-13 09:50hgbotResolutionopen => fixed
2021-01-13 09:50hgbotStatusscheduled => closed
2021-01-13 09:50hgbotNote Added: 0125406
2021-01-13 09:50hgbotFixed in Version => RR21Q2
2021-01-13 09:50hgbotNote Added: 0125407
2021-01-13 09:50hgbotNote Added: 0125408
2021-01-13 09:50hgbotNote Added: 0125409
2021-01-13 09:50hgbotNote Added: 0125410
2021-01-13 09:50hgbotNote Added: 0125411
2021-01-13 09:50hgbotNote Added: 0125412
2021-01-18 11:18ranjith_qualiantech_comRelationship addedrelated to 0045692
2021-01-20 11:09marvintmRelationship replacedhas duplicate 0045692

Notes
(0125284)
hgbot   
2021-01-07 11:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/244 [^]
(0125337)
aferraz   
2021-01-08 15:40   
Make sure ticket is always synchronized with tax information when using Web POS Save Removed Tickets preference:

- When clicking on Delete Receipt button without adding any line to the ticket, ticket shouldn't be synchronized as it is a draft ticket without lines.

- When adding a product, clicking on Delete line button and clicking on Delete Receipt button, ticket should be synchronized with 0 amount taxes, as it is a draft ticket with deleted lines.
(0125406)
hgbot   
2021-01-13 09:50   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/244 [^]
(0125407)
hgbot   
2021-01-13 09:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 8b212962471173089ea17d9a45c20503a8b7dfb0
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 2021-01-13T09:48:46+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/8b212962471173089ea17d9a45c20503a8b7dfb0 [^]

Fixes ISSUE-45680: Do not sync delete ticket without lines

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js
---
(0125408)
hgbot   
2021-01-13 09:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 0dc08cbeb5db01f50b780974988d0869904a29ca
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 2021-01-13T09:48:46+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/0dc08cbeb5db01f50b780974988d0869904a29ca [^]

Fixes ISSUE-45680: Allow to delete several tickets in deleteTicket action

---
M web-test/model/business-object/ticket/actions/DeleteTicket.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0125409)
hgbot   
2021-01-13 09:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: da660abcbce48505626386f0541dd4ce197c5d90
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 2021-01-13T09:48:46+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/da660abcbce48505626386f0541dd4ce197c5d90 [^]

Fixes ISSUE-45680: Add more tests for DeleteTicket action

---
M web-test/model/business-object/ticket/actions/DeleteTicket.test.js
---
(0125410)
hgbot   
2021-01-13 09:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 94a121776ba46576cf9d99f33c89749a9f61bfc8
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 2021-01-13T09:48:46+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/94a121776ba46576cf9d99f33c89749a9f61bfc8 [^]

Fixes ISSUE-45680: Synchronize ticket without lines. It will be fixed in a different issue

---
M web-test/model/business-object/ticket/actions/DeleteTicket.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js
---
(0125411)
hgbot   
2021-01-13 09:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 2fb5694a3a9005b0b85abff1be6bdbd5bbe9ba80
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 2021-01-13T09:48:46+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/2fb5694a3a9005b0b85abff1be6bdbd5bbe9ba80 [^]

Fixes ISSUE-45680: Calculate deleted ticket header taxes from lines and deletedLines

---
M web-test/model/business-object/ticket/actions/DeleteTicket.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js
---
(0125412)
hgbot   
2021-01-13 09:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6c7a0cb99b06a161fa86d9db499263101399699e
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 2021-01-13T09:49:40+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6c7a0cb99b06a161fa86d9db499263101399699e [^]

Fixes ISSUE-45680: Delete ticket from cashup window doesn't delete the correct ticket

---
M web-test/model/business-object/ticket/actions/DeleteTicket.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---