Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045662Localization Pack: SpainSII Retailpublic2020-12-29 11:502021-01-29 09:04
Reporterpsanjuan 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0045662: SII module does not support "Issue Sales Order" function related to Delivery Modes.
DescriptionSII module does not support "Issue Sales Order" function related to Delivery Modes.
Steps To Reproduce- In an Openbravo enviroment, enable Delivery Mode function in the backoffice. For doing so, create the preference "Web POS Enable Delivery Modes" and set it as Value = Yes, for all users and organizations. Set "selected" parameter as Yes.

- Log in to Web POS using Vallblanca User
- Select Arturo Montoro customer
- Select Menu option "Receipt Properties" to change Invoice Terms to "After Delivery" and Default Delivery Mode as "Pick Up in Store". Press Apply.

- Select any product and make sure that product line has Pickup in Store" delivery mode.
- Complete and pay the sale.

- Navigate to the backoffice and verify that no invoice has been created for this sale but a sales order set as not invoiced.

- Go back to Web POS and Issue the sales order (ie 147).

- Go back to backoffice, navigate to the Sales Invoice, select the record created for previous sales.
- Realize that Transaction Document is set as "VBS AR Invoice", Invoice Type Key is set as "null", while it should have been set as "Invoice".

- Please also note that the field "Operation date" is set to Null, while it should be set to the Order Date.

See image attached.
Proposed SolutionIssue Sales Order funtion always creates an Invoice (Transation Type = VBS AR Invoice) in the backoffice.
SII module has to set Invoice Type Key field as "Invoice"
and Operation Date as "Sales Order Date".
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0041317 closed AtulOpenbravo Correct "Clave de Tipo de Factura" needs to be assigned to the invoices, once Invoicing improvementes are implemented in POS 
Attached Filesjpg Issue_45662.jpg (80,181) 2020-12-29 12:02
https://issues.openbravo.com/file_download.php?file_id=15212&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2020-12-29 11:50psanjuanNew Issue
2020-12-29 11:50psanjuanAssigned To => Jorge Bravo
2020-12-29 11:52psanjuanProposed Solution updated
2020-12-29 11:55psanjuanRelationship addedrelated to 0041317
2020-12-29 11:58psanjuanAssigned ToJorge Bravo => AtulOpenbravo
2020-12-29 11:58psanjuanCategorySII => SII Retail
2020-12-29 12:02psanjuanFile Added: Issue_45662.jpg
2020-12-30 18:50AtulOpenbravoStatusnew => scheduled
2020-12-30 20:09AtulOpenbravoNote Added: 0125190
2020-12-30 20:10hgbotNote Added: 0125191
2021-01-27 12:15psanjuanNote Edited: 0125190bug_revision_view_page.php?bugnote_id=0125190#r22080
2021-01-27 12:16psanjuanNote Added: 0125800
2021-01-28 12:17psanjuanNote Edited: 0125800bug_revision_view_page.php?bugnote_id=0125800#r22086
2021-01-28 12:23psanjuanNote Edited: 0125800bug_revision_view_page.php?bugnote_id=0125800#r22087
2021-01-29 09:00hgbotNote Added: 0125846
2021-01-29 09:00hgbotResolutionopen => fixed
2021-01-29 09:00hgbotStatusscheduled => closed
2021-01-29 09:00hgbotNote Added: 0125847
2021-01-29 09:04hgbotNote Added: 0125848

Notes
(0125190)
AtulOpenbravo   
2020-12-30 20:09   
(edited on: 2021-01-27 12:15)
Test Plan

- In an Openbravo enviroment with SII and SII Retail module, create the preference "Web POS Enable Delivery Modes" and set it as Value = Yes, for all users and organizations in backoffice.

- Log in to Web POS using Vallblanca User
- Select Arturo Montoro customer

- Select Menu option "Receipt Properties" to change Invoice Terms to "After Delivery" and Default Delivery Mode as "Pick Up in Store". Press Apply.

- Select any product and make sure that product line has Pickup in Store" delivery mode. (Edit Ticket Line >> Show More >> Delivery modes)
- Complete and pay the ticket amount. Note the document no for eg: xyz

- Navigate to the backoffice and verify that no invoice has been created for this sale but a sales order set as not invoiced.

- Go back to Web POS and Issue the sales order. Selected the Order by filtering it with document no xyz, select the Order and process with it.

- Go back to backoffice, navigate to the Sales Invoice, select the record created for previous sales.

- Realize that Transaction Document is set as "VBS AR Invoice", Invoice Type Key is set as "Invoice" and field "Operation date" is set with Sales Order's Order Date.
(0125191)
hgbot   
2020-12-30 20:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/merge_requests/2 [^]
(0125800)
psanjuan   
2021-01-27 12:16   
(edited on: 2021-01-28 12:23)
Test Plan

Test 1

- In an Openbravo enviroment with SII and SII Retail module, create the preference "Web POS Enable Delivery Modes" and set it as Value = Yes, for all users and organizations in backoffice.

- Go to Channel-touchpoint window, and select the touchpoint VBS-1, navigate to its channel touchpoint type.

- Select the option "Generate Simplified Invoices". Save.

- Log in to Web POS using Vallblanca User
- Select Arturo Montoro customer

- Select Menu option "Receipt Properties" to change Invoice Terms to "After Delivery" and Default Delivery Mode as "Pick Up in Store". Press Apply.

- Select any product and make sure that product line has Pickup in Store" delivery mode. (Edit Ticket Line >> Show More >> Delivery modes)
- Complete and pay the ticket amount. Note the document no for eg: xyz

- Navigate to the backoffice and verify that no invoice has been created for this sale but a sales order set as not invoiced.

- Go back to Web POS and Issue the sales order. Selected the Order by filtering it with document no xyz, select the Order and process with it.

- Go back to backoffice, navigate to the Sales Invoice, select the record created for previous sales.

- Realize that Transaction Document is set as "VBS AR Invoice", Invoice Type Key is set as "Invoice" and field "Operation date" is set with Sales Order's Order Date.

- Go back to Openbravo Web POS and return the sale by using Vefiried Returns. Complete and Pay the return sale.

- Go to the backoffice and verify that a new Reverse Sales Invoice document has been created with below data:
Invoice type key = Corrective Invoice
Rectification invoice type = Differences
Rectification reason = R1

Test 2

Repeat test 1 with below setup

- Go to Channel-touchpoint window, and select the touchpoint VBS-1, navigate to its channel touchpoint type.

- Select the option "Generate Aggregated Invoices". Save.

- Get the same result


Test 3

- Repeat the same test with any of the setup before, and create an order that mix some lines with pick & delivery and pickup in store. Customer invoice terms After Delivery.

- Verify that in all cases the invoices created are AR Invoice, and Invoice Type Key = Invoice.


issue can be closed.
(0125846)
hgbot   
2021-01-29 09:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/merge_requests/2 [^]
(0125847)
hgbot   
2021-01-29 09:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail [^]
Changeset: 99eb0150cf9e54316f54bd5b501e1e95116abba2
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 2021-01-29T08:00:45+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/commit/99eb0150cf9e54316f54bd5b501e1e95116abba2 [^]

Fixes BUG-0045662: SII module does not support "Issue Sales Order"
function related to Delivery Modes.

**Added InvoiceShipmentHook that updates the Invoice with Invoice
Type key as Invoice and Operation Date as "Sales Order Date".

---
A src/org/openbravo/module/sii/retail/hook/SIIInvoiceShipmentHook.java
A src/org/openbravo/module/sii/retail/hook/SIIUtility.java
M src/org/openbravo/module/sii/retail/hook/SIIFinishInvoiceHook.java
---
(0125848)
hgbot   
2021-01-29 09:04   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail [^]
Changeset: c237077c65a1b75ebae24f3d2bba6385715bc45a
Author: Álvaro Ferraz <alvaro.ferraz@openbravo.com>
Date: 2021-01-29T09:03:57+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii.retail/-/commit/c237077c65a1b75ebae24f3d2bba6385715bc45a [^]

Related to BUG-0045662: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---