Openbravo Issue Tracking System - Retail Modules
View Issue Details
0045655Retail ModulesWeb POSpublic2020-12-28 16:042021-10-25 16:06
marvintm 
ranjith_qualiantech_com 
normalcriticalhave not tried
closedfixed 
5
 
RR21Q1 
No
0045655: WebPOS fails with Chrome v89, because of new .at() function in Strings
In Chrome v89, the String prototype has a new at() function. This is a problem with the current implementation of the WebPOS, because the .at function is used to distinguish between Backbone collections and other types of objects.
Using Chrome Dev branch, log in the WebPOS. Realise the following Javascript error is raised:

Uncaught (in promise) TypeError: clonedObject.get(...).reset is not a function
    at 54efdf8ddc7966329ee58389bd8dd37b.js:14770
    at Array.forEach (<anonymous>)
    at Function.b.each.b.forEach (underscore-1.3.3.min.js:11)
    at cloneRecursively (54efdf8ddc7966329ee58389bd8dd37b.js:14762)
    at Object.OB.UTIL.clone (54efdf8ddc7966329ee58389bd8dd37b.js:14849)
    at G.d.clearWith (54efdf8ddc7966329ee58389bd8dd37b.js:66024)
    at Object.OB.UTIL.TicketUtils.loadAndSyncTicketFromState (54efdf8ddc7966329ee58389b

Instead of checking the .at() function, it should be checked whether the object is instance of Backbone.Collection.
No tags attached.
depends on backport 0045656RR20Q4.1 closed ranjith_qualiantech_com WebPOS fails with Chrome v89, because of new .at() function in Strings 
depends on backport 0045657RR20Q3.3 closed ranjith_qualiantech_com WebPOS fails with Chrome v89, because of new .at() function in Strings 
related to defect 0047453pi closed javierRodriguez issue with chrome 92 in addPromotion manual 
related to defect 0047463 closed ranjith_qualiantech_com Multiupc scan problem 
diff 45655_18Q3_mobilecore.diff (989) 2021-10-25 16:06
https://issues.openbravo.com/file_download.php?file_id=16298&type=bug
Issue History
2020-12-28 16:04marvintmNew Issue
2020-12-28 16:04marvintmAssigned To => ranjith_qualiantech_com
2020-12-28 16:04marvintmTriggers an Emergency Pack => No
2020-12-28 16:04marvintmStatusnew => scheduled
2020-12-29 07:23hgbotNote Added: 0125118
2020-12-29 07:42hgbotResolutionopen => fixed
2020-12-29 07:42hgbotStatusscheduled => closed
2020-12-29 07:42hgbotNote Added: 0125119
2020-12-29 07:42hgbotFixed in Version => RR21Q1
2020-12-29 07:42hgbotNote Added: 0125120
2021-07-26 17:05adrianromeroRelationship addedrelated to 0047393
2021-07-26 17:05adrianromeroRelationship deletedrelated to 0047393
2021-07-26 17:06adrianromeroRelationship addedblocks 0047453
2021-07-26 17:06adrianromeroRelationship deletedblocks 0047453
2021-07-26 17:06adrianromeroRelationship addedrelated to 0047453
2021-07-28 10:25ranjith_qualiantech_comRelationship addedrelated to 0047463
2021-10-25 16:06ranjith_qualiantech_comFile Added: 45655_18Q3_mobilecore.diff

Notes
(0125118)
hgbot   
2020-12-29 07:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/118 [^]
(0125119)
hgbot   
2020-12-29 07:42   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/118 [^]
(0125120)
hgbot   
2020-12-29 07:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 7e1c050a3af39643c00724a4890562439f2f07fc
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-12-29T07:15:31+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/7e1c050a3af39643c00724a4890562439f2f07fc [^]

Fixed ISSUE-45655: Replace Object validation with Backbone instance when cloning object

---
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
---