Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045638Retail ModulesWeb POSpublic2020-12-22 15:422021-01-29 10:08
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR21Q2 
Merge Request Statusapproved
Review Assigned Tojarmendariz
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045638: Extend state actions and hooks to allow usage and return of Global State
DescriptionCurrently, model actions and hooks in mobile.core only support state at the model level(not counting Global Actions), and return a part of the State, the one regarding the model.

This is a limitation for other tasks, as such, an extension should be made on those hooks to accept and return the modified state, completely, that means, if a Global State is provided, it should apply the same changes as before, but return the modified Global State, not just the part regarding the model.

This should be done in the scope of org.openbravo.mobile.core module.
Steps To ReproduceIn description.
Proposed SolutionAdd a third parameter to actions and hooks that also includes the Global State(options), if this parameter is present where needed, state returned will be the global state with the modified parts, instead of only the model with the modified parts.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0045806RR21Q1.1 closed ranjith_qualiantech_com Extend state actions and hooks to allow usage and return of Global State 
depends on backport 0045807RR20Q4.2 closed ranjith_qualiantech_com Extend state actions and hooks to allow usage and return of Global State 
depends on backport 0045808RR20Q3.4 closed ranjith_qualiantech_com Extend state actions and hooks to allow usage and return of Global State 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2020-12-22 15:42cbernerNew Issue
2020-12-22 15:42cbernerAssigned To => cberner
2020-12-22 15:42cbernerOBNetwork customer => No
2020-12-22 15:42cbernerTriggers an Emergency Pack => No
2020-12-22 15:42cbernerTypedefect => feature request
2020-12-22 17:16cbernerSummaryExtend state actions to allow usage and return of Global State => Extend state model hook to allow usage and return of Global State
2020-12-22 17:16cbernerDescription Updatedbug_revision_view_page.php?rev_id=21968#r21968
2020-12-22 17:16cbernerProposed Solution updated
2020-12-23 13:58cbernerSummaryExtend state model hook to allow usage and return of Global State => Extend state actions and hooks to allow usage and return of Global State
2020-12-23 13:58cbernerDescription Updatedbug_revision_view_page.php?rev_id=21969#r21969
2020-12-23 13:58cbernerProposed Solution updated
2020-12-28 15:49hgbotMerge Request Status => open
2020-12-28 15:49hgbotNote Added: 0125111
2021-01-07 16:15hgbotMerge Request Statusopen => approved
2021-01-07 16:18hgbotNote Added: 0125291
2021-01-07 16:18hgbotNote Added: 0125292
2021-01-07 16:23jarmendarizNote Added: 0125293
2021-01-07 16:23jarmendarizReview Assigned To => jarmendariz
2021-01-07 16:23jarmendarizStatusnew => scheduled
2021-01-07 16:24jarmendarizNote Added: 0125294
2021-01-07 16:24jarmendarizStatusscheduled => resolved
2021-01-07 16:24jarmendarizResolutionopen => fixed
2021-01-07 16:25jarmendarizStatusresolved => closed
2021-01-29 07:23marvintmStatusclosed => new
2021-01-29 07:23marvintmResolutionfixed => open
2021-01-29 07:23marvintmStatusnew => scheduled
2021-01-29 07:24marvintmStatusscheduled => resolved
2021-01-29 07:24marvintmFixed in Version => RR21Q2
2021-01-29 07:24marvintmResolutionopen => fixed
2021-01-29 07:24marvintmStatusresolved => closed
2021-01-29 10:08martinsdanIssue Monitored: martinsdan

Notes
(0125111)
hgbot   
2020-12-28 15:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/117 [^]
(0125291)
hgbot   
2021-01-07 16:18   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 686943ff04237705a7c54c046a66dbb07bb5a555
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 2021-01-07T16:16:14+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/686943ff04237705a7c54c046a66dbb07bb5a555 [^]

Merge FR-45638: Extends StateAPI to support model actions that returns the global state instead of only the model

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/117 [^]

---
M web-test/base/state-utils.js
M web-test/model/application-state/State.test.js
M web-test/model/application-state/StatePersistence.functional.test.js
M web/org.openbravo.mobile.core/app/model/application-state/State.js
M web/org.openbravo.mobile.core/app/model/application-state/StatePersistence.js
---
(0125292)
hgbot   
2021-01-07 16:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/117 [^]
(0125293)
jarmendariz   
2021-01-07 16:23   
Reviewed and merged to master
(0125294)
jarmendariz   
2021-01-07 16:24   
Resolved in commit https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/686943ff04237705a7c54c046a66dbb07bb5a555 [^]